Re: [PATCH v2] drm/loongson: Add a check for lsdc_bo_create() errors

[suijingfeng]

Hi,


This version is ok, I'll apply this patch within a few days.


On 2023/7/19 16:45, Dan Carpenter wrote:

This code doesn't check for lsdc_bo_create() failure and it could lead
to a crash.  It can fail for a variety of reasons, but the most common
cause would be low memory.  Add a check.

Fixes: f39db26c5428 ("drm: Add kms driver for loongson display controller")
Signed-off-by: Dan Carpenter 
Reviewed-by: Sui Jingfeng 
---
v2: change subject and re-word the commit message

  drivers/gpu/drm/loongson/lsdc_ttm.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c 
b/drivers/gpu/drm/loongson/lsdc_ttm.c
index bb0c8fd43a75..bf79dc55afa4 100644
--- a/drivers/gpu/drm/loongson/lsdc_ttm.c
+++ b/drivers/gpu/drm/loongson/lsdc_ttm.c
@@ -496,6 +496,8 @@ struct lsdc_bo *lsdc_bo_create_kernel_pinned(struct 
drm_device *ddev,
int ret;
  
  	lbo = lsdc_bo_create(ddev, domain, size, true, NULL, NULL);

+   if (IS_ERR(lbo))
+   return ERR_CAST(lbo);
  
  	ret = lsdc_bo_reserve(lbo);

if (unlikely(ret)) {

[PATCH v2] drm/loongson: Add a check for lsdc_bo_create() errors

[Dan Carpenter]

This code doesn't check for lsdc_bo_create() failure and it could lead
to a crash.  It can fail for a variety of reasons, but the most common
cause would be low memory.  Add a check.

Fixes: f39db26c5428 ("drm: Add kms driver for loongson display controller")
Signed-off-by: Dan Carpenter 
Reviewed-by: Sui Jingfeng 
---
v2: change subject and re-word the commit message

 drivers/gpu/drm/loongson/lsdc_ttm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/loongson/lsdc_ttm.c 
b/drivers/gpu/drm/loongson/lsdc_ttm.c
index bb0c8fd43a75..bf79dc55afa4 100644
--- a/drivers/gpu/drm/loongson/lsdc_ttm.c
+++ b/drivers/gpu/drm/loongson/lsdc_ttm.c
@@ -496,6 +496,8 @@ struct lsdc_bo *lsdc_bo_create_kernel_pinned(struct 
drm_device *ddev,
int ret;
 
lbo = lsdc_bo_create(ddev, domain, size, true, NULL, NULL);
+   if (IS_ERR(lbo))
+   return ERR_CAST(lbo);
 
ret = lsdc_bo_reserve(lbo);
if (unlikely(ret)) {
-- 
2.39.2