Re: [PATCH v2] drm/msm/adreno: Add missing MODULE_FIRMWARE macros

2023-08-15 Thread Joel Fernandes 
On Tue, Aug 15, 2023 at 7:52 AM Juerg Haefliger
 wrote:
>
> On Thu, 22 Jun 2023 21:44:25 +0300
> Dmitry Baryshkov  wrote:
>
> > On 20/06/2023 08:40, Juerg Haefliger wrote:
> > > The driver references some firmware files that don't have corresponding
> > > MODULE_FIRMWARE macros and thus won't be listed via modinfo. Fix that.
> > >
> > > Signed-off-by: Juerg Haefliger 
> > >
> > > ---
> > > v2:
> > >- Drop addition and removal of zap files (needs more discussion)
> > >- Add new a690_gmu.bin
> > >- Update commit subject and message accordingly
> > > ---
> > >   drivers/gpu/drm/msm/adreno/adreno_device.c | 11 +++
> > >   1 file changed, 11 insertions(+)
> >
> > Reviewed-by: Dmitry Baryshkov 
> >
>

Reviewed-by: Joel Fernandes (Google) 

thanks,

 - Joel

Re: [PATCH v2] drm/msm/adreno: Add missing MODULE_FIRMWARE macros

2023-08-15 Thread Juerg Haefliger 
On Thu, 22 Jun 2023 21:44:25 +0300
Dmitry Baryshkov  wrote:

> On 20/06/2023 08:40, Juerg Haefliger wrote:
> > The driver references some firmware files that don't have corresponding
> > MODULE_FIRMWARE macros and thus won't be listed via modinfo. Fix that.
> > 
> > Signed-off-by: Juerg Haefliger 
> > 
> > ---
> > v2:
> >- Drop addition and removal of zap files (needs more discussion)
> >- Add new a690_gmu.bin
> >- Update commit subject and message accordingly
> > ---
> >   drivers/gpu/drm/msm/adreno/adreno_device.c | 11 +++
> >   1 file changed, 11 insertions(+)  
> 
> Reviewed-by: Dmitry Baryshkov 
> 

It looks like this didn't go anywhere. Is there something missing?

...Juerg


pgpyeCmru6MBZ.pgp
Description: OpenPGP digital signature

Re: [PATCH v2] drm/msm/adreno: Add missing MODULE_FIRMWARE macros

2023-06-22 Thread Dmitry Baryshkov 

On 20/06/2023 08:40, Juerg Haefliger wrote:

The driver references some firmware files that don't have corresponding
MODULE_FIRMWARE macros and thus won't be listed via modinfo. Fix that.

Signed-off-by: Juerg Haefliger 

---
v2:
   - Drop addition and removal of zap files (needs more discussion)
   - Add new a690_gmu.bin
   - Update commit subject and message accordingly
---
  drivers/gpu/drm/msm/adreno/adreno_device.c | 11 +++
  1 file changed, 11 insertions(+)


Reviewed-by: Dmitry Baryshkov 


--
With best wishes
Dmitry

[PATCH v2] drm/msm/adreno: Add missing MODULE_FIRMWARE macros

2023-06-19 Thread Juerg Haefliger 
The driver references some firmware files that don't have corresponding
MODULE_FIRMWARE macros and thus won't be listed via modinfo. Fix that.

Signed-off-by: Juerg Haefliger 

---
v2:
  - Drop addition and removal of zap files (needs more discussion)
  - Add new a690_gmu.bin
  - Update commit subject and message accordingly
---
 drivers/gpu/drm/msm/adreno/adreno_device.c | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c 
b/drivers/gpu/drm/msm/adreno/adreno_device.c
index cb94cfd137a8..7c1f9a844009 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -397,10 +397,21 @@ MODULE_FIRMWARE("qcom/a530_zap.mdt");
 MODULE_FIRMWARE("qcom/a530_zap.b00");
 MODULE_FIRMWARE("qcom/a530_zap.b01");
 MODULE_FIRMWARE("qcom/a530_zap.b02");
+MODULE_FIRMWARE("qcom/a540_gpmu.fw2");
 MODULE_FIRMWARE("qcom/a619_gmu.bin");
 MODULE_FIRMWARE("qcom/a630_sqe.fw");
 MODULE_FIRMWARE("qcom/a630_gmu.bin");
 MODULE_FIRMWARE("qcom/a630_zap.mbn");
+MODULE_FIRMWARE("qcom/a640_gmu.bin");
+MODULE_FIRMWARE("qcom/a650_gmu.bin");
+MODULE_FIRMWARE("qcom/a650_sqe.fw");
+MODULE_FIRMWARE("qcom/a660_gmu.bin");
+MODULE_FIRMWARE("qcom/a660_sqe.fw");
+MODULE_FIRMWARE("qcom/a690_gmu.bin");
+MODULE_FIRMWARE("qcom/leia_pfp_470.fw");
+MODULE_FIRMWARE("qcom/leia_pm4_470.fw");
+MODULE_FIRMWARE("qcom/yamato_pfp.fw");
+MODULE_FIRMWARE("qcom/yamato_pm4.fw");
 
 static inline bool _rev_match(uint8_t entry, uint8_t id)
 {
-- 
2.37.2