Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for One Mix 2S

2023-10-03 Thread Liviu Dudau 
On Sun, Oct 01, 2023 at 02:21:43PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 10/1/23 13:47, Kai Uwe Broulik wrote:
> > The One Mix 2S is a mini laptop with a 1200x1920 portrait screen
> > mounted in a landscape oriented clamshell case. Because of the too
> > generic DMI strings this entry is also doing bios-date matching.
> > 
> > Signed-off-by: Kai Uwe Broulik 
> > ---
> > Changes since v1:
> > * Got two more BIOS dates reported
> 
> Thanks, patch still looks good to me:
> 
> Reviewed-by: Hans de Goede 
> 
> drm-misc maintainers, I'm currently traveling can
> one of you push this to drm-misc-fixes please?

Done. Have a safe trip.

Best regards,
Liviu

> 
> Regards,
> 
> Hans
> 
> 
> 
> 
> > 
> >  drivers/gpu/drm/drm_panel_orientation_quirks.c | 16 
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c 
> > b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index 0cb646cb04ee..d5c15292ae93 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -38,6 +38,14 @@ static const struct drm_dmi_panel_orientation_data 
> > gpd_micropc = {
> > .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> >  };
> >  
> > +static const struct drm_dmi_panel_orientation_data gpd_onemix2s = {
> > +   .width = 1200,
> > +   .height = 1920,
> > +   .bios_dates = (const char * const []){ "05/21/2018", "10/26/2018",
> > +   "03/04/2019", NULL },
> > +   .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> > +};
> > +
> >  static const struct drm_dmi_panel_orientation_data gpd_pocket = {
> > .width = 1200,
> > .height = 1920,
> > @@ -401,6 +409,14 @@ static const struct dmi_system_id orientation_data[] = 
> > {
> >   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
> > },
> > .driver_data = (void *)_rightside_up,
> > +   }, {/* One Mix 2S (generic strings, also match on bios date) */
> > +   .matches = {
> > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
> > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
> > + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
> > + DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
> > +   },
> > +   .driver_data = (void *)_onemix2s,
> > },
> > {}
> >  };
> 

-- 

| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---
¯\_(ツ)_/¯

[PATCH v2] drm: panel-orientation-quirks: Add quirk for One Mix 2S

2023-10-02 Thread Kai Uwe Broulik 
The One Mix 2S is a mini laptop with a 1200x1920 portrait screen
mounted in a landscape oriented clamshell case. Because of the too
generic DMI strings this entry is also doing bios-date matching.

Signed-off-by: Kai Uwe Broulik 
---
Changes since v1:
* Got two more BIOS dates reported

 drivers/gpu/drm/drm_panel_orientation_quirks.c | 16 
 1 file changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c 
b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 0cb646cb04ee..d5c15292ae93 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -38,6 +38,14 @@ static const struct drm_dmi_panel_orientation_data 
gpd_micropc = {
.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };
 
+static const struct drm_dmi_panel_orientation_data gpd_onemix2s = {
+   .width = 1200,
+   .height = 1920,
+   .bios_dates = (const char * const []){ "05/21/2018", "10/26/2018",
+   "03/04/2019", NULL },
+   .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
+
 static const struct drm_dmi_panel_orientation_data gpd_pocket = {
.width = 1200,
.height = 1920,
@@ -401,6 +409,14 @@ static const struct dmi_system_id orientation_data[] = {
  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
},
.driver_data = (void *)_rightside_up,
+   }, {/* One Mix 2S (generic strings, also match on bios date) */
+   .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
+ DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
+   },
+   .driver_data = (void *)_onemix2s,
},
{}
 };
-- 
2.34.1

Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for One Mix 2S

2023-10-01 Thread Hans de Goede 
Hi,

On 10/1/23 13:47, Kai Uwe Broulik wrote:
> The One Mix 2S is a mini laptop with a 1200x1920 portrait screen
> mounted in a landscape oriented clamshell case. Because of the too
> generic DMI strings this entry is also doing bios-date matching.
> 
> Signed-off-by: Kai Uwe Broulik 
> ---
> Changes since v1:
> * Got two more BIOS dates reported

Thanks, patch still looks good to me:

Reviewed-by: Hans de Goede 

drm-misc maintainers, I'm currently traveling can
one of you push this to drm-misc-fixes please?

Regards,

Hans




> 
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 16 
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c 
> b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 0cb646cb04ee..d5c15292ae93 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -38,6 +38,14 @@ static const struct drm_dmi_panel_orientation_data 
> gpd_micropc = {
>   .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
>  };
>  
> +static const struct drm_dmi_panel_orientation_data gpd_onemix2s = {
> + .width = 1200,
> + .height = 1920,
> + .bios_dates = (const char * const []){ "05/21/2018", "10/26/2018",
> + "03/04/2019", NULL },
> + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> +};
> +
>  static const struct drm_dmi_panel_orientation_data gpd_pocket = {
>   .width = 1200,
>   .height = 1920,
> @@ -401,6 +409,14 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"),
>   },
>   .driver_data = (void *)_rightside_up,
> + }, {/* One Mix 2S (generic strings, also match on bios date) */
> + .matches = {
> +   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),
> +   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
> +   DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
> +   DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
> + },
> + .driver_data = (void *)_onemix2s,
>   },
>   {}
>  };