Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On Thu, 27 Jul 2023 18:13:33 +0530, Rohit Agarwal wrote: > Update the RPMHPD references with new bindings defined in rpmhpd.h > for Qualcomm SoCs SM8[2345]50. > > Signed-off-by: Rohit Agarwal > --- > > Changes in v2: > - Removed the unnecessary inclusion of header rpmpd.h. > > This patch is dependent on the series that includes the new rpmhpd.h header > https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ > > Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml| 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8 > > .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++--- > .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8 > > .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8 > > Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml| 4 ++-- > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++-- > Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 +++--- > 18 files changed, 44 insertions(+), 44 deletions(-) > Acked-by: Rob Herring
Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On 7/27/2023 5:54 PM, Dmitry Baryshkov wrote: On 27/07/2023 15:21, Rohit Agarwal wrote: On 7/27/2023 5:15 PM, Krzysztof Kozlowski wrote: On 27/07/2023 13:19, Rohit Agarwal wrote: On 7/27/2023 4:46 PM, Rob Herring wrote: On Thu, 27 Jul 2023 14:39:13 +0530, Rohit Agarwal wrote: Update the RPMHPD references with new bindings defined in rpmhpd.h for Qualcomm SoCs SM8[2345]50. Signed-off-by: Rohit Agarwal --- Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8 .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++--- .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8 .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml | 4 ++-- Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++-- Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 +++--- 18 files changed, 44 insertions(+), 44 deletions(-) My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dts:21:18: fatal error: dt-bindings/power/qcom,rpmhpd.h: No such file or directory 21 | #include | ^ compilation terminated. make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1690448953-23425-1-git-send-email-quic_rohia...@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. This should be ignored as the patch that creates the new header is already applied. Please follow this series https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ Please mention the dependency in patch changelog ---, so it is obvious for people applying it and also for the bot. Sure. Will send a cover letter for this patch mentioning the changelogs and will keep the version as v2 since there no change at all in the patch. What would be the merge strategy? Even if you split it per subsystem, I probably can not pick up display parts. Is there an immutable branch with the new header? Otherwise I can either ack Bjorn picking up this patch or it will have to wait for the next cycle. The reason why I sent it as a single patch is that maintainers cannot pick it up separately. So since Bjorn already have the new header change included in the tree, it would be better if he picks it up. Thanks, Rohit. Thanks, Rohit. Best regards, Krzysztof
[PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
Update the RPMHPD references with new bindings defined in rpmhpd.h
for Qualcomm SoCs SM8[2345]50.
Signed-off-by: Rohit Agarwal
---
Changes in v2:
- Removed the unnecessary inclusion of header rpmpd.h.
This patch is dependent on the series that includes the new rpmhpd.h header
https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/
Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++--
Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++--
Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml| 4 ++--
Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++--
Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++--
Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++--
Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++--
.../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++--
.../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8
.../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++--
.../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++---
.../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++--
.../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8
.../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++--
.../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8
Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml| 4 ++--
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++--
Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 +++---
18 files changed, 44 insertions(+), 44 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
index d6774db..59cc88a 100644
--- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
@@ -82,7 +82,7 @@ additionalProperties: false
examples:
- |
#include
-#include
+#include
clock-controller@af0 {
compatible = "qcom,sm8250-dispcc";
reg = <0x0af0 0x1>;
@@ -103,7 +103,7 @@ examples:
#clock-cells = <1>;
#reset-cells = <1>;
#power-domain-cells = <1>;
- power-domains = < SM8250_MMCX>;
+ power-domains = < RPMHPD_MMCX>;
required-opps = <_opp_low_svs>;
};
...
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml
b/Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml
index 23505c8..d723bb1 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml
@@ -51,7 +51,7 @@ unevaluatedProperties: false
examples:
- |
#include
-#include
+#include
clock-controller@abf {
compatible = "qcom,sm8350-videocc";
@@ -59,7 +59,7 @@ examples:
clocks = < RPMH_CXO_CLK>,
< RPMH_CXO_CLK_A>,
<_clk>;
- power-domains = < SM8350_MMCX>;
+ power-domains = < RPMHPD_MMCX>;
required-opps = <_opp_low_svs>;
#clock-cells = <1>;
#reset-cells = <1>;
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
index 87ae741..8178c35 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
@@ -64,7 +64,7 @@ examples:
- |
#include
#include
-#include
+#include
clock-controller@ade {
compatible = "qcom,sm8450-camcc";
reg = <0xade 0x2>;
@@ -72,7 +72,7 @@ examples:
< RPMH_CXO_CLK>,
< RPMH_CXO_CLK_A>,
<_clk>;
- power-domains = < SM8450_MMCX>;
+ power-domains = < RPMHPD_MMCX>;
required-opps = <_opp_low_svs>;
#clock-cells = <1>;
#reset-cells = <1>;
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml
b/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml
index 1dd1f69..2f22310 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml
@@ -76,7 +76,7 @@ examples:
- |
#include
#include
-#include
+#include
clock-controller@af0 {
compatible = "qcom,sm8450-dispcc";
reg = <0x0af0 0x1>;
@@ -91,7 +91,7 @@ examples:
#clock-cells = <1>;
#reset-cells = <1>;
#power-domain-cells = <1>;
- power-domains = < SM8450_MMCX>;
+ power-domains = < RPMHPD_MMCX>;
required-opps = <_opp_low_svs>;
};
...
diff --git
Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On 7/27/2023 4:46 PM, Rob Herring wrote: On Thu, 27 Jul 2023 14:39:13 +0530, Rohit Agarwal wrote: Update the RPMHPD references with new bindings defined in rpmhpd.h for Qualcomm SoCs SM8[2345]50. Signed-off-by: Rohit Agarwal --- Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml| 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8 .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++--- .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8 .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml| 4 ++-- Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++-- Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 +++--- 18 files changed, 44 insertions(+), 44 deletions(-) My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dts:21:18: fatal error: dt-bindings/power/qcom,rpmhpd.h: No such file or directory 21 | #include | ^ compilation terminated. make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1690448953-23425-1-git-send-email-quic_rohia...@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. This should be ignored as the patch that creates the new header is already applied. Please follow this series https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ Thanks, Rohit.
Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On 7/27/2023 6:46 PM, Rob Herring wrote: On Thu, 27 Jul 2023 18:13:33 +0530, Rohit Agarwal wrote: Update the RPMHPD references with new bindings defined in rpmhpd.h for Qualcomm SoCs SM8[2345]50. Signed-off-by: Rohit Agarwal --- Changes in v2: - Removed the unnecessary inclusion of header rpmpd.h. This patch is dependent on the series that includes the new rpmhpd.h header https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml| 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8 .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++--- .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8 .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml| 4 ++-- Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++-- Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 +++--- 18 files changed, 44 insertions(+), 44 deletions(-) My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dts:21:18: fatal error: dt-bindings/power/qcom,rpmhpd.h: No such file or directory 21 | #include | ^ compilation terminated. make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1690461813-22564-1-git-send-email-quic_rohia...@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. We can ignore this error as the dependency is mentioned in the changelog that adds this new header. Also have tested locally with these dependencies in place. Thanks, Rohit.
[PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
Update the RPMHPD references with new bindings defined in rpmhpd.h
for Qualcomm SoCs SM8[2345]50.
Signed-off-by: Rohit Agarwal
---
Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++--
Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++--
Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml| 4 ++--
Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++--
Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++--
Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++--
Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++--
.../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++--
.../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8
.../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++--
.../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++---
.../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++--
.../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8
.../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++--
.../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8
Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml| 4 ++--
Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++--
Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 +++---
18 files changed, 44 insertions(+), 44 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
index d6774db..59cc88a 100644
--- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
@@ -82,7 +82,7 @@ additionalProperties: false
examples:
- |
#include
-#include
+#include
clock-controller@af0 {
compatible = "qcom,sm8250-dispcc";
reg = <0x0af0 0x1>;
@@ -103,7 +103,7 @@ examples:
#clock-cells = <1>;
#reset-cells = <1>;
#power-domain-cells = <1>;
- power-domains = < SM8250_MMCX>;
+ power-domains = < RPMHPD_MMCX>;
required-opps = <_opp_low_svs>;
};
...
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml
b/Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml
index 23505c8..d723bb1 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml
@@ -51,7 +51,7 @@ unevaluatedProperties: false
examples:
- |
#include
-#include
+#include
clock-controller@abf {
compatible = "qcom,sm8350-videocc";
@@ -59,7 +59,7 @@ examples:
clocks = < RPMH_CXO_CLK>,
< RPMH_CXO_CLK_A>,
<_clk>;
- power-domains = < SM8350_MMCX>;
+ power-domains = < RPMHPD_MMCX>;
required-opps = <_opp_low_svs>;
#clock-cells = <1>;
#reset-cells = <1>;
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
index 87ae741..8178c35 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
@@ -64,7 +64,7 @@ examples:
- |
#include
#include
-#include
+#include
clock-controller@ade {
compatible = "qcom,sm8450-camcc";
reg = <0xade 0x2>;
@@ -72,7 +72,7 @@ examples:
< RPMH_CXO_CLK>,
< RPMH_CXO_CLK_A>,
<_clk>;
- power-domains = < SM8450_MMCX>;
+ power-domains = < RPMHPD_MMCX>;
required-opps = <_opp_low_svs>;
#clock-cells = <1>;
#reset-cells = <1>;
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml
b/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml
index 1dd1f69..2f22310 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml
@@ -76,7 +76,7 @@ examples:
- |
#include
#include
-#include
+#include
clock-controller@af0 {
compatible = "qcom,sm8450-dispcc";
reg = <0x0af0 0x1>;
@@ -91,7 +91,7 @@ examples:
#clock-cells = <1>;
#reset-cells = <1>;
#power-domain-cells = <1>;
- power-domains = < SM8450_MMCX>;
+ power-domains = < RPMHPD_MMCX>;
required-opps = <_opp_low_svs>;
};
...
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
index f1c6dd5..bad8f01 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
+++
Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On 7/27/2023 5:15 PM, Krzysztof Kozlowski wrote: On 27/07/2023 13:19, Rohit Agarwal wrote: On 7/27/2023 4:46 PM, Rob Herring wrote: On Thu, 27 Jul 2023 14:39:13 +0530, Rohit Agarwal wrote: Update the RPMHPD references with new bindings defined in rpmhpd.h for Qualcomm SoCs SM8[2345]50. Signed-off-by: Rohit Agarwal --- Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml| 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8 .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++--- .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8 .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml| 4 ++-- Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++-- Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 +++--- 18 files changed, 44 insertions(+), 44 deletions(-) My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dts:21:18: fatal error: dt-bindings/power/qcom,rpmhpd.h: No such file or directory 21 | #include | ^ compilation terminated. make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1690448953-23425-1-git-send-email-quic_rohia...@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. This should be ignored as the patch that creates the new header is already applied. Please follow this series https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ Please mention the dependency in patch changelog ---, so it is obvious for people applying it and also for the bot. Sure. Will send a cover letter for this patch mentioning the changelogs and will keep the version as v2 since there no change at all in the patch. Thanks, Rohit. Best regards, Krzysztof
Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On 7/27/2023 6:00 PM, Rohit Agarwal wrote: On 7/27/2023 5:57 PM, Krzysztof Kozlowski wrote: On 27/07/2023 14:21, Rohit Agarwal wrote: https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ Please mention the dependency in patch changelog ---, so it is obvious for people applying it and also for the bot. Sure. Will send a cover letter for this patch mentioning the changelogs and will keep the version as v2 since there no change at all in the patch. There is no need for cover letter for one patch. Yes, I thought the same and thus didnt include the cover letter and changelogs initially. Can you please help where I can add the changelogs and the dependency link? Sorry! Got it. Thanks, Rohit. Thanks, Rohit. Best regards, Krzysztof
Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On 7/27/2023 5:57 PM, Krzysztof Kozlowski wrote: On 27/07/2023 14:21, Rohit Agarwal wrote: https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ Please mention the dependency in patch changelog ---, so it is obvious for people applying it and also for the bot. Sure. Will send a cover letter for this patch mentioning the changelogs and will keep the version as v2 since there no change at all in the patch. There is no need for cover letter for one patch. Yes, I thought the same and thus didnt include the cover letter and changelogs initially. Can you please help where I can add the changelogs and the dependency link? Thanks, Rohit. Best regards, Krzysztof
Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On Thu, 27 Jul 2023 18:13:33 +0530, Rohit Agarwal wrote: > Update the RPMHPD references with new bindings defined in rpmhpd.h > for Qualcomm SoCs SM8[2345]50. > > Signed-off-by: Rohit Agarwal > --- > > Changes in v2: > - Removed the unnecessary inclusion of header rpmpd.h. > > This patch is dependent on the series that includes the new rpmhpd.h header > https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ > > Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml| 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8 > > .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++--- > .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8 > > .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8 > > Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml| 4 ++-- > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++-- > Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 +++--- > 18 files changed, 44 insertions(+), 44 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dts:21:18: fatal error: dt-bindings/power/qcom,rpmhpd.h: No such file or directory 21 | #include | ^ compilation terminated. make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1690461813-22564-1-git-send-email-quic_rohia...@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On 27/07/2023 14:21, Rohit Agarwal wrote: >>> https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ >> Please mention the dependency in patch changelog ---, so it is obvious >> for people applying it and also for the bot. > Sure. Will send a cover letter for this patch mentioning the changelogs > and will > keep the version as v2 since there no change at all in the patch. There is no need for cover letter for one patch. Best regards, Krzysztof
Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On 27/07/2023 15:21, Rohit Agarwal wrote: On 7/27/2023 5:15 PM, Krzysztof Kozlowski wrote: On 27/07/2023 13:19, Rohit Agarwal wrote: On 7/27/2023 4:46 PM, Rob Herring wrote: On Thu, 27 Jul 2023 14:39:13 +0530, Rohit Agarwal wrote: Update the RPMHPD references with new bindings defined in rpmhpd.h for Qualcomm SoCs SM8[2345]50. Signed-off-by: Rohit Agarwal --- Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++-- Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8 .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++--- .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8 .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++-- .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml | 4 ++-- Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++-- Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 +++--- 18 files changed, 44 insertions(+), 44 deletions(-) My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dts:21:18: fatal error: dt-bindings/power/qcom,rpmhpd.h: No such file or directory 21 | #include | ^ compilation terminated. make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1690448953-23425-1-git-send-email-quic_rohia...@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. This should be ignored as the patch that creates the new header is already applied. Please follow this series https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ Please mention the dependency in patch changelog ---, so it is obvious for people applying it and also for the bot. Sure. Will send a cover letter for this patch mentioning the changelogs and will keep the version as v2 since there no change at all in the patch. What would be the merge strategy? Even if you split it per subsystem, I probably can not pick up display parts. Is there an immutable branch with the new header? Otherwise I can either ack Bjorn picking up this patch or it will have to wait for the next cycle. Thanks, Rohit. Best regards, Krzysztof -- With best wishes Dmitry
Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On 27/07/2023 13:19, Rohit Agarwal wrote: > > On 7/27/2023 4:46 PM, Rob Herring wrote: >> On Thu, 27 Jul 2023 14:39:13 +0530, Rohit Agarwal wrote: >>> Update the RPMHPD references with new bindings defined in rpmhpd.h >>> for Qualcomm SoCs SM8[2345]50. >>> >>> Signed-off-by: Rohit Agarwal >>> --- >>> Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++-- >>> Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++-- >>> Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml| 4 ++-- >>> Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++-- >>> Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++-- >>> Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++-- >>> Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++-- >>> .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++-- >>> .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8 >>> >>> .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++-- >>> .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 >>> +++--- >>> .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++-- >>> .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8 >>> >>> .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++-- >>> .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8 >>> >>> Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml| 4 ++-- >>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++-- >>> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 >>> +++--- >>> 18 files changed, 44 insertions(+), 44 deletions(-) >>> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dts:21:18: >> fatal error: dt-bindings/power/qcom,rpmhpd.h: No such file or directory >> 21 | #include >>| ^ >> compilation terminated. >> make[2]: *** [scripts/Makefile.lib:419: >> Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dtb] >> Error 1 >> make[2]: *** Waiting for unfinished jobs >> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: >> dt_binding_check] Error 2 >> make: *** [Makefile:234: __sub-make] Error 2 >> >> doc reference errors (make refcheckdocs): >> >> See >> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1690448953-23425-1-git-send-email-quic_rohia...@quicinc.com >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit after running the above command yourself. Note >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >> your schema. However, it must be unset to test all examples with your schema. > This should be ignored as the patch that creates the new header is > already applied. > Please follow this series > > https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ Please mention the dependency in patch changelog ---, so it is obvious for people applying it and also for the bot. Best regards, Krzysztof
Re: [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs
On Thu, 27 Jul 2023 14:39:13 +0530, Rohit Agarwal wrote: > Update the RPMHPD references with new bindings defined in rpmhpd.h > for Qualcomm SoCs SM8[2345]50. > > Signed-off-by: Rohit Agarwal > --- > Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8350-videocc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml| 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml | 4 ++-- > Documentation/devicetree/bindings/clock/qcom,videocc.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8250-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml | 8 > > .../devicetree/bindings/display/msm/qcom,sm8350-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 +++--- > .../devicetree/bindings/display/msm/qcom,sm8450-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8 > > .../devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml | 4 ++-- > .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8 > > Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml| 4 ++-- > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++-- > Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 6 +++--- > 18 files changed, 44 insertions(+), 44 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dts:21:18: fatal error: dt-bindings/power/qcom,rpmhpd.h: No such file or directory 21 | #include | ^ compilation terminated. make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1690448953-23425-1-git-send-email-quic_rohia...@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
