Re: [PATCH v2 0/6] drm/ast: Managed MM
Am 16.07.20 um 15:24 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Thu, Jul 16, 2020 at 02:53:47PM +0200, Thomas Zimmermann wrote:
>> This is the second patchset for converting ast to managed DRM interfaces.
>> This one addresses memory management. There will be another, final round
>> of patches for converting DRM device structures as well.
>>
>> Patch #1 introduces managed initialization for VRAM MM. Other drivers
>> using the VRAM helpers should be converted to this at some point.
>>
>> Patches #2 to #4 do some preparation that make ast look slightly nicer.
>>
>> Patch #5 fixes a long-standing bug that I found as part of the rework.
>> Posting the GPU requires information about the installed DRAM. So the DRAM
>> detection has to run before the GPU-posting code. This got reversed by a
>> fix in v4.11. The patch restores the original correct order of these
>> operations. As the GPU is usually posted by the VGA BIOS, the problem might
>> not have shown up in practice.
>>
>> With all the cleanups in place, patch #6 switches memory management to
>> mnaged interfaces.
>>
>> Tested on AST2100 HW.
>>
>> v2:
>> * reworked managed VRAM MM; new interface name, returns errno
>>code, improved documentation (Sam)
>>
>> Thomas Zimmermann (6):
>> drm/vram-helper: Managed vram helpers
>> drm/ast: Rename ast_ttm.c to ast_mm.c
>> drm/ast: Use managed VRAM-helper initialization
>> drm/ast: Move VRAM size detection to ast_mm.c
>> drm/ast: Initialize DRAM type before posting GPU
>> drm/ast: Use managed MM initialization
>
> Series looks good now. All patches are:
> Reviewed-by: Sam Ravnborg
Thanks, Sam. I added the patches to drm-misc-next
>
>
> Sam
>>
>> drivers/gpu/drm/ast/Makefile| 2 +-
>> drivers/gpu/drm/ast/ast_drv.h | 2 -
>> drivers/gpu/drm/ast/ast_main.c | 45 ++-
>> drivers/gpu/drm/ast/{ast_ttm.c => ast_mm.c} | 77 ++-
>> drivers/gpu/drm/drm_gem_vram_helper.c | 84 -
>> include/drm/drm_gem_vram_helper.h | 3 +
>> 6 files changed, 115 insertions(+), 98 deletions(-)
>> rename drivers/gpu/drm/ast/{ast_ttm.c => ast_mm.c} (63%)
>>
>> --
>> 2.27.0
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
signature.asc
Description: OpenPGP digital signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 0/6] drm/ast: Managed MM
Hi Thomas.
On Thu, Jul 16, 2020 at 02:53:47PM +0200, Thomas Zimmermann wrote:
> This is the second patchset for converting ast to managed DRM interfaces.
> This one addresses memory management. There will be another, final round
> of patches for converting DRM device structures as well.
>
> Patch #1 introduces managed initialization for VRAM MM. Other drivers
> using the VRAM helpers should be converted to this at some point.
>
> Patches #2 to #4 do some preparation that make ast look slightly nicer.
>
> Patch #5 fixes a long-standing bug that I found as part of the rework.
> Posting the GPU requires information about the installed DRAM. So the DRAM
> detection has to run before the GPU-posting code. This got reversed by a
> fix in v4.11. The patch restores the original correct order of these
> operations. As the GPU is usually posted by the VGA BIOS, the problem might
> not have shown up in practice.
>
> With all the cleanups in place, patch #6 switches memory management to
> mnaged interfaces.
>
> Tested on AST2100 HW.
>
> v2:
> * reworked managed VRAM MM; new interface name, returns errno
> code, improved documentation (Sam)
>
> Thomas Zimmermann (6):
> drm/vram-helper: Managed vram helpers
> drm/ast: Rename ast_ttm.c to ast_mm.c
> drm/ast: Use managed VRAM-helper initialization
> drm/ast: Move VRAM size detection to ast_mm.c
> drm/ast: Initialize DRAM type before posting GPU
> drm/ast: Use managed MM initialization
Series looks good now. All patches are:
Reviewed-by: Sam Ravnborg
Sam
>
> drivers/gpu/drm/ast/Makefile| 2 +-
> drivers/gpu/drm/ast/ast_drv.h | 2 -
> drivers/gpu/drm/ast/ast_main.c | 45 ++-
> drivers/gpu/drm/ast/{ast_ttm.c => ast_mm.c} | 77 ++-
> drivers/gpu/drm/drm_gem_vram_helper.c | 84 -
> include/drm/drm_gem_vram_helper.h | 3 +
> 6 files changed, 115 insertions(+), 98 deletions(-)
> rename drivers/gpu/drm/ast/{ast_ttm.c => ast_mm.c} (63%)
>
> --
> 2.27.0
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v2 0/6] drm/ast: Managed MM
This is the second patchset for converting ast to managed DRM interfaces.
This one addresses memory management. There will be another, final round
of patches for converting DRM device structures as well.
Patch #1 introduces managed initialization for VRAM MM. Other drivers
using the VRAM helpers should be converted to this at some point.
Patches #2 to #4 do some preparation that make ast look slightly nicer.
Patch #5 fixes a long-standing bug that I found as part of the rework.
Posting the GPU requires information about the installed DRAM. So the DRAM
detection has to run before the GPU-posting code. This got reversed by a
fix in v4.11. The patch restores the original correct order of these
operations. As the GPU is usually posted by the VGA BIOS, the problem might
not have shown up in practice.
With all the cleanups in place, patch #6 switches memory management to
mnaged interfaces.
Tested on AST2100 HW.
v2:
* reworked managed VRAM MM; new interface name, returns errno
code, improved documentation (Sam)
Thomas Zimmermann (6):
drm/vram-helper: Managed vram helpers
drm/ast: Rename ast_ttm.c to ast_mm.c
drm/ast: Use managed VRAM-helper initialization
drm/ast: Move VRAM size detection to ast_mm.c
drm/ast: Initialize DRAM type before posting GPU
drm/ast: Use managed MM initialization
drivers/gpu/drm/ast/Makefile| 2 +-
drivers/gpu/drm/ast/ast_drv.h | 2 -
drivers/gpu/drm/ast/ast_main.c | 45 ++-
drivers/gpu/drm/ast/{ast_ttm.c => ast_mm.c} | 77 ++-
drivers/gpu/drm/drm_gem_vram_helper.c | 84 -
include/drm/drm_gem_vram_helper.h | 3 +
6 files changed, 115 insertions(+), 98 deletions(-)
rename drivers/gpu/drm/ast/{ast_ttm.c => ast_mm.c} (63%)
--
2.27.0
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
