[PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder
On 2015ë 08ì 06ì¼ 08:24, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi, > > This patchset is another important step in the exynos clean up, it removes > two exynos internal structs in favor of wider use of struct drm_encoder. > > Structs exynos_drm_display and exynos_drm_encoder were doing exactly what > struct drm_encoder does so remove them makes the code cleaner, easier > to understand and less error prone. > > Please review, > >Gustavo > > --- > v2: - check ret value of hdmi_create_connector() > - set dp->dpms_mode after enable/disable I don't see patch v2 10/11 and 11/11 in my mailbox. Did you miss them? Thanks, Inki Dae > > Gustavo Padovan (11): > drm/exynos: split display's .dpms() into .enable() and .disable() > drm/exynos: remove wrappers for phy_power_{on,off} > drm/exynos: remove unused .remove() and .check_mode() ops from display > drm/exynos: simplify calculation of possible CRTCs > drm/exynos: remove struct exynos_drm_display > drm/exynos: remove extra call to hdmi_commit() > drm/exynos: remove extra call to exynos_dp_commit() > drm/exynos: remove exynos_encoder's .commit() op > drm/exynos: remove exynos_drm_create_enc_conn() > drm/exynos: fold encoder setup into exynos_drm_load() > drm/exynos: remove struct exynos_drm_encoder layer > > drivers/gpu/drm/exynos/Makefile | 7 +- > drivers/gpu/drm/exynos/exynos7_drm_decon.c | 16 +-- > drivers/gpu/drm/exynos/exynos_dp_core.c | 119 ++- > drivers/gpu/drm/exynos/exynos_dp_core.h | 3 +- > drivers/gpu/drm/exynos/exynos_drm_core.c| 36 -- > drivers/gpu/drm/exynos/exynos_drm_crtc.c| 3 +- > drivers/gpu/drm/exynos/exynos_drm_crtc.h| 2 +- > drivers/gpu/drm/exynos/exynos_drm_dpi.c | 96 --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 13 ++- > drivers/gpu/drm/exynos/exynos_drm_drv.h | 65 ++- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 130 ++--- > drivers/gpu/drm/exynos/exynos_drm_encoder.c | 174 > > drivers/gpu/drm/exynos/exynos_drm_encoder.h | 23 > drivers/gpu/drm/exynos/exynos_drm_fimd.c| 17 ++- > drivers/gpu/drm/exynos/exynos_drm_vidi.c| 90 -- > drivers/gpu/drm/exynos/exynos_hdmi.c| 160 - > 16 files changed, 355 insertions(+), 599 deletions(-) > delete mode 100644 drivers/gpu/drm/exynos/exynos_drm_encoder.c > delete mode 100644 drivers/gpu/drm/exynos/exynos_drm_encoder.h >
[PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder
Hi Inki, 2015-08-06 Inki Dae : > On 2015ë 08ì 06ì¼ 08:24, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Hi, > > > > This patchset is another important step in the exynos clean up, it removes > > two exynos internal structs in favor of wider use of struct drm_encoder. > > > > Structs exynos_drm_display and exynos_drm_encoder were doing exactly what > > struct drm_encoder does so remove them makes the code cleaner, easier > > to understand and less error prone. > > > > Please review, > > > >Gustavo > > > > --- > > v2: - check ret value of hdmi_create_connector() > > - set dp->dpms_mode after enable/disable > > I don't see patch v2 10/11 and 11/11 in my mailbox. Did you miss them? Hmm, yeah. I've used 000* to send my patches, which excluded 10 and 11. I'll append them here. Gustavo
[PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder
From: Gustavo PadovanHi, This patchset is another important step in the exynos clean up, it removes two exynos internal structs in favor of wider use of struct drm_encoder. Structs exynos_drm_display and exynos_drm_encoder were doing exactly what struct drm_encoder does so remove them makes the code cleaner, easier to understand and less error prone. Please review, Gustavo --- v2: - check ret value of hdmi_create_connector() - set dp->dpms_mode after enable/disable Gustavo Padovan (11): drm/exynos: split display's .dpms() into .enable() and .disable() drm/exynos: remove wrappers for phy_power_{on,off} drm/exynos: remove unused .remove() and .check_mode() ops from display drm/exynos: simplify calculation of possible CRTCs drm/exynos: remove struct exynos_drm_display drm/exynos: remove extra call to hdmi_commit() drm/exynos: remove extra call to exynos_dp_commit() drm/exynos: remove exynos_encoder's .commit() op drm/exynos: remove exynos_drm_create_enc_conn() drm/exynos: fold encoder setup into exynos_drm_load() drm/exynos: remove struct exynos_drm_encoder layer drivers/gpu/drm/exynos/Makefile | 7 +- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 16 +-- drivers/gpu/drm/exynos/exynos_dp_core.c | 119 ++- drivers/gpu/drm/exynos/exynos_dp_core.h | 3 +- drivers/gpu/drm/exynos/exynos_drm_core.c| 36 -- drivers/gpu/drm/exynos/exynos_drm_crtc.c| 3 +- drivers/gpu/drm/exynos/exynos_drm_crtc.h| 2 +- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 96 --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 13 ++- drivers/gpu/drm/exynos/exynos_drm_drv.h | 65 ++- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 130 ++--- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 174 drivers/gpu/drm/exynos/exynos_drm_encoder.h | 23 drivers/gpu/drm/exynos/exynos_drm_fimd.c| 17 ++- drivers/gpu/drm/exynos/exynos_drm_vidi.c| 90 -- drivers/gpu/drm/exynos/exynos_hdmi.c| 160 - 16 files changed, 355 insertions(+), 599 deletions(-) delete mode 100644 drivers/gpu/drm/exynos/exynos_drm_encoder.c delete mode 100644 drivers/gpu/drm/exynos/exynos_drm_encoder.h -- 2.1.0