[PATCH v2 01/12] drm: panel: Add a new private mode flag: DRM_PANEL_FLAG_PREFER_ONE_SHOT
On 07/01/2015 04:54 PM, Daniel Vetter wrote: > On Wed, Jul 01, 2015 at 04:21:44PM +0800, Mark Zhang wrote: >> Normally this flag is set by panel driver so that crtc can enable >> the "one-shot" mode(not scan frames continuously). >> >> Signed-off-by: Mark Zhang >> --- >> include/drm/drm_panel.h |2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h >> index 13ff44b28893..4d51cb380c75 100644 >> --- a/include/drm/drm_panel.h >> +++ b/include/drm/drm_panel.h >> @@ -26,6 +26,8 @@ >> >> #include >> >> +#define DRM_PANEL_FLAG_PREFER_ONE_SHOT (1 << 0) > > This is a panel property, not a mode property. I think it would be much > better to put this directly into the panel struct, or maybe the dsi sink > device stuff or wherever. But mode really doesn't have anything to do how > exactly the pixels get to the panel. Yeah, we've talked about this in patch set v1. I think putting this in drm_display_mode->private_flags already makes things better. If we want to completely remove this in drm_display_mode, I think we need to create some mechanism which panel can use to notify crtc to enable the one-shot mode, or crtc is able to send out a query, if somebody answers, one-shot will be enabled. Mark > -Daniel >
[PATCH v2 01/12] drm: panel: Add a new private mode flag: DRM_PANEL_FLAG_PREFER_ONE_SHOT
Normally this flag is set by panel driver so that crtc can enable the "one-shot" mode(not scan frames continuously). Signed-off-by: Mark Zhang --- include/drm/drm_panel.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index 13ff44b28893..4d51cb380c75 100644 --- a/include/drm/drm_panel.h +++ b/include/drm/drm_panel.h @@ -26,6 +26,8 @@ #include +#define DRM_PANEL_FLAG_PREFER_ONE_SHOT (1 << 0) + struct drm_connector; struct drm_device; struct drm_panel; -- 1.7.9.5
[PATCH v2 01/12] drm: panel: Add a new private mode flag: DRM_PANEL_FLAG_PREFER_ONE_SHOT
On Wed, Jul 01, 2015 at 04:21:44PM +0800, Mark Zhang wrote: > Normally this flag is set by panel driver so that crtc can enable > the "one-shot" mode(not scan frames continuously). > > Signed-off-by: Mark Zhang > --- > include/drm/drm_panel.h |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > index 13ff44b28893..4d51cb380c75 100644 > --- a/include/drm/drm_panel.h > +++ b/include/drm/drm_panel.h > @@ -26,6 +26,8 @@ > > #include > > +#define DRM_PANEL_FLAG_PREFER_ONE_SHOT (1 << 0) This is a panel property, not a mode property. I think it would be much better to put this directly into the panel struct, or maybe the dsi sink device stuff or wherever. But mode really doesn't have anything to do how exactly the pixels get to the panel. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
