Re: [PATCH v2 02/10] auxdisplay/ht16k33: Remove struct backlight_ops.check_fb

2024-02-21 Thread Andy Shevchenko
On Wed, Feb 21, 2024 at 10:41:29AM +0100, Thomas Zimmermann wrote:
> The driver sets struct fb_info.bl_dev to the correct backlight
> device. Thus rely on the backlight core code to match backlight
> and framebuffer devices, and remove the extra check_fb function
> from struct backlight_ops.

check_fb()

Acked-by: Andy Shevchenko 

-- 
With Best Regards,
Andy Shevchenko




[PATCH v2 02/10] auxdisplay/ht16k33: Remove struct backlight_ops.check_fb

2024-02-21 Thread Thomas Zimmermann
The driver sets struct fb_info.bl_dev to the correct backlight
device. Thus rely on the backlight core code to match backlight
and framebuffer devices, and remove the extra check_fb function
from struct backlight_ops.

Signed-off-by: Thomas Zimmermann 
Cc: Robin van der Gracht 
Acked-by: Robin van der Gracht 
Reviewed-by: Javier Martinez Canillas 
---
 drivers/auxdisplay/ht16k33.c | 8 
 1 file changed, 8 deletions(-)

diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index a90430b7d07ba..0a858db32486b 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -325,16 +325,8 @@ static int ht16k33_bl_update_status(struct 
backlight_device *bl)
return ht16k33_brightness_set(priv, brightness);
 }
 
-static int ht16k33_bl_check_fb(struct backlight_device *bl, struct fb_info *fi)
-{
-   struct ht16k33_priv *priv = bl_get_data(bl);
-
-   return (fi == NULL) || (fi->par == priv);
-}
-
 static const struct backlight_ops ht16k33_bl_ops = {
.update_status  = ht16k33_bl_update_status,
-   .check_fb   = ht16k33_bl_check_fb,
 };
 
 /*
-- 
2.43.0