Re: [PATCH v2 02/36] dt-bindings: display: look for dsi* nodes in dsi-controller
On Thu, Apr 16, 2020 at 6:26 AM Linus Walleij wrote: > > On Wed, Apr 8, 2020 at 9:51 PM Sam Ravnborg wrote: > > > Rob wrote: > > > > Uhhh, it's looking for dsi-controller(@.*)? which is not the common > > case found in dts files. We should fix that to dsi(@.*)?. > > > > See: https://lore.kernel.org/dri-devel/2020031903.GK29911@bogus/ > > > > Fix it. > > > > Signed-off-by: Sam Ravnborg > > Cc: Linus Walleij > > Cc: Rob Herring > > I think I was instructed to use dsi-controller@ at some point but I > suppose it was a misunderstanding. Probably my fault. We've been nice and inconsistent on naming patterns. I always have to double check whether it is 'gpio-controller@' or 'gpio@'... The answer is always whatever has the most hits in dts files. Rob ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 02/36] dt-bindings: display: look for dsi* nodes in dsi-controller
Hi Linus. On Thu, Apr 16, 2020 at 01:26:32PM +0200, Linus Walleij wrote: > On Wed, Apr 8, 2020 at 9:51 PM Sam Ravnborg wrote: > > > Rob wrote: > > > > Uhhh, it's looking for dsi-controller(@.*)? which is not the common > > case found in dts files. We should fix that to dsi(@.*)?. > > > > See: https://lore.kernel.org/dri-devel/2020031903.GK29911@bogus/ > > > > Fix it. > > > > Signed-off-by: Sam Ravnborg > > Cc: Linus Walleij > > Cc: Rob Herring > > I think I was instructed to use dsi-controller@ at some point but I > suppose it was a misunderstanding. > Acked-by: Linus Walleij I have already applied this and most other patches. I tried to post a follow-up on the first mail to tell so, but it was flagged as spam. So this and your other feddback from today did not hit mainline - sorry. But thanks anyway! Sam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 02/36] dt-bindings: display: look for dsi* nodes in dsi-controller
On Wed, Apr 8, 2020 at 9:51 PM Sam Ravnborg wrote: > Rob wrote: > > Uhhh, it's looking for dsi-controller(@.*)? which is not the common > case found in dts files. We should fix that to dsi(@.*)?. > > See: https://lore.kernel.org/dri-devel/2020031903.GK29911@bogus/ > > Fix it. > > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Rob Herring I think I was instructed to use dsi-controller@ at some point but I suppose it was a misunderstanding. Acked-by: Linus Walleij Yours, Linus Walleij ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 02/36] dt-bindings: display: look for dsi* nodes in dsi-controller
On Wed, 8 Apr 2020 21:50:35 +0200, Sam Ravnborg wrote: > Rob wrote: > > Uhhh, it's looking for dsi-controller(@.*)? which is not the common > case found in dts files. We should fix that to dsi(@.*)?. > > See: https://lore.kernel.org/dri-devel/2020031903.GK29911@bogus/ > > Fix it. > > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Rob Herring > --- > Documentation/devicetree/bindings/display/dsi-controller.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v2 02/36] dt-bindings: display: look for dsi* nodes in dsi-controller
Rob wrote:
Uhhh, it's looking for dsi-controller(@.*)? which is not the common
case found in dts files. We should fix that to dsi(@.*)?.
See: https://lore.kernel.org/dri-devel/2020031903.GK29911@bogus/
Fix it.
Signed-off-by: Sam Ravnborg
Cc: Linus Walleij
Cc: Rob Herring
---
Documentation/devicetree/bindings/display/dsi-controller.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/dsi-controller.yaml
b/Documentation/devicetree/bindings/display/dsi-controller.yaml
index fd986c36c737..85b71b1fd28a 100644
--- a/Documentation/devicetree/bindings/display/dsi-controller.yaml
+++ b/Documentation/devicetree/bindings/display/dsi-controller.yaml
@@ -28,7 +28,7 @@ description: |
properties:
$nodename:
-pattern: "^dsi-controller(@.*)?$"
+pattern: "^dsi(@.*)?$"
"#address-cells":
const: 1
@@ -76,7 +76,7 @@ patternProperties:
examples:
- |
#include
-dsi-controller@a0351000 {
+dsi@a0351000 {
reg = <0xa0351000 0x1000>;
#address-cells = <1>;
#size-cells = <0>;
--
2.20.1
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
