Re: [PATCH v2 04/12] iio: buffer-dmaengine: Enable write support

2022-03-28 Thread Jonathan Cameron
On Mon,  7 Feb 2022 12:59:25 +
Paul Cercueil  wrote:

> Use the iio_dma_buffer_write() and iio_dma_buffer_space_available()
> functions provided by the buffer-dma core, to enable write support in
> the buffer-dmaengine code.
> 
> Signed-off-by: Paul Cercueil 
> Reviewed-by: Alexandru Ardelean 
This (and previous) look fine to me. Just that question of a user for
the new functionality...

Jonathan

> ---
>  drivers/iio/buffer/industrialio-buffer-dmaengine.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c 
> b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> index ac26b04aa4a9..5cde8fd81c7f 100644
> --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> @@ -123,12 +123,14 @@ static void iio_dmaengine_buffer_release(struct 
> iio_buffer *buf)
>  
>  static const struct iio_buffer_access_funcs iio_dmaengine_buffer_ops = {
>   .read = iio_dma_buffer_read,
> + .write = iio_dma_buffer_write,
>   .set_bytes_per_datum = iio_dma_buffer_set_bytes_per_datum,
>   .set_length = iio_dma_buffer_set_length,
>   .request_update = iio_dma_buffer_request_update,
>   .enable = iio_dma_buffer_enable,
>   .disable = iio_dma_buffer_disable,
>   .data_available = iio_dma_buffer_data_available,
> + .space_available = iio_dma_buffer_space_available,
>   .release = iio_dmaengine_buffer_release,
>  
>   .modes = INDIO_BUFFER_HARDWARE,



[PATCH v2 04/12] iio: buffer-dmaengine: Enable write support

2022-02-07 Thread Paul Cercueil
Use the iio_dma_buffer_write() and iio_dma_buffer_space_available()
functions provided by the buffer-dma core, to enable write support in
the buffer-dmaengine code.

Signed-off-by: Paul Cercueil 
Reviewed-by: Alexandru Ardelean 
---
 drivers/iio/buffer/industrialio-buffer-dmaengine.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c 
b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
index ac26b04aa4a9..5cde8fd81c7f 100644
--- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
+++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
@@ -123,12 +123,14 @@ static void iio_dmaengine_buffer_release(struct 
iio_buffer *buf)
 
 static const struct iio_buffer_access_funcs iio_dmaengine_buffer_ops = {
.read = iio_dma_buffer_read,
+   .write = iio_dma_buffer_write,
.set_bytes_per_datum = iio_dma_buffer_set_bytes_per_datum,
.set_length = iio_dma_buffer_set_length,
.request_update = iio_dma_buffer_request_update,
.enable = iio_dma_buffer_enable,
.disable = iio_dma_buffer_disable,
.data_available = iio_dma_buffer_data_available,
+   .space_available = iio_dma_buffer_space_available,
.release = iio_dmaengine_buffer_release,
 
.modes = INDIO_BUFFER_HARDWARE,
-- 
2.34.1