Re: [PATCH v2 05/17] drm: Shrink {width,height}_mm to u16

2020-04-07 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 11:39:56PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä 
> 
> Instead of supporting ~2000km wide displayes let's limit ourselves
> to ~65m. That seems plenty big enough to me.
> 
> Even with EDID_QUIRK_DETAILED_IN_CM EDIDs seem to be limited to
> 10*0xfff which fits into the 16 bits.
> 
> Reviewed-by: Emil Velikov 
> Signed-off-by: Ville Syrjälä 
Reviewed-by: Sam Ravnborg 
> ---
>  include/drm/drm_modes.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
> index 8b05f3705d0e..3625e3681488 100644
> --- a/include/drm/drm_modes.h
> +++ b/include/drm/drm_modes.h
> @@ -330,7 +330,7 @@ struct drm_display_mode {
>* Addressable size of the output in mm, projectors should set this to
>* 0.
>*/
> - int width_mm;
> + u16 width_mm;
>  
>   /**
>* @height_mm:
> @@ -338,7 +338,7 @@ struct drm_display_mode {
>* Addressable size of the output in mm, projectors should set this to
>* 0.
>*/
> - int height_mm;
> + u16 height_mm;
>  
>   /**
>* @crtc_clock:
> -- 
> 2.24.1
> 
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH v2 05/17] drm: Shrink {width,height}_mm to u16

2020-04-03 Thread Ville Syrjala
From: Ville Syrjälä 

Instead of supporting ~2000km wide displayes let's limit ourselves
to ~65m. That seems plenty big enough to me.

Even with EDID_QUIRK_DETAILED_IN_CM EDIDs seem to be limited to
10*0xfff which fits into the 16 bits.

Reviewed-by: Emil Velikov 
Signed-off-by: Ville Syrjälä 
---
 include/drm/drm_modes.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
index 8b05f3705d0e..3625e3681488 100644
--- a/include/drm/drm_modes.h
+++ b/include/drm/drm_modes.h
@@ -330,7 +330,7 @@ struct drm_display_mode {
 * Addressable size of the output in mm, projectors should set this to
 * 0.
 */
-   int width_mm;
+   u16 width_mm;
 
/**
 * @height_mm:
@@ -338,7 +338,7 @@ struct drm_display_mode {
 * Addressable size of the output in mm, projectors should set this to
 * 0.
 */
-   int height_mm;
+   u16 height_mm;
 
/**
 * @crtc_clock:
-- 
2.24.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel