Re: [PATCH v2 06/11] PCI/VGA: Fix two typos in the comments of pci_notify()

[suijingfeng]

Hi,


On 2023/8/9 22:12, Ilpo Järvinen wrote:

On Wed, 9 Aug 2023, Sui Jingfeng wrote:


From: Sui Jingfeng 

1) s/intereted/interested
2) s/hotplugable/hot-pluggable

While at it, convert the comments to the conventional multi-line style,
and rewrap to fill 78 columns.

Fixes: deb2d2ecd43d ("PCI/GPU: implement VGA arbitration on Linux")
Signed-off-by: Sui Jingfeng 
---
  drivers/pci/vgaarb.c | 8 +---
  1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
index 6883067a802a..811510253553 100644
--- a/drivers/pci/vgaarb.c
+++ b/drivers/pci/vgaarb.c
@@ -1535,9 +1535,11 @@ static int pci_notify(struct notifier_block *nb, 
unsigned long action,
if (!pci_dev_is_vga(pdev))
return 0;
  
-	/* For now we're only intereted in devices added and removed. I didn't

-* test this thing here, so someone needs to double check for the
-* cases of hotplugable vga cards. */
+   /*
+* For now, we're only interested in devices added and removed.
+* I didn't test this thing here, so someone needs to double check
+* for the cases of hot-pluggable VGA cards.
+*/
if (action == BUS_NOTIFY_ADD_DEVICE)
notify = vga_arbiter_add_pci_device(pdev);
else if (action == BUS_NOTIFY_DEL_DEVICE)

Don't use Fixes tag for comment changes. After removing it, feel free to
add:



OK, I will remove the Fixes tag for comment changes at next version.
Thanks a lot. Also for other patches in this series.



Reviewed-by: Ilpo Järvinen 

Re: [PATCH v2 06/11] PCI/VGA: Fix two typos in the comments of pci_notify()

[Ilpo Järvinen]

On Wed, 9 Aug 2023, Sui Jingfeng wrote:

> From: Sui Jingfeng 
> 
> 1) s/intereted/interested
> 2) s/hotplugable/hot-pluggable
> 
> While at it, convert the comments to the conventional multi-line style,
> and rewrap to fill 78 columns.
> 
> Fixes: deb2d2ecd43d ("PCI/GPU: implement VGA arbitration on Linux")
> Signed-off-by: Sui Jingfeng 
> ---
>  drivers/pci/vgaarb.c | 8 +---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
> index 6883067a802a..811510253553 100644
> --- a/drivers/pci/vgaarb.c
> +++ b/drivers/pci/vgaarb.c
> @@ -1535,9 +1535,11 @@ static int pci_notify(struct notifier_block *nb, 
> unsigned long action,
>   if (!pci_dev_is_vga(pdev))
>   return 0;
>  
> - /* For now we're only intereted in devices added and removed. I didn't
> -  * test this thing here, so someone needs to double check for the
> -  * cases of hotplugable vga cards. */
> + /*
> +  * For now, we're only interested in devices added and removed.
> +  * I didn't test this thing here, so someone needs to double check
> +  * for the cases of hot-pluggable VGA cards.
> +  */
>   if (action == BUS_NOTIFY_ADD_DEVICE)
>   notify = vga_arbiter_add_pci_device(pdev);
>   else if (action == BUS_NOTIFY_DEL_DEVICE)

Don't use Fixes tag for comment changes. After removing it, feel free to 
add:

Reviewed-by: Ilpo Järvinen 


-- 
 i.

[PATCH v2 06/11] PCI/VGA: Fix two typos in the comments of pci_notify()

[Sui Jingfeng]

From: Sui Jingfeng 

1) s/intereted/interested
2) s/hotplugable/hot-pluggable

While at it, convert the comments to the conventional multi-line style,
and rewrap to fill 78 columns.

Fixes: deb2d2ecd43d ("PCI/GPU: implement VGA arbitration on Linux")
Signed-off-by: Sui Jingfeng 
---
 drivers/pci/vgaarb.c | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
index 6883067a802a..811510253553 100644
--- a/drivers/pci/vgaarb.c
+++ b/drivers/pci/vgaarb.c
@@ -1535,9 +1535,11 @@ static int pci_notify(struct notifier_block *nb, 
unsigned long action,
if (!pci_dev_is_vga(pdev))
return 0;
 
-   /* For now we're only intereted in devices added and removed. I didn't
-* test this thing here, so someone needs to double check for the
-* cases of hotplugable vga cards. */
+   /*
+* For now, we're only interested in devices added and removed.
+* I didn't test this thing here, so someone needs to double check
+* for the cases of hot-pluggable VGA cards.
+*/
if (action == BUS_NOTIFY_ADD_DEVICE)
notify = vga_arbiter_add_pci_device(pdev);
else if (action == BUS_NOTIFY_DEL_DEVICE)
-- 
2.34.1