Re: [PATCH v2 1/2] dt-bindings: one binding file for all simple panels
Hi Jyri, Rob, Paul, Miquel.
Following patch is now applied to drm-misc-next.
Please add your simple panels to this file so
we avoid independent bindings files for ecah panel.
I will handle the inevitable conflicts when I apply.
Sam
On Thu, Jan 02, 2020 at 11:17:11AM +0100, Sam Ravnborg wrote:
> There is an increasing number of new simple panels.
> Common for many of these simple panels are that they have one
> mandatory power-supply and some of them have backlight and / or
> an enable gpio.
>
> The binding file to describe these panels adds overhead
> that really do not add value.
> The binding are known and there is nothing gained from a
> dedicated binding file nor for any dedicated example.
>
> The following patch introduces a single panel-simple.yaml
> and converts two ampire bindings over to the new file.
>
> The conversion - if applied will have following effects:
>
> - The maintainer for the individual file will change
> There is no need for many different maintainers for a simple binding.
> We have the same situation with the panel-simple driver in the kernel.
>
> - The license will change to (GPL-2.0-only OR BSD-2-Clause)
> There is usually only a single line copied from the original
> file, a line that is often copied from a datasheet.
> This license change should be acceptable considered what little
> is copied.
> If the license change is not OK we can use a dedicated binding
> file in these cases.
>
> This is a follow-up on Rob's big patch converting a lot of panel bindings
> to individual files:
>
> "dt-bindings: display: Convert a bunch of panels to DT schema"
> https://patchwork.ozlabs.org/patch/1197683/
>
> The objectives with one file for the relevant simple panels are:
> - Make it simpler to add bindings for simple panels
> - Keep the number of bindings file lower and thus easier to find a
> relevant file to copy from when adding new panels.
> - Keep the binding documentation for simple panels more consistent
> - Make it simpler to add support for new panels
>
> v2:
> - spelling fixes (imirkin via irc, Rob)
> - updated description (Rob)
> - list properires in alphabetical order
> - added power-supply to example (Rob)
> - updated title
> - reworded changelog a little
>
> Signed-off-by: Sam Ravnborg
> Cc: Thierry Reding
> Cc: Rob Herring
> Cc: Maxime Ripard
> Cc: Yannick Fertre
> Cc: Mark Rutland
> Cc: Daniel Vetter
> Cc: dri-devel@lists.freedesktop.org
> Cc: devicet...@vger.kernel.org
> ---
> .../panel/ampire,am-480272h3tmqw-t01h.yaml| 42 -
> .../panel/ampire,am800480r3tmqwa1h.txt| 7 ---
> .../bindings/display/panel/panel-simple.yaml | 59 +++
> 3 files changed, 59 insertions(+), 49 deletions(-)
> delete mode 100644
> Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
> delete mode 100644
> Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
> create mode 100644
> Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
>
> b/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
> deleted file mode 100644
> index c6e33e7f36d0..
> ---
> a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0
> -%YAML 1.2
>
> -$id:
> http://devicetree.org/schemas/display/panel/ampire,am-480272h3tmqw-t01h.yaml#
> -$schema: http://devicetree.org/meta-schemas/core.yaml#
> -
> -title: Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
> -
> -maintainers:
> - - Yannick Fertre
> - - Thierry Reding
> -
> -allOf:
> - - $ref: panel-common.yaml#
> -
> -properties:
> - compatible:
> -const: ampire,am-480272h3tmqw-t01h
> -
> - power-supply: true
> - enable-gpios: true
> - backlight: true
> - port: true
> -
> -required:
> - - compatible
> -
> -additionalProperties: false
> -
> -examples:
> - - |
> -panel_rgb: panel {
> - compatible = "ampire,am-480272h3tmqw-t01h";
> - enable-gpios = <&gpioa 8 1>;
> - port {
> -panel_in_rgb: endpoint {
> - remote-endpoint = <&controller_out_rgb>;
> -};
> - };
> -};
> -
> -...
> diff --git
> a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
>
> b/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
> deleted file mode 100644
> index 83e2cae1cc1b..
> ---
> a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "ampire,am800480r3tmqwa1h"
> -
> -This binding is compatible with the simple-panel binding, which is specified
> -in simple-panel.txt in this direct
Re: [PATCH v2 1/2] dt-bindings: one binding file for all simple panels
Hi Benjamin. > > + > > +required: > > + - compatible > > + - power-supply > > Hi Sam, > > power-supply property should be optional like it was in > ampire,am-480272h3tmqw-t01h.yaml > else it looks good for me. power-supply was discussed in PATRCH 2/2 and the conclusion was that power-supply is required. Thus I take this as an Acked-by: And I have committed to drm-misc-next Sam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 1/2] dt-bindings: one binding file for all simple panels
On Thu, Jan 2, 2020 at 4:17 AM Sam Ravnborg wrote: > > There is an increasing number of new simple panels. > Common for many of these simple panels are that they have one > mandatory power-supply and some of them have backlight and / or > an enable gpio. > > The binding file to describe these panels adds overhead > that really do not add value. > The binding are known and there is nothing gained from a > dedicated binding file nor for any dedicated example. > > The following patch introduces a single panel-simple.yaml > and converts two ampire bindings over to the new file. > > The conversion - if applied will have following effects: > > - The maintainer for the individual file will change > There is no need for many different maintainers for a simple binding. > We have the same situation with the panel-simple driver in the kernel. > > - The license will change to (GPL-2.0-only OR BSD-2-Clause) > There is usually only a single line copied from the original > file, a line that is often copied from a datasheet. > This license change should be acceptable considered what little > is copied. > If the license change is not OK we can use a dedicated binding > file in these cases. > > This is a follow-up on Rob's big patch converting a lot of panel bindings > to individual files: > > "dt-bindings: display: Convert a bunch of panels to DT schema" > https://patchwork.ozlabs.org/patch/1197683/ > > The objectives with one file for the relevant simple panels are: > - Make it simpler to add bindings for simple panels > - Keep the number of bindings file lower and thus easier to find a > relevant file to copy from when adding new panels. > - Keep the binding documentation for simple panels more consistent > - Make it simpler to add support for new panels > > v2: > - spelling fixes (imirkin via irc, Rob) > - updated description (Rob) > - list properires in alphabetical order > - added power-supply to example (Rob) > - updated title > - reworded changelog a little > > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Rob Herring > Cc: Maxime Ripard > Cc: Yannick Fertre > Cc: Mark Rutland > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org > Cc: devicet...@vger.kernel.org > --- > .../panel/ampire,am-480272h3tmqw-t01h.yaml| 42 - > .../panel/ampire,am800480r3tmqwa1h.txt| 7 --- > .../bindings/display/panel/panel-simple.yaml | 59 +++ > 3 files changed, 59 insertions(+), 49 deletions(-) > delete mode 100644 > Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml > delete mode 100644 > Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt > create mode 100644 > Documentation/devicetree/bindings/display/panel/panel-simple.yaml Reviewed-by: Rob Herring ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 1/2] dt-bindings: one binding file for all simple panels
Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg a écrit :
>
> There is an increasing number of new simple panels.
> Common for many of these simple panels are that they have one
> mandatory power-supply and some of them have backlight and / or
> an enable gpio.
>
> The binding file to describe these panels adds overhead
> that really do not add value.
> The binding are known and there is nothing gained from a
> dedicated binding file nor for any dedicated example.
>
> The following patch introduces a single panel-simple.yaml
> and converts two ampire bindings over to the new file.
>
> The conversion - if applied will have following effects:
>
> - The maintainer for the individual file will change
> There is no need for many different maintainers for a simple binding.
> We have the same situation with the panel-simple driver in the kernel.
>
> - The license will change to (GPL-2.0-only OR BSD-2-Clause)
> There is usually only a single line copied from the original
> file, a line that is often copied from a datasheet.
> This license change should be acceptable considered what little
> is copied.
> If the license change is not OK we can use a dedicated binding
> file in these cases.
>
> This is a follow-up on Rob's big patch converting a lot of panel bindings
> to individual files:
>
> "dt-bindings: display: Convert a bunch of panels to DT schema"
> https://patchwork.ozlabs.org/patch/1197683/
>
> The objectives with one file for the relevant simple panels are:
> - Make it simpler to add bindings for simple panels
> - Keep the number of bindings file lower and thus easier to find a
> relevant file to copy from when adding new panels.
> - Keep the binding documentation for simple panels more consistent
> - Make it simpler to add support for new panels
>
> v2:
> - spelling fixes (imirkin via irc, Rob)
> - updated description (Rob)
> - list properires in alphabetical order
> - added power-supply to example (Rob)
> - updated title
> - reworded changelog a little
>
> Signed-off-by: Sam Ravnborg
> Cc: Thierry Reding
> Cc: Rob Herring
> Cc: Maxime Ripard
> Cc: Yannick Fertre
> Cc: Mark Rutland
> Cc: Daniel Vetter
> Cc: dri-devel@lists.freedesktop.org
> Cc: devicet...@vger.kernel.org
> ---
> .../panel/ampire,am-480272h3tmqw-t01h.yaml| 42 -
> .../panel/ampire,am800480r3tmqwa1h.txt| 7 ---
> .../bindings/display/panel/panel-simple.yaml | 59 +++
> 3 files changed, 59 insertions(+), 49 deletions(-)
> delete mode 100644
> Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
> delete mode 100644
> Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
> create mode 100644
> Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
>
> b/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
> deleted file mode 100644
> index c6e33e7f36d0..
> ---
> a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0
> -%YAML 1.2
>
> -$id:
> http://devicetree.org/schemas/display/panel/ampire,am-480272h3tmqw-t01h.yaml#
> -$schema: http://devicetree.org/meta-schemas/core.yaml#
> -
> -title: Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
> -
> -maintainers:
> - - Yannick Fertre
> - - Thierry Reding
> -
> -allOf:
> - - $ref: panel-common.yaml#
> -
> -properties:
> - compatible:
> -const: ampire,am-480272h3tmqw-t01h
> -
> - power-supply: true
> - enable-gpios: true
> - backlight: true
> - port: true
> -
> -required:
> - - compatible
> -
> -additionalProperties: false
> -
> -examples:
> - - |
> -panel_rgb: panel {
> - compatible = "ampire,am-480272h3tmqw-t01h";
> - enable-gpios = <&gpioa 8 1>;
> - port {
> -panel_in_rgb: endpoint {
> - remote-endpoint = <&controller_out_rgb>;
> -};
> - };
> -};
> -
> -...
> diff --git
> a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
>
> b/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
> deleted file mode 100644
> index 83e2cae1cc1b..
> ---
> a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "ampire,am800480r3tmqwa1h"
> -
> -This binding is compatible with the simple-panel binding, which is specified
> -in simple-panel.txt in this directory.
> diff --git
> a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> new file mode 100644
> index ..51ca50201182
> --- /dev/null
> +++ b/Documentation/devicet
[PATCH v2 1/2] dt-bindings: one binding file for all simple panels
There is an increasing number of new simple panels.
Common for many of these simple panels are that they have one
mandatory power-supply and some of them have backlight and / or
an enable gpio.
The binding file to describe these panels adds overhead
that really do not add value.
The binding are known and there is nothing gained from a
dedicated binding file nor for any dedicated example.
The following patch introduces a single panel-simple.yaml
and converts two ampire bindings over to the new file.
The conversion - if applied will have following effects:
- The maintainer for the individual file will change
There is no need for many different maintainers for a simple binding.
We have the same situation with the panel-simple driver in the kernel.
- The license will change to (GPL-2.0-only OR BSD-2-Clause)
There is usually only a single line copied from the original
file, a line that is often copied from a datasheet.
This license change should be acceptable considered what little
is copied.
If the license change is not OK we can use a dedicated binding
file in these cases.
This is a follow-up on Rob's big patch converting a lot of panel bindings
to individual files:
"dt-bindings: display: Convert a bunch of panels to DT schema"
https://patchwork.ozlabs.org/patch/1197683/
The objectives with one file for the relevant simple panels are:
- Make it simpler to add bindings for simple panels
- Keep the number of bindings file lower and thus easier to find a
relevant file to copy from when adding new panels.
- Keep the binding documentation for simple panels more consistent
- Make it simpler to add support for new panels
v2:
- spelling fixes (imirkin via irc, Rob)
- updated description (Rob)
- list properires in alphabetical order
- added power-supply to example (Rob)
- updated title
- reworded changelog a little
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: Rob Herring
Cc: Maxime Ripard
Cc: Yannick Fertre
Cc: Mark Rutland
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
Cc: devicet...@vger.kernel.org
---
.../panel/ampire,am-480272h3tmqw-t01h.yaml| 42 -
.../panel/ampire,am800480r3tmqwa1h.txt| 7 ---
.../bindings/display/panel/panel-simple.yaml | 59 +++
3 files changed, 59 insertions(+), 49 deletions(-)
delete mode 100644
Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
delete mode 100644
Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
create mode 100644
Documentation/devicetree/bindings/display/panel/panel-simple.yaml
diff --git
a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
b/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
deleted file mode 100644
index c6e33e7f36d0..
---
a/Documentation/devicetree/bindings/display/panel/ampire,am-480272h3tmqw-t01h.yaml
+++ /dev/null
@@ -1,42 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-%YAML 1.2
-$id:
http://devicetree.org/schemas/display/panel/ampire,am-480272h3tmqw-t01h.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
-
-maintainers:
- - Yannick Fertre
- - Thierry Reding
-
-allOf:
- - $ref: panel-common.yaml#
-
-properties:
- compatible:
-const: ampire,am-480272h3tmqw-t01h
-
- power-supply: true
- enable-gpios: true
- backlight: true
- port: true
-
-required:
- - compatible
-
-additionalProperties: false
-
-examples:
- - |
-panel_rgb: panel {
- compatible = "ampire,am-480272h3tmqw-t01h";
- enable-gpios = <&gpioa 8 1>;
- port {
-panel_in_rgb: endpoint {
- remote-endpoint = <&controller_out_rgb>;
-};
- };
-};
-
-...
diff --git
a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
b/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
deleted file mode 100644
index 83e2cae1cc1b..
---
a/Documentation/devicetree/bindings/display/panel/ampire,am800480r3tmqwa1h.txt
+++ /dev/null
@@ -1,7 +0,0 @@
-Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel
-
-Required properties:
-- compatible: should be "ampire,am800480r3tmqwa1h"
-
-This binding is compatible with the simple-panel binding, which is specified
-in simple-panel.txt in this directory.
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
new file mode 100644
index ..51ca50201182
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/panel-simple.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Simple panels with one power supply
+
+maintainers:
+ - Thierry Re
