Re: [PATCH v2 27/91] dt-bindings: display: Convert VC4 bindings to schemas

2020-04-27 Thread Rob Herring
On Fri, 24 Apr 2020 17:34:08 +0200, Maxime Ripard wrote:
> The BCM283x SoCs have a display pipeline composed of several controllers
> with device tree bindings that are supported by Linux.
> 
> Now that we have the DT validation in place, let's split into separate
> files and convert the device tree bindings for those controllers to
> schemas.
> 
> This is just a 1:1 conversion though, and some bindings were incomplete so
> it results in example validation warnings that are going to be addressed in
> the following patches.
> 
> Cc: Rob Herring 
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Maxime Ripard 
> ---
>  Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt  | 
> 174 +
>  Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml |  
> 66 +++-
>  Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml|  
> 73 ++-
>  Documentation/devicetree/bindings/display/brcm,bcm2835-hdmi.yaml|  
> 75 +++-
>  Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml |  
> 37 +++-
>  Documentation/devicetree/bindings/display/brcm,bcm2835-pixelvalve0.yaml |  
> 40 +-
>  Documentation/devicetree/bindings/display/brcm,bcm2835-txp.yaml |  
> 37 +++-
>  Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml |  
> 42 +-
>  Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml |  
> 34 ++-
>  Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml |  
> 44 ++-
>  MAINTAINERS |   
> 2 +-
>  11 files changed, 449 insertions(+), 175 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt
>  create mode 100644 
> Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/brcm,bcm2835-hdmi.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/brcm,bcm2835-pixelvalve0.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/brcm,bcm2835-txp.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml:
 properties: '#clock-cells' is a dependency of 'clock-output-names'
Documentation/devicetree/bindings/Makefile:11: recipe for target 
'Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.example.dts' failed
make[1]: *** 
[Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.example.dts] Error 
1
make[1]: *** Waiting for unfinished jobs
Makefile:1300: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1276439

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master 
--upgrade

Please check and re-submit.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH v2 27/91] dt-bindings: display: Convert VC4 bindings to schemas

2020-04-24 Thread Maxime Ripard
The BCM283x SoCs have a display pipeline composed of several controllers
with device tree bindings that are supported by Linux.

Now that we have the DT validation in place, let's split into separate
files and convert the device tree bindings for those controllers to
schemas.

This is just a 1:1 conversion though, and some bindings were incomplete so
it results in example validation warnings that are going to be addressed in
the following patches.

Cc: Rob Herring 
Cc: devicet...@vger.kernel.org
Signed-off-by: Maxime Ripard 
---
 Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt  | 174 
+
 Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml |  66 
+++-
 Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml|  73 
++-
 Documentation/devicetree/bindings/display/brcm,bcm2835-hdmi.yaml|  75 
+++-
 Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml |  37 
+++-
 Documentation/devicetree/bindings/display/brcm,bcm2835-pixelvalve0.yaml |  40 
+-
 Documentation/devicetree/bindings/display/brcm,bcm2835-txp.yaml |  37 
+++-
 Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml |  42 
+-
 Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml |  34 
++-
 Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml |  44 
++-
 MAINTAINERS |   2 
+-
 11 files changed, 449 insertions(+), 175 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt
 create mode 100644 
Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/brcm,bcm2835-dsi0.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/brcm,bcm2835-hdmi.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/brcm,bcm2835-pixelvalve0.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/brcm,bcm2835-txp.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/brcm,bcm2835-v3d.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/brcm,bcm2835-vec.yaml

diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt 
b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt
deleted file mode 100644
index 26649b4c4dd8..
--- a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt
+++ /dev/null
@@ -1,174 +0,0 @@
-Broadcom VC4 (VideoCore4) GPU
-
-The VC4 device present on the Raspberry Pi includes a display system
-with HDMI output and the HVS (Hardware Video Scaler) for compositing
-display planes.
-
-Required properties for VC4:
-- compatible:  Should be "brcm,bcm2835-vc4" or "brcm,cygnus-vc4"
-
-Required properties for Pixel Valve:
-- compatible:  Should be one of "brcm,bcm2835-pixelvalve0",
- "brcm,bcm2835-pixelvalve1", or "brcm,bcm2835-pixelvalve2"
-- reg: Physical base address and length of the PV's registers
-- interrupts:  The interrupt number
- See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
-
-Required properties for HVS:
-- compatible:  Should be "brcm,bcm2835-hvs"
-- reg: Physical base address and length of the HVS's registers
-- interrupts:  The interrupt number
- See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
-
-Required properties for HDMI
-- compatible:  Should be "brcm,bcm2835-hdmi"
-- reg: Physical base address and length of the two register ranges
- ("HDMI" and "HD", in that order)
-- interrupts:  The interrupt numbers
- See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
-- ddc: phandle of the I2C controller used for DDC EDID probing
-- clocks:  a) hdmi: The HDMI state machine clock
-   b) pixel: The pixel clock.
-
-Optional properties for HDMI:
-- hpd-gpios:   The GPIO pin for HDMI hotplug detect (if it doesn't appear
- as an interrupt/status bit in the HDMI controller
- itself).  See bindings/pinctrl/brcm,bcm2835-gpio.txt
-- dmas:Should contain one entry pointing to the DMA channel 
used to
-   transfer audio data
-- dma-names:   Should contain "audio-rx"
-
-Required properties for DPI:
-- compatible:  Should be "brcm,bcm2835-dpi"
-- reg: Physical base address and length of the registers
-- clocks:  a) core: The core clock the unit runs on
-   b) pixel: The pixel clock that feeds the pixelvalve
-- port: