Re: [PATCH v2 3/5] drm/solomon: Add ssd130x new compatible strings and deprecate old ones.
On 4/12/22 09:19, Geert Uytterhoeven wrote: > Hi Javier, > > On Mon, Apr 11, 2022 at 11:12 PM Javier Martinez Canillas > wrote: >> The current compatible strings for SSD130x I2C controllers contain an "fb" >> and "-i2c" suffixes. These have been deprecated and more correct ones were >> added, that don't encode a subsystem or bus used to interface the devices. >> >> Signed-off-by: Javier Martinez Canillas >> Acked-by: Mark Brown >> --- >> >> (no changes since v1) > > That's not really true ;-) > Ups, I did indeed update the compatible strings to drop the "-i2c" as you asked. I'll add that in the patch history for v2 when posting v3. > Reviewed-by: Geert Uytterhoeven > Thanks! -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
Re: [PATCH v2 3/5] drm/solomon: Add ssd130x new compatible strings and deprecate old ones.
Hi Javier,
On Mon, Apr 11, 2022 at 11:12 PM Javier Martinez Canillas
wrote:
> The current compatible strings for SSD130x I2C controllers contain an "fb"
> and "-i2c" suffixes. These have been deprecated and more correct ones were
> added, that don't encode a subsystem or bus used to interface the devices.
>
> Signed-off-by: Javier Martinez Canillas
> Acked-by: Mark Brown
> ---
>
> (no changes since v1)
That's not really true ;-)
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[PATCH v2 3/5] drm/solomon: Add ssd130x new compatible strings and deprecate old ones.
The current compatible strings for SSD130x I2C controllers contain an "fb"
and "-i2c" suffixes. These have been deprecated and more correct ones were
added, that don't encode a subsystem or bus used to interface the devices.
Signed-off-by: Javier Martinez Canillas
Acked-by: Mark Brown
---
(no changes since v1)
drivers/gpu/drm/solomon/ssd130x-i2c.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/solomon/ssd130x-i2c.c
b/drivers/gpu/drm/solomon/ssd130x-i2c.c
index d099b241dd3f..87abe1fe31fc 100644
--- a/drivers/gpu/drm/solomon/ssd130x-i2c.c
+++ b/drivers/gpu/drm/solomon/ssd130x-i2c.c
@@ -87,6 +87,27 @@ static struct ssd130x_deviceinfo ssd130x_ssd1309_deviceinfo
= {
};
static const struct of_device_id ssd130x_of_match[] = {
+ {
+ .compatible = "sinowealth,sh1106",
+ .data = _sh1106_deviceinfo,
+ },
+ {
+ .compatible = "solomon,ssd1305",
+ .data = _ssd1305_deviceinfo,
+ },
+ {
+ .compatible = "solomon,ssd1306",
+ .data = _ssd1306_deviceinfo,
+ },
+ {
+ .compatible = "solomon,ssd1307",
+ .data = _ssd1307_deviceinfo,
+ },
+ {
+ .compatible = "solomon,ssd1309",
+ .data = _ssd1309_deviceinfo,
+ },
+ /* Deprecated but kept for backward compatibility */
{
.compatible = "sinowealth,sh1106-i2c",
.data = _sh1106_deviceinfo,
--
2.35.1
