Re: [PATCH v2 31/60] drm/omap: dss: Move and rename omap_dss_(get|put)_device()

2018-06-10 Thread Sebastian Reichel 
Hi,

On Sat, May 26, 2018 at 08:24:49PM +0300, Laurent Pinchart wrote:
> The functions operate on any omap_dss_device, move them from display.c
> to base.c. While at it rename them to match the naming of the other
> functions operating on struct omap_dss_device.
> 
> Signed-off-by: Laurent Pinchart 
> ---

Reviewed-by: Sebastian Reichel 

-- Sebastian

>  .../gpu/drm/omapdrm/displays/connector-analog-tv.c |  4 ++--
>  drivers/gpu/drm/omapdrm/displays/connector-dvi.c   |  4 ++--
>  drivers/gpu/drm/omapdrm/displays/connector-hdmi.c  |  4 ++--
>  drivers/gpu/drm/omapdrm/displays/encoder-opa362.c  |  4 ++--
>  drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c  |  4 ++--
>  .../gpu/drm/omapdrm/displays/encoder-tpd12s015.c   |  4 ++--
>  drivers/gpu/drm/omapdrm/displays/panel-dpi.c   |  4 ++--
>  drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c|  4 ++--
>  .../omapdrm/displays/panel-lgphilips-lb035q02.c|  4 ++--
>  .../drm/omapdrm/displays/panel-nec-nl8048hl11.c|  4 ++--
>  .../drm/omapdrm/displays/panel-sharp-ls037v7dw01.c |  4 ++--
>  .../drm/omapdrm/displays/panel-sony-acx565akm.c|  4 ++--
>  .../drm/omapdrm/displays/panel-tpo-td028ttec1.c|  4 ++--
>  .../drm/omapdrm/displays/panel-tpo-td043mtea1.c|  4 ++--
>  drivers/gpu/drm/omapdrm/dss/base.c | 27 
> +++---
>  drivers/gpu/drm/omapdrm/dss/display.c  | 24 ---
>  drivers/gpu/drm/omapdrm/dss/omapdss.h  |  5 ++--
>  drivers/gpu/drm/omapdrm/dss/output.c   |  2 +-
>  drivers/gpu/drm/omapdrm/omap_connector.c   |  4 ++--
>  drivers/gpu/drm/omapdrm/omap_crtc.c|  2 +-
>  drivers/gpu/drm/omapdrm/omap_drv.c |  8 +++
>  21 files changed, 62 insertions(+), 66 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c 
> b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
> index f1d1c67d72b8..a7eb25bd9283 100644
> --- a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
> +++ b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
> @@ -55,7 +55,7 @@ static int tvc_connect(struct omap_dss_device *dssdev)
>  
>   r = omapdss_device_connect(src, dssdev);
>   if (r) {
> - omap_dss_put_device(src);
> + omapdss_device_put(src);
>   return r;
>   }
>  
> @@ -68,7 +68,7 @@ static void tvc_disconnect(struct omap_dss_device *dssdev)
>  
>   omapdss_device_disconnect(src, dssdev);
>  
> - omap_dss_put_device(src);
> + omapdss_device_put(src);
>  }
>  
>  static int tvc_enable(struct omap_dss_device *dssdev)
> diff --git a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c 
> b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
> index 9e0b5a0b2eea..3e71af9ba0c3 100644
> --- a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
> @@ -69,7 +69,7 @@ static int dvic_connect(struct omap_dss_device *dssdev)
>  
>   r = omapdss_device_connect(src, dssdev);
>   if (r) {
> - omap_dss_put_device(src);
> + omapdss_device_put(src);
>   return r;
>   }
>  
> @@ -82,7 +82,7 @@ static void dvic_disconnect(struct omap_dss_device *dssdev)
>  
>   omapdss_device_disconnect(src, dssdev);
>  
> - omap_dss_put_device(src);
> + omapdss_device_put(src);
>  }
>  
>  static int dvic_enable(struct omap_dss_device *dssdev)
> diff --git a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c 
> b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> index 064b051c0a29..fd0bad4dc7c9 100644
> --- a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> @@ -65,7 +65,7 @@ static int hdmic_connect(struct omap_dss_device *dssdev)
>  
>   r = omapdss_device_connect(src, dssdev);
>   if (r) {
> - omap_dss_put_device(src);
> + omapdss_device_put(src);
>   return r;
>   }
>  
> @@ -78,7 +78,7 @@ static void hdmic_disconnect(struct omap_dss_device *dssdev)
>  
>   omapdss_device_disconnect(src, dssdev);
>  
> - omap_dss_put_device(src);
> + omapdss_device_put(src);
>  }
>  
>  static int hdmic_enable(struct omap_dss_device *dssdev)
> diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c 
> b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> index c1ed4e2ce8f3..01b00eea3a98 100644
> --- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> +++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> @@ -45,7 +45,7 @@ static int opa362_connect(struct omap_dss_device *dssdev,
>  
>   r = omapdss_device_connect(src, dssdev);
>   if (r) {
> - omap_dss_put_device(src);
> + omapdss_device_put(src);
>   return r;
>   }
>  
> @@ -60,7 +60,7 @@ static void opa362_disconnect(struct omap_dss_device 
> *dssdev,
>  
>   omapdss_device_disconnect(src, >dssdev);
>  
> - omap_dss_put_device(src);
> +

[PATCH v2 31/60] drm/omap: dss: Move and rename omap_dss_(get|put)_device()

2018-05-26 Thread Laurent Pinchart 
The functions operate on any omap_dss_device, move them from display.c
to base.c. While at it rename them to match the naming of the other
functions operating on struct omap_dss_device.

Signed-off-by: Laurent Pinchart 
---
 .../gpu/drm/omapdrm/displays/connector-analog-tv.c |  4 ++--
 drivers/gpu/drm/omapdrm/displays/connector-dvi.c   |  4 ++--
 drivers/gpu/drm/omapdrm/displays/connector-hdmi.c  |  4 ++--
 drivers/gpu/drm/omapdrm/displays/encoder-opa362.c  |  4 ++--
 drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c  |  4 ++--
 .../gpu/drm/omapdrm/displays/encoder-tpd12s015.c   |  4 ++--
 drivers/gpu/drm/omapdrm/displays/panel-dpi.c   |  4 ++--
 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c|  4 ++--
 .../omapdrm/displays/panel-lgphilips-lb035q02.c|  4 ++--
 .../drm/omapdrm/displays/panel-nec-nl8048hl11.c|  4 ++--
 .../drm/omapdrm/displays/panel-sharp-ls037v7dw01.c |  4 ++--
 .../drm/omapdrm/displays/panel-sony-acx565akm.c|  4 ++--
 .../drm/omapdrm/displays/panel-tpo-td028ttec1.c|  4 ++--
 .../drm/omapdrm/displays/panel-tpo-td043mtea1.c|  4 ++--
 drivers/gpu/drm/omapdrm/dss/base.c | 27 +++---
 drivers/gpu/drm/omapdrm/dss/display.c  | 24 ---
 drivers/gpu/drm/omapdrm/dss/omapdss.h  |  5 ++--
 drivers/gpu/drm/omapdrm/dss/output.c   |  2 +-
 drivers/gpu/drm/omapdrm/omap_connector.c   |  4 ++--
 drivers/gpu/drm/omapdrm/omap_crtc.c|  2 +-
 drivers/gpu/drm/omapdrm/omap_drv.c |  8 +++
 21 files changed, 62 insertions(+), 66 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c 
b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
index f1d1c67d72b8..a7eb25bd9283 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
@@ -55,7 +55,7 @@ static int tvc_connect(struct omap_dss_device *dssdev)
 
r = omapdss_device_connect(src, dssdev);
if (r) {
-   omap_dss_put_device(src);
+   omapdss_device_put(src);
return r;
}
 
@@ -68,7 +68,7 @@ static void tvc_disconnect(struct omap_dss_device *dssdev)
 
omapdss_device_disconnect(src, dssdev);
 
-   omap_dss_put_device(src);
+   omapdss_device_put(src);
 }
 
 static int tvc_enable(struct omap_dss_device *dssdev)
diff --git a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c 
b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
index 9e0b5a0b2eea..3e71af9ba0c3 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
@@ -69,7 +69,7 @@ static int dvic_connect(struct omap_dss_device *dssdev)
 
r = omapdss_device_connect(src, dssdev);
if (r) {
-   omap_dss_put_device(src);
+   omapdss_device_put(src);
return r;
}
 
@@ -82,7 +82,7 @@ static void dvic_disconnect(struct omap_dss_device *dssdev)
 
omapdss_device_disconnect(src, dssdev);
 
-   omap_dss_put_device(src);
+   omapdss_device_put(src);
 }
 
 static int dvic_enable(struct omap_dss_device *dssdev)
diff --git a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c 
b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
index 064b051c0a29..fd0bad4dc7c9 100644
--- a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
+++ b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
@@ -65,7 +65,7 @@ static int hdmic_connect(struct omap_dss_device *dssdev)
 
r = omapdss_device_connect(src, dssdev);
if (r) {
-   omap_dss_put_device(src);
+   omapdss_device_put(src);
return r;
}
 
@@ -78,7 +78,7 @@ static void hdmic_disconnect(struct omap_dss_device *dssdev)
 
omapdss_device_disconnect(src, dssdev);
 
-   omap_dss_put_device(src);
+   omapdss_device_put(src);
 }
 
 static int hdmic_enable(struct omap_dss_device *dssdev)
diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c 
b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
index c1ed4e2ce8f3..01b00eea3a98 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
@@ -45,7 +45,7 @@ static int opa362_connect(struct omap_dss_device *dssdev,
 
r = omapdss_device_connect(src, dssdev);
if (r) {
-   omap_dss_put_device(src);
+   omapdss_device_put(src);
return r;
}
 
@@ -60,7 +60,7 @@ static void opa362_disconnect(struct omap_dss_device *dssdev,
 
omapdss_device_disconnect(src, >dssdev);
 
-   omap_dss_put_device(src);
+   omapdss_device_put(src);
 }
 
 static int opa362_enable(struct omap_dss_device *dssdev)
diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c 
b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
index b360a68f074d..6f71d2b7de03 100644
---