Re: [PATCH v3 02/10] dt-bindings: display: bridge: tc358775: Add data-lanes

2024-02-12 Thread Krzysztof Kozlowski
On 11/02/2024 10:51, Tony Lindgren wrote:
> The device uses a clock lane, and 1 to 4 DSI data lanes. Let's add the
> data-lanes property starting at 1 similar to what the other bridge
> bindings are doing.
> 
> Let's also drop the data-lanes properties in the example for the DSI host
> controller to avoid confusion. The configuration of the DSI host depends
> on the controller used and is unrelated to the bridge binding.
> 
> Signed-off-by: Tony Lindgren 
> ---

Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof



[PATCH v3 02/10] dt-bindings: display: bridge: tc358775: Add data-lanes

2024-02-11 Thread Tony Lindgren
The device uses a clock lane, and 1 to 4 DSI data lanes. Let's add the
data-lanes property starting at 1 similar to what the other bridge
bindings are doing.

Let's also drop the data-lanes properties in the example for the DSI host
controller to avoid confusion. The configuration of the DSI host depends
on the controller used and is unrelated to the bridge binding.

Signed-off-by: Tony Lindgren 
---
 .../display/bridge/toshiba,tc358775.yaml  | 22 ---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git 
a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml 
b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
--- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml
@@ -46,11 +46,27 @@ properties:
 
 properties:
   port@0:
-$ref: /schemas/graph.yaml#/properties/port
+$ref: /schemas/graph.yaml#/$defs/port-base
+unevaluatedProperties: false
 description: |
   DSI Input. The remote endpoint phandle should be a
   reference to a valid mipi_dsi_host device node.
 
+properties:
+  endpoint:
+$ref: /schemas/media/video-interfaces.yaml#
+unevaluatedProperties: false
+
+properties:
+  data-lanes:
+description: array of physical DSI data lane indexes.
+minItems: 1
+items:
+  - const: 1
+  - const: 2
+  - const: 3
+  - const: 4
+
   port@1:
 $ref: /schemas/graph.yaml#/properties/port
 description: |
@@ -107,6 +123,7 @@ examples:
 reg = <0>;
 d2l_in_test: endpoint {
 remote-endpoint = <_out>;
+data-lanes = <1 2 3 4>;
 };
 };
 
@@ -131,7 +148,6 @@ examples:
 reg = <1>;
 dsi0_out: endpoint {
 remote-endpoint = <_in_test>;
-data-lanes = <0 1 2 3>;
 };
  };
  };
@@ -166,6 +182,7 @@ examples:
 reg = <0>;
 d2l_in_dual: endpoint {
 remote-endpoint = <_out_dual>;
+data-lanes = <1 2 3 4>;
 };
 };
 
@@ -197,7 +214,6 @@ examples:
 reg = <1>;
 dsi0_out_dual: endpoint {
 remote-endpoint = <_in_dual>;
-data-lanes = <0 1 2 3>;
 };
  };
  };
-- 
2.43.0