Re: [PATCH v3 03/14] arm64: dts: renesas: r8a7796: Add CMM units
Hi Jacopo,
On Tue, Aug 27, 2019 at 11:53 AM Jacopo Mondi wrote:
> On Tue, Aug 27, 2019 at 01:43:37AM +0300, Laurent Pinchart wrote:
> > Should you squash this with the patches that add CMM units to the other
> > SoCs ?
>
> I don't know, I guess it depends on Geert's preferences. Geert?
If you add it to all supported SoCs at the same time, a single patch
makes sense.
Acceptance will mostly depends on who's at the end of the arm-soc pipeline:
Olof would prefer a single patch ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 03/14] arm64: dts: renesas: r8a7796: Add CMM units
Hi Laurent,
On Tue, Aug 27, 2019 at 01:43:37AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> Should you squash this with the patches that add CMM units to the other
> SoCs ?
I don't know, I guess it depends on Geert's preferences. Geert?
>
> On Sun, Aug 25, 2019 at 03:51:43PM +0200, Jacopo Mondi wrote:
> > Add CMM units to Renesas R-Car M3-W device tree and reference them from
> > the Display Unit they are connected to.
> >
> > Signed-off-by: Jacopo Mondi
>
> Apart from the issue pointed out by Geert,
>
> Reviewed-by: Laurent Pinchart
>
> > ---
> > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > index 3dc9d73f589a..8d78e1f98a23 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > @@ -2613,6 +2613,30 @@
> > renesas,fcp = <>;
> > };
> >
> > + cmm0: cmm@fea4 {
> > + compatible = "renesas,cmm-r8a7796";
> > + reg = <0 0xfea4 0 0x1000>;
> > + clocks = < CPG_MOD 711>;
> > + power-domains = < R8A7796_PD_ALWAYS_ON>;
> > + resets = < 711>;
> > + };
> > +
> > + cmm1: cmm@fea5 {
> > + compatible = "renesas,cmm-r8a7796";
> > + reg = <0 0xfea5 0 0x1000>;
> > + clocks = < CPG_MOD 710>;
> > + power-domains = < R8A7796_PD_ALWAYS_ON>;
> > + resets = < 710>;
> > + };
> > +
> > + cmm2: cmm@fea6 {
> > + compatible = "renesas,cmm-r8a7796";
> > + reg = <0 0xfea6 0 0x1000>;
> > + clocks = < CPG_MOD 709>;
> > + power-domains = < R8A7796_PD_ALWAYS_ON>;
> > + resets = < 709>;
> > + };
> > +
> > csi20: csi2@fea8 {
> > compatible = "renesas,r8a7796-csi2";
> > reg = <0 0xfea8 0 0x1>;
> > @@ -2766,6 +2790,7 @@
> > status = "disabled";
> >
> > vsps = < >;
> > + cmms = < >;
> >
> > ports {
> > #address-cells = <1>;
>
> --
> Regards,
>
> Laurent Pinchart
signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 03/14] arm64: dts: renesas: r8a7796: Add CMM units
Hi Jacopo,
Thank you for the patch.
Should you squash this with the patches that add CMM units to the other
SoCs ?
On Sun, Aug 25, 2019 at 03:51:43PM +0200, Jacopo Mondi wrote:
> Add CMM units to Renesas R-Car M3-W device tree and reference them from
> the Display Unit they are connected to.
>
> Signed-off-by: Jacopo Mondi
Apart from the issue pointed out by Geert,
Reviewed-by: Laurent Pinchart
> ---
> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index 3dc9d73f589a..8d78e1f98a23 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -2613,6 +2613,30 @@
> renesas,fcp = <>;
> };
>
> + cmm0: cmm@fea4 {
> + compatible = "renesas,cmm-r8a7796";
> + reg = <0 0xfea4 0 0x1000>;
> + clocks = < CPG_MOD 711>;
> + power-domains = < R8A7796_PD_ALWAYS_ON>;
> + resets = < 711>;
> + };
> +
> + cmm1: cmm@fea5 {
> + compatible = "renesas,cmm-r8a7796";
> + reg = <0 0xfea5 0 0x1000>;
> + clocks = < CPG_MOD 710>;
> + power-domains = < R8A7796_PD_ALWAYS_ON>;
> + resets = < 710>;
> + };
> +
> + cmm2: cmm@fea6 {
> + compatible = "renesas,cmm-r8a7796";
> + reg = <0 0xfea6 0 0x1000>;
> + clocks = < CPG_MOD 709>;
> + power-domains = < R8A7796_PD_ALWAYS_ON>;
> + resets = < 709>;
> + };
> +
> csi20: csi2@fea8 {
> compatible = "renesas,r8a7796-csi2";
> reg = <0 0xfea8 0 0x1>;
> @@ -2766,6 +2790,7 @@
> status = "disabled";
>
> vsps = < >;
> + cmms = < >;
>
> ports {
> #address-cells = <1>;
--
Regards,
Laurent Pinchart
Re: [PATCH v3 03/14] arm64: dts: renesas: r8a7796: Add CMM units
Hi Geert.
On Mon, Aug 26, 2019 at 09:28:56AM +0200, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi
> wrote:
> > Add CMM units to Renesas R-Car M3-W device tree and reference them from
> > the Display Unit they are connected to.
> >
> > Signed-off-by: Jacopo Mondi
> > ---
> > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > index 3dc9d73f589a..8d78e1f98a23 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > @@ -2613,6 +2613,30 @@
> > renesas,fcp = <>;
> > };
> >
> > + cmm0: cmm@fea4 {
> > + compatible = "renesas,cmm-r8a7796";
>
> Shouldn't you add "renesas,rcar-gen3-cmm" as a fallback?
Should I? Since you have suggested to drop all per-SoC compatibles
from the driver I guess so...
Thanks
j
> (for all CMM nodes in all DT patches)
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 03/14] arm64: dts: renesas: r8a7796: Add CMM units
Hi Jacopo,
On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi wrote:
> Add CMM units to Renesas R-Car M3-W device tree and reference them from
> the Display Unit they are connected to.
>
> Signed-off-by: Jacopo Mondi
> ---
> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index 3dc9d73f589a..8d78e1f98a23 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -2613,6 +2613,30 @@
> renesas,fcp = <>;
> };
>
> + cmm0: cmm@fea4 {
> + compatible = "renesas,cmm-r8a7796";
Shouldn't you add "renesas,rcar-gen3-cmm" as a fallback?
(for all CMM nodes in all DT patches)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[PATCH v3 03/14] arm64: dts: renesas: r8a7796: Add CMM units
Add CMM units to Renesas R-Car M3-W device tree and reference them from
the Display Unit they are connected to.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 3dc9d73f589a..8d78e1f98a23 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -2613,6 +2613,30 @@
renesas,fcp = <>;
};
+ cmm0: cmm@fea4 {
+ compatible = "renesas,cmm-r8a7796";
+ reg = <0 0xfea4 0 0x1000>;
+ clocks = < CPG_MOD 711>;
+ power-domains = < R8A7796_PD_ALWAYS_ON>;
+ resets = < 711>;
+ };
+
+ cmm1: cmm@fea5 {
+ compatible = "renesas,cmm-r8a7796";
+ reg = <0 0xfea5 0 0x1000>;
+ clocks = < CPG_MOD 710>;
+ power-domains = < R8A7796_PD_ALWAYS_ON>;
+ resets = < 710>;
+ };
+
+ cmm2: cmm@fea6 {
+ compatible = "renesas,cmm-r8a7796";
+ reg = <0 0xfea6 0 0x1000>;
+ clocks = < CPG_MOD 709>;
+ power-domains = < R8A7796_PD_ALWAYS_ON>;
+ resets = < 709>;
+ };
+
csi20: csi2@fea8 {
compatible = "renesas,r8a7796-csi2";
reg = <0 0xfea8 0 0x1>;
@@ -2766,6 +2790,7 @@
status = "disabled";
vsps = < >;
+ cmms = < >;
ports {
#address-cells = <1>;
--
2.22.0
