Re: [PATCH v3 05/24] media: i2c: switch to use of_graph_get_next_device_endpoint()
Hi Rob, again > > This is assuming there's just 1 port and 1 endpoint, but let's be > > specific as the bindings are (first endpoint on port 0): > > > > of_graph_get_endpoint_by_regs(client->dev.of_node, 0, -1); > > > > Note we could ask for endpoint 0 here, but the bindings generally allow > > for more than 1. > > > > I imagine most of the other cases here are the same. I'm bit confused here. You mentioned that -1 is wrong in previous mail. Most cases are in the form of of_graph_get_next_endpoint(dev, NULL) which is equivalent to of_graph_get_endpoint_by_regs(dev, 0, 0). Technically, -1 instead of 0 is equivalent, but I'd argue is sloppy and wrong. But you mentioned -1 here, So, I will use it on next patch-set. Thank you for your help !! Best regards --- Renesas Electronics Ph.D. Kuninori Morimoto
Re: [PATCH v3 05/24] media: i2c: switch to use of_graph_get_next_device_endpoint()
Hi Rob > I've read the threads already and think you should skip the rename. Just > put 'port' in the name of the new one. OK > That and taking a port number param should be enough distinction. I think we want to use "port" directly instead of "port number" on new function. Thank you for your help !! Best regards --- Renesas Electronics Ph.D. Kuninori Morimoto
Re: [PATCH v3 05/24] media: i2c: switch to use of_graph_get_next_device_endpoint()
On Sun, Feb 04, 2024 at 11:44:39PM +, Kuninori Morimoto wrote:
>
> Hi Rob
>
> > This is assuming there's just 1 port and 1 endpoint, but let's be
> > specific as the bindings are (first endpoint on port 0):
> >
> > of_graph_get_endpoint_by_regs(client->dev.of_node, 0, -1);
> >
> > Note we could ask for endpoint 0 here, but the bindings generally allow
> > for more than 1.
> >
> > I imagine most of the other cases here are the same.
>
> I will do it on new patch-set
>
> > > - for_each_endpoint_of_node(state->dev->of_node, ep_np) {
> > > + for_each_device_endpoint_of_node(state->dev->of_node, ep_np) {
> >
> > I would skip the rename.
>
> It is needed to avoid confuse, because new function will add
> another endpoint loop.
>
> see
> https://lore.kernel.org/r/20240131100701.754a95ee@booty
I've read the threads already and think you should skip the rename. Just
put 'port' in the name of the new one. That and taking a port number
param should be enough distinction.
Rob
Re: [PATCH v3 05/24] media: i2c: switch to use of_graph_get_next_device_endpoint()
Hi Rob
> This is assuming there's just 1 port and 1 endpoint, but let's be
> specific as the bindings are (first endpoint on port 0):
>
> of_graph_get_endpoint_by_regs(client->dev.of_node, 0, -1);
>
> Note we could ask for endpoint 0 here, but the bindings generally allow
> for more than 1.
>
> I imagine most of the other cases here are the same.
I will do it on new patch-set
> > - for_each_endpoint_of_node(state->dev->of_node, ep_np) {
> > + for_each_device_endpoint_of_node(state->dev->of_node, ep_np) {
>
> I would skip the rename.
It is needed to avoid confuse, because new function will add
another endpoint loop.
see
https://lore.kernel.org/r/20240131100701.754a95ee@booty
Thank you for your help !!
Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto
Re: [PATCH v3 05/24] media: i2c: switch to use of_graph_get_next_device_endpoint()
On Wed, Jan 31, 2024 at 05:05:27AM +, Kuninori Morimoto wrote:
> of_graph_get_next_endpoint() is now renamed to
> of_graph_get_next_device_endpoint(). Switch to it.
>
> Signed-off-by: Kuninori Morimoto
> ---
> drivers/media/i2c/adv7343.c | 2 +-
> drivers/media/i2c/adv748x/adv748x-core.c | 2 +-
> drivers/media/i2c/adv7604.c | 2 +-
> drivers/media/i2c/isl7998x.c | 2 +-
> drivers/media/i2c/max9286.c | 2 +-
> drivers/media/i2c/mt9p031.c | 2 +-
> drivers/media/i2c/mt9v032.c | 2 +-
> drivers/media/i2c/ov2659.c | 2 +-
> drivers/media/i2c/ov5645.c | 2 +-
> drivers/media/i2c/ov5647.c | 2 +-
> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +-
> drivers/media/i2c/s5k5baf.c | 2 +-
> drivers/media/i2c/tc358743.c | 2 +-
> drivers/media/i2c/tda1997x.c | 2 +-
> drivers/media/i2c/tvp514x.c | 2 +-
> drivers/media/i2c/tvp5150.c | 4 ++--
> drivers/media/i2c/tvp7002.c | 2 +-
> 17 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/media/i2c/adv7343.c b/drivers/media/i2c/adv7343.c
> index ff21cd4744d3..7e4eb2f8bf0d 100644
> --- a/drivers/media/i2c/adv7343.c
> +++ b/drivers/media/i2c/adv7343.c
> @@ -403,7 +403,7 @@ adv7343_get_pdata(struct i2c_client *client)
> if (!IS_ENABLED(CONFIG_OF) || !client->dev.of_node)
> return client->dev.platform_data;
>
> - np = of_graph_get_next_endpoint(client->dev.of_node, NULL);
> + np = of_graph_get_next_device_endpoint(client->dev.of_node, NULL);
This is assuming there's just 1 port and 1 endpoint, but let's be
specific as the bindings are (first endpoint on port 0):
of_graph_get_endpoint_by_regs(client->dev.of_node, 0, -1);
Note we could ask for endpoint 0 here, but the bindings generally allow
for more than 1.
I imagine most of the other cases here are the same.
> if (!np)
> return NULL;
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c
> b/drivers/media/i2c/adv748x/adv748x-core.c
> index 3eb6d5e8f082..4e9e4cef8954 100644
> --- a/drivers/media/i2c/adv748x/adv748x-core.c
> +++ b/drivers/media/i2c/adv748x/adv748x-core.c
> @@ -657,7 +657,7 @@ static int adv748x_parse_dt(struct adv748x_state *state)
> bool in_found = false;
> int ret;
>
> - for_each_endpoint_of_node(state->dev->of_node, ep_np) {
> + for_each_device_endpoint_of_node(state->dev->of_node, ep_np) {
I would skip the rename.
Rob
[PATCH v3 05/24] media: i2c: switch to use of_graph_get_next_device_endpoint()
of_graph_get_next_endpoint() is now renamed to
of_graph_get_next_device_endpoint(). Switch to it.
Signed-off-by: Kuninori Morimoto
---
drivers/media/i2c/adv7343.c | 2 +-
drivers/media/i2c/adv748x/adv748x-core.c | 2 +-
drivers/media/i2c/adv7604.c | 2 +-
drivers/media/i2c/isl7998x.c | 2 +-
drivers/media/i2c/max9286.c | 2 +-
drivers/media/i2c/mt9p031.c | 2 +-
drivers/media/i2c/mt9v032.c | 2 +-
drivers/media/i2c/ov2659.c | 2 +-
drivers/media/i2c/ov5645.c | 2 +-
drivers/media/i2c/ov5647.c | 2 +-
drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +-
drivers/media/i2c/s5k5baf.c | 2 +-
drivers/media/i2c/tc358743.c | 2 +-
drivers/media/i2c/tda1997x.c | 2 +-
drivers/media/i2c/tvp514x.c | 2 +-
drivers/media/i2c/tvp5150.c | 4 ++--
drivers/media/i2c/tvp7002.c | 2 +-
17 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/media/i2c/adv7343.c b/drivers/media/i2c/adv7343.c
index ff21cd4744d3..7e4eb2f8bf0d 100644
--- a/drivers/media/i2c/adv7343.c
+++ b/drivers/media/i2c/adv7343.c
@@ -403,7 +403,7 @@ adv7343_get_pdata(struct i2c_client *client)
if (!IS_ENABLED(CONFIG_OF) || !client->dev.of_node)
return client->dev.platform_data;
- np = of_graph_get_next_endpoint(client->dev.of_node, NULL);
+ np = of_graph_get_next_device_endpoint(client->dev.of_node, NULL);
if (!np)
return NULL;
diff --git a/drivers/media/i2c/adv748x/adv748x-core.c
b/drivers/media/i2c/adv748x/adv748x-core.c
index 3eb6d5e8f082..4e9e4cef8954 100644
--- a/drivers/media/i2c/adv748x/adv748x-core.c
+++ b/drivers/media/i2c/adv748x/adv748x-core.c
@@ -657,7 +657,7 @@ static int adv748x_parse_dt(struct adv748x_state *state)
bool in_found = false;
int ret;
- for_each_endpoint_of_node(state->dev->of_node, ep_np) {
+ for_each_device_endpoint_of_node(state->dev->of_node, ep_np) {
of_graph_parse_endpoint(ep_np, );
adv_info(state, "Endpoint %pOF on port %d", ep.local_node,
ep.port);
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index b202a85fbeaa..5b98a688b5de 100644
--- a/drivers/media/i2c/adv7604.c
+++ b/drivers/media/i2c/adv7604.c
@@ -3205,7 +3205,7 @@ static int adv76xx_parse_dt(struct adv76xx_state *state)
np = state->i2c_clients[ADV76XX_PAGE_IO]->dev.of_node;
/* Parse the endpoint. */
- endpoint = of_graph_get_next_endpoint(np, NULL);
+ endpoint = of_graph_get_next_device_endpoint(np, NULL);
if (!endpoint)
return -EINVAL;
diff --git a/drivers/media/i2c/isl7998x.c b/drivers/media/i2c/isl7998x.c
index 73460688c356..1ef26dd8290c 100644
--- a/drivers/media/i2c/isl7998x.c
+++ b/drivers/media/i2c/isl7998x.c
@@ -580,7 +580,7 @@ static int isl7998x_get_nr_inputs(struct device_node
*of_node)
unsigned int inputs = 0;
unsigned int i;
- if (of_graph_get_endpoint_count(of_node) > ISL7998X_NUM_PADS)
+ if (of_graph_get_device_endpoint_count(of_node) > ISL7998X_NUM_PADS)
return -EINVAL;
/*
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index fc1cf196ef01..7d0725285a24 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -1452,7 +1452,7 @@ static int max9286_parse_dt(struct max9286_priv *priv)
of_node_put(i2c_mux);
/* Parse the endpoints */
- for_each_endpoint_of_node(dev->of_node, node) {
+ for_each_device_endpoint_of_node(dev->of_node, node) {
struct max9286_source *source;
struct of_endpoint ep;
diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
index 348f1e1098fb..4832968ca50b 100644
--- a/drivers/media/i2c/mt9p031.c
+++ b/drivers/media/i2c/mt9p031.c
@@ -1080,7 +1080,7 @@ mt9p031_get_pdata(struct i2c_client *client)
if (!IS_ENABLED(CONFIG_OF) || !client->dev.of_node)
return client->dev.platform_data;
- np = of_graph_get_next_endpoint(client->dev.of_node, NULL);
+ np = of_graph_get_next_device_endpoint(client->dev.of_node, NULL);
if (!np)
return NULL;
diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c
index 1c6f6cea1204..236a671857a1 100644
--- a/drivers/media/i2c/mt9v032.c
+++ b/drivers/media/i2c/mt9v032.c
@@ -1008,7 +1008,7 @@ mt9v032_get_pdata(struct i2c_client *client)
if (!IS_ENABLED(CONFIG_OF) || !client->dev.of_node)
return client->dev.platform_data;
- np = of_graph_get_next_endpoint(client->dev.of_node, NULL);
+ np = of_graph_get_next_device_endpoint(client->dev.of_node, NULL);
if (!np)
return NULL;
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index
