Re: [PATCH v3 1/2] dt-bindings: display: panel: Add Raydium RM69380
On Tue, Apr 16, 2024 at 08:30:48PM +0200, David Wronek wrote: > Raydium RM69380 is a display driver IC used to drive OLED DSI panels. > Add a dt-binding for it. > > Signed-off-by: David Wronek > --- > Note: > Depends on commit 48a516363e29 ("dt-bindings: display: panel: add common > dual-link schema") > --- > .../bindings/display/panel/raydium,rm69380.yaml| 91 > ++ > 1 file changed, 91 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml > b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml > new file mode 100644 > index ..0ac7d033cbe0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml > @@ -0,0 +1,91 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/raydium,rm69380.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Raydium RM6380-based DSI display panels RM69380-based > + > +maintainers: > + - David Wronek > + > +description: > + The Raydium RM69380 is a generic DSI panel IC used to control > + OLED panels. > + > +allOf: > + - $ref: panel-common-dual.yaml# > + > +properties: > + compatible: > +items: > + - enum: > + - lenovo,j716f-edo-rm69380 > + - const: raydium,rm69380 > +description: This indicates the panel manufacturer of the panel > + that is in turn using the RM69380 panel driver. The compatible > + string determines how the RM69380 panel driver shall be configured > + to work with the indicated panel. The raydium,rm69380 compatible shall > + always be provided as a fallback. > + > + avdd-supply: > +description: Analog voltage rail > + > + vddio-supply: > +description: I/O voltage rail > + > + reset-gpios: > +maxItems: 1 > +description: phandle of gpio for reset line - This should be active low > + > + ports: true > + reg: true Drop these and change 'addtionalProperties' to 'unevaluatedProperties'. Other properties in panel-common.yaml should be allowed. width-mm and height-mm for example. > + > +required: > + - compatible > + - reg > + - avdd-supply > + - vddio-supply > + - reset-gpios > + - ports Already required in panel-common-dual.yaml. Rob
Re: [PATCH v3 1/2] dt-bindings: display: panel: Add Raydium RM69380
On Tue, 16 Apr 2024 20:30:48 +0200, David Wronek wrote: > Raydium RM69380 is a display driver IC used to drive OLED DSI panels. > Add a dt-binding for it. > > Signed-off-by: David Wronek > --- > Note: > Depends on commit 48a516363e29 ("dt-bindings: display: panel: add common > dual-link schema") > --- > .../bindings/display/panel/raydium,rm69380.yaml| 91 > ++ > 1 file changed, 91 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/display/panel/panel-common-dual.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/raydium,rm69380.example.dtb: panel@0: False schema does not allow {'compatible': ['lenovo,j716f-edo-rm69380', 'raydium,rm69380'], 'reg': [[0]], 'avdd-supply': [[4294967295]], 'vddio-supply': [[4294967295]], 'reset-gpios': [[4294967295, 75, 1]], 'ports': {'#address-cells': [[1]], '#size-cells': [[0]], 'port@0': {'reg': [[0]], 'endpoint': {'remote-endpoint': [[4294967295]]}}, 'port@1': {'reg': [[1]], 'endpoint': {'remote-endpoint': [[4294967295]]}}}, '$nodename': ['panel@0']} from schema $id: http://devicetree.org/schemas/display/panel/raydium,rm69380.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240416-raydium-rm69380-driver-v3-1-21600ac4c...@mainlining.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
[PATCH v3 1/2] dt-bindings: display: panel: Add Raydium RM69380
Raydium RM69380 is a display driver IC used to drive OLED DSI panels. Add a dt-binding for it. Signed-off-by: David Wronek --- Note: Depends on commit 48a516363e29 ("dt-bindings: display: panel: add common dual-link schema") --- .../bindings/display/panel/raydium,rm69380.yaml| 91 ++ 1 file changed, 91 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml new file mode 100644 index ..0ac7d033cbe0 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml @@ -0,0 +1,91 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/raydium,rm69380.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Raydium RM6380-based DSI display panels + +maintainers: + - David Wronek + +description: + The Raydium RM69380 is a generic DSI panel IC used to control + OLED panels. + +allOf: + - $ref: panel-common-dual.yaml# + +properties: + compatible: +items: + - enum: + - lenovo,j716f-edo-rm69380 + - const: raydium,rm69380 +description: This indicates the panel manufacturer of the panel + that is in turn using the RM69380 panel driver. The compatible + string determines how the RM69380 panel driver shall be configured + to work with the indicated panel. The raydium,rm69380 compatible shall + always be provided as a fallback. + + avdd-supply: +description: Analog voltage rail + + vddio-supply: +description: I/O voltage rail + + reset-gpios: +maxItems: 1 +description: phandle of gpio for reset line - This should be active low + + ports: true + reg: true + +required: + - compatible + - reg + - avdd-supply + - vddio-supply + - reset-gpios + - ports + +additionalProperties: false + +examples: + - | +#include + +dsi { +#address-cells = <1>; +#size-cells = <0>; + +panel@0 { +compatible = "lenovo,j716f-edo-rm69380", "raydium,rm69380"; +reg = <0>; + +avdd-supply = <&panel_avdd_regulator>; +vddio-supply = <&vreg_l14a>; +reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>; + +ports { +#address-cells = <1>; +#size-cells = <0>; + +port@0 { +reg = <0>; +panel_in_0: endpoint { +remote-endpoint = <&mdss_dsi0_out>; +}; +}; + +port@1 { +reg = <1>; +panel_in_1: endpoint { +remote-endpoint = <&mdss_dsi1_out>; +}; +}; +}; +}; +}; + +... -- 2.44.0