Re: [PATCH v3 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema

2024-01-18 Thread Dharma.B
On 18/01/24 9:01 pm, Conor Dooley wrote:
> On Thu, Jan 18, 2024 at 02:56:10PM +0530, Dharma Balasubiramani wrote:
>> Convert the existing DT binding to DT schema of the Atmel's HLCDC display
>> controller.
>>
>> Signed-off-by: Dharma Balasubiramani
>> ---
>> changelog
>> v2 -> v3
>> - Remove '|' in description, as there is no formatting to preserve.
>> - Ref video-interfaces as endpoint.
>> - Remove ref and description for bus-width.
>> - Add new line before the child node in example.
>> - Remove 'example 2', as it is not required for just one additional property.
> Rob's comment on the previous version was:
> | Just 1 extra property doesn't justify 2 examples.
> |
> | In any case, drop the partial examples and just have 1 complete example
> | in the MFD binding schema.
> 
Okay understood, I will include the 'bus-width' in the example.
-- 
With Best Regards,
Dharma B.



Re: [PATCH v3 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema

2024-01-18 Thread Conor Dooley
On Thu, Jan 18, 2024 at 02:56:10PM +0530, Dharma Balasubiramani wrote:
> Convert the existing DT binding to DT schema of the Atmel's HLCDC display
> controller.
> 
> Signed-off-by: Dharma Balasubiramani 
> ---
> changelog
> v2 -> v3
> - Remove '|' in description, as there is no formatting to preserve.
> - Ref video-interfaces as endpoint.
> - Remove ref and description for bus-width.
> - Add new line before the child node in example.

> - Remove 'example 2', as it is not required for just one additional property.

Rob's comment on the previous version was:
| Just 1 extra property doesn't justify 2 examples.
| 
| In any case, drop the partial examples and just have 1 complete example 
| in the MFD binding schema.



signature.asc
Description: PGP signature


[PATCH v3 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema

2024-01-18 Thread Dharma Balasubiramani
Convert the existing DT binding to DT schema of the Atmel's HLCDC display
controller.

Signed-off-by: Dharma Balasubiramani 
---
changelog
v2 -> v3
- Remove '|' in description, as there is no formatting to preserve.
- Ref video-interfaces as endpoint.
- Remove ref and description for bus-width.
- Add new line before the child node in example.
- Remove 'example 2', as it is not required for just one additional property.
v1 -> v2
- Remove the explicit copyrights.
- Modify filename like compatible.
- Modify title (drop words like binding/driver).
- Modify description actually describing the hardware and not the driver.
- Remove pinctrl properties which aren't required.
- Ref endpoint and not endpoint-base.
- Drop redundant info about bus-width description and add ref to 
video-interfaces.
- Move 'additionalProperties' after 'Required'.
- Drop parent node and it's other sub-device node which are not related here.
- Add compatible to example 2 and add comments that bus-width is the diff 
between two examples.
---
 .../atmel/atmel,hlcdc-display-controller.yaml | 84 +++
 .../bindings/display/atmel/hlcdc-dc.txt   | 75 -
 2 files changed, 84 insertions(+), 75 deletions(-)
 create mode 100644 
Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt

diff --git 
a/Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml
 
b/Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml
new file mode 100644
index ..0c0871cb85f1
--- /dev/null
+++ 
b/Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml
@@ -0,0 +1,84 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: 
http://devicetree.org/schemas/display/atmel/atmel,hlcdc-display-controller.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel's High LCD Controller (HLCDC)
+
+maintainers:
+  - Nicolas Ferre 
+  - Alexandre Belloni 
+  - Claudiu Beznea 
+
+description:
+  The LCD Controller (LCDC) consists of logic for transferring LCD image
+  data from an external display buffer to a TFT LCD panel. The LCDC has one
+  display input buffer per layer that fetches pixels through the single bus
+  host interface and a look-up table to allow palletized display
+  configurations.
+
+properties:
+  compatible:
+const: atmel,hlcdc-display-controller
+
+  '#address-cells':
+const: 1
+
+  '#size-cells':
+const: 0
+
+  port@0:
+$ref: /schemas/graph.yaml#/$defs/port-base
+unevaluatedProperties: false
+description:
+  Output endpoint of the controller, connecting the LCD panel signals.
+
+properties:
+  '#address-cells':
+const: 1
+
+  '#size-cells':
+const: 0
+
+  reg:
+maxItems: 1
+
+  endpoint:
+$ref: /schemas/media/video-interfaces.yaml#
+unevaluatedProperties: false
+description:
+  Endpoint connecting the LCD panel signals.
+
+properties:
+  bus-width:
+enum: [ 12, 16, 18, 24 ]
+
+required:
+  - '#address-cells'
+  - '#size-cells'
+  - compatible
+  - port@0
+
+additionalProperties: false
+
+examples:
+  - |
+display-controller {
+  compatible = "atmel,hlcdc-display-controller";
+  pinctrl-names = "default";
+  pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb888>;
+  #address-cells = <1>;
+  #size-cells = <0>;
+
+  port@0 {
+#address-cells = <1>;
+#size-cells = <0>;
+reg = <0>;
+
+hlcdc_panel_output: endpoint@0 {
+  reg = <0>;
+  remote-endpoint = <&panel_input>;
+};
+  };
+};
diff --git a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt 
b/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt
deleted file mode 100644
index 923aea25344c..
--- a/Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt
+++ /dev/null
@@ -1,75 +0,0 @@
-Device-Tree bindings for Atmel's HLCDC (High LCD Controller) DRM driver
-
-The Atmel HLCDC Display Controller is subdevice of the HLCDC MFD device.
-See ../../mfd/atmel-hlcdc.txt for more details.
-
-Required properties:
- - compatible: value should be "atmel,hlcdc-display-controller"
- - pinctrl-names: the pin control state names. Should contain "default".
- - pinctrl-0: should contain the default pinctrl states.
- - #address-cells: should be set to 1.
- - #size-cells: should be set to 0.
-
-Required children nodes:
- Children nodes are encoding available output ports and their connections
- to external devices using the OF graph representation (see ../graph.txt).
- At least one port node is required.
-
-Optional properties in grandchild nodes:
- Any endpoint grandchild node may specify a desired video interface
- according to ../../media/video-interfaces.txt, specifically
- - bus-width: recognized values are <1