Re: [PATCH v3 1/4] dt-bindings: display: Convert Allwinner display pipeline to schemas
On Thu, Jan 09, 2020 at 11:14:26AM -0600, Rob Herring wrote: > On Fri, Jan 3, 2020 at 9:28 AM Maxime Ripard wrote: > > > > The Allwinner SoCs have a display engine composed of several controllers > > assembled differently depending on the SoC, the number and type of output > > they have, and the additional features they provide. A number of those are > > supported in Linux, with the matching bindings. > > > > Now that we have the DT validation in place, let's split into separate file > > and convert the device tree bindings for those controllers to schemas. > > > > Signed-off-by: Maxime Ripard > > > > --- > > > > Changes from v2: > > - Changed a number of maxItems to minItems to make more sense > > - Fixed a few enum that were improperly declared. This raised a bunch of > > warnings that were unnoticed before. Fixed them. > > - Added an if clause to the HDMI PHY binding to check the number of clocks > > > > Changes from v1: > > - Declare the ports in the bindings > > --- > > .../allwinner,sun4i-a10-display-backend.yaml | 291 > > .../allwinner,sun4i-a10-display-engine.yaml | 114 +++ > > .../allwinner,sun4i-a10-display-frontend.yaml | 138 > > .../display/allwinner,sun4i-a10-hdmi.yaml | 183 + > > .../display/allwinner,sun4i-a10-tcon.yaml | 676 ++ > > .../allwinner,sun4i-a10-tv-encoder.yaml | 62 ++ > > .../display/allwinner,sun6i-a31-drc.yaml | 138 > > .../allwinner,sun8i-a83t-de2-mixer.yaml | 118 +++ > > .../display/allwinner,sun8i-a83t-dw-hdmi.yaml | 273 +++ > > .../allwinner,sun8i-a83t-hdmi-phy.yaml| 117 +++ > > .../display/allwinner,sun8i-r40-tcon-top.yaml | 382 ++ > > .../display/allwinner,sun9i-a80-deu.yaml | 133 > > .../bindings/display/sunxi/sun4i-drm.txt | 637 - > > 13 files changed, 2625 insertions(+), 637 deletions(-) > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-backend.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-frontend.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-hdmi.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tv-encoder.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun6i-a31-drc.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-hdmi-phy.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/allwinner,sun9i-a80-deu.yaml > > delete mode 100644 > > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > Reviewed-by: Rob Herring Thanks! I just applied it to drm-misc-next Maxime signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 1/4] dt-bindings: display: Convert Allwinner display pipeline to schemas
On Fri, Jan 3, 2020 at 9:28 AM Maxime Ripard wrote: > > The Allwinner SoCs have a display engine composed of several controllers > assembled differently depending on the SoC, the number and type of output > they have, and the additional features they provide. A number of those are > supported in Linux, with the matching bindings. > > Now that we have the DT validation in place, let's split into separate file > and convert the device tree bindings for those controllers to schemas. > > Signed-off-by: Maxime Ripard > > --- > > Changes from v2: > - Changed a number of maxItems to minItems to make more sense > - Fixed a few enum that were improperly declared. This raised a bunch of > warnings that were unnoticed before. Fixed them. > - Added an if clause to the HDMI PHY binding to check the number of clocks > > Changes from v1: > - Declare the ports in the bindings > --- > .../allwinner,sun4i-a10-display-backend.yaml | 291 > .../allwinner,sun4i-a10-display-engine.yaml | 114 +++ > .../allwinner,sun4i-a10-display-frontend.yaml | 138 > .../display/allwinner,sun4i-a10-hdmi.yaml | 183 + > .../display/allwinner,sun4i-a10-tcon.yaml | 676 ++ > .../allwinner,sun4i-a10-tv-encoder.yaml | 62 ++ > .../display/allwinner,sun6i-a31-drc.yaml | 138 > .../allwinner,sun8i-a83t-de2-mixer.yaml | 118 +++ > .../display/allwinner,sun8i-a83t-dw-hdmi.yaml | 273 +++ > .../allwinner,sun8i-a83t-hdmi-phy.yaml| 117 +++ > .../display/allwinner,sun8i-r40-tcon-top.yaml | 382 ++ > .../display/allwinner,sun9i-a80-deu.yaml | 133 > .../bindings/display/sunxi/sun4i-drm.txt | 637 - > 13 files changed, 2625 insertions(+), 637 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-backend.yaml > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-frontend.yaml > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-hdmi.yaml > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tv-encoder.yaml > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun6i-a31-drc.yaml > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-hdmi-phy.yaml > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > create mode 100644 > Documentation/devicetree/bindings/display/allwinner,sun9i-a80-deu.yaml > delete mode 100644 > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt Reviewed-by: Rob Herring ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 1/4] dt-bindings: display: Convert Allwinner display pipeline to schemas
Hi Rob, On Fri, Jan 03, 2020 at 04:27:58PM +0100, Maxime Ripard wrote: > The Allwinner SoCs have a display engine composed of several controllers > assembled differently depending on the SoC, the number and type of output > they have, and the additional features they provide. A number of those are > supported in Linux, with the matching bindings. > > Now that we have the DT validation in place, let's split into separate file > and convert the device tree bindings for those controllers to schemas. > > Signed-off-by: Maxime Ripard > > --- > > Changes from v2: > - Changed a number of maxItems to minItems to make more sense > - Fixed a few enum that were improperly declared. This raised a bunch of > warnings that were unnoticed before. Fixed them. > - Added an if clause to the HDMI PHY binding to check the number of clocks > > Changes from v1: > - Declare the ports in the bindings Does that new version address your comments? As you know, this is the final schema patch for the Allwinner SoCs, so I'd like to get this merged in 5.6 to close this off. Thanks! Maxime signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v3 1/4] dt-bindings: display: Convert Allwinner display pipeline to schemas
The Allwinner SoCs have a display engine composed of several controllers assembled differently depending on the SoC, the number and type of output they have, and the additional features they provide. A number of those are supported in Linux, with the matching bindings. Now that we have the DT validation in place, let's split into separate file and convert the device tree bindings for those controllers to schemas. Signed-off-by: Maxime Ripard --- Changes from v2: - Changed a number of maxItems to minItems to make more sense - Fixed a few enum that were improperly declared. This raised a bunch of warnings that were unnoticed before. Fixed them. - Added an if clause to the HDMI PHY binding to check the number of clocks Changes from v1: - Declare the ports in the bindings --- .../allwinner,sun4i-a10-display-backend.yaml | 291 .../allwinner,sun4i-a10-display-engine.yaml | 114 +++ .../allwinner,sun4i-a10-display-frontend.yaml | 138 .../display/allwinner,sun4i-a10-hdmi.yaml | 183 + .../display/allwinner,sun4i-a10-tcon.yaml | 676 ++ .../allwinner,sun4i-a10-tv-encoder.yaml | 62 ++ .../display/allwinner,sun6i-a31-drc.yaml | 138 .../allwinner,sun8i-a83t-de2-mixer.yaml | 118 +++ .../display/allwinner,sun8i-a83t-dw-hdmi.yaml | 273 +++ .../allwinner,sun8i-a83t-hdmi-phy.yaml| 117 +++ .../display/allwinner,sun8i-r40-tcon-top.yaml | 382 ++ .../display/allwinner,sun9i-a80-deu.yaml | 133 .../bindings/display/sunxi/sun4i-drm.txt | 637 - 13 files changed, 2625 insertions(+), 637 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-backend.yaml create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-frontend.yaml create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun4i-a10-hdmi.yaml create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tv-encoder.yaml create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun6i-a31-drc.yaml create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-hdmi-phy.yaml create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml create mode 100644 Documentation/devicetree/bindings/display/allwinner,sun9i-a80-deu.yaml delete mode 100644 Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-backend.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-backend.yaml new file mode 100644 index ..86057d541065 --- /dev/null +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-backend.yaml @@ -0,0 +1,291 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/allwinner,sun4i-a10-display-backend.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allwinner A10 Display Engine Backend Device Tree Bindings + +maintainers: + - Chen-Yu Tsai + - Maxime Ripard + +description: | + The display engine backend exposes layers and sprites to the system. + +properties: + compatible: +enum: + - allwinner,sun4i-a10-display-backend + - allwinner,sun5i-a13-display-backend + - allwinner,sun6i-a31-display-backend + - allwinner,sun7i-a20-display-backend + - allwinner,sun8i-a23-display-backend + - allwinner,sun8i-a33-display-backend + - allwinner,sun9i-a80-display-backend + + reg: +minItems: 1 +maxItems: 2 +items: + - description: Display Backend registers + - description: SAT registers + + reg-names: +minItems: 1 +maxItems: 2 +items: + - const: be + - const: sat + + interrupts: +maxItems: 1 + + clocks: +minItems: 3 +maxItems: 4 +items: + - description: The backend interface clock + - description: The backend module clock + - description: The backend DRAM clock + - description: The SAT clock + + clock-names: +minItems: 3 +maxItems: 4 +items: + - const: ahb + - const: mod + - const: ram + - const: sat + + resets: +minItems: 1 +maxItems: 2 +items: + - description: The Backend reset line + - description: The SAT reset line + + reset-names: +minItems: 1 +maxItems: 2 +items: + - const: be + - const: sat + + # FIXME: This should be made required eventually once every SoC
