Re: [PATCH v3 4/5] drm: add drm_fb_xrgb8888_to_rgb888_dstclip()

2019-04-05 Thread Noralf Trønnes


Den 05.04.2019 11.52, skrev Gerd Hoffmann:
> Simliar to drm_fb_xrgb_to_rgb565_dstclip() but converts to rgb888

Simliar -> Similar

> instead of rgb565.
> 
> Signed-off-by: Gerd Hoffmann 
> ---

Reviewed-by: Noralf Trønnes 

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v3 4/5] drm: add drm_fb_xrgb8888_to_rgb888_dstclip()

2019-04-05 Thread Gerd Hoffmann
Simliar to drm_fb_xrgb_to_rgb565_dstclip() but converts to rgb888
instead of rgb565.

Signed-off-by: Gerd Hoffmann 
---
 include/drm/drm_format_helper.h |  3 ++
 drivers/gpu/drm/drm_format_helper.c | 60 +
 2 files changed, 63 insertions(+)

diff --git a/include/drm/drm_format_helper.h b/include/drm/drm_format_helper.h
index a84d71fa446b..6f84380757ee 100644
--- a/include/drm/drm_format_helper.h
+++ b/include/drm/drm_format_helper.h
@@ -25,6 +25,9 @@ void drm_fb_xrgb_to_rgb565(void *dst, void *vaddr,
 void drm_fb_xrgb_to_rgb565_dstclip(void *dst, unsigned int dst_pitch,
   void *vaddr, struct drm_framebuffer *fb,
   struct drm_rect *clip, bool swap);
+void drm_fb_xrgb_to_rgb888_dstclip(void *dst, unsigned int dst_pitch,
+  void *vaddr, struct drm_framebuffer *fb,
+  struct drm_rect *clip);
 void drm_fb_xrgb_to_gray8(u8 *dst, void *vaddr, struct drm_framebuffer *fb,
  struct drm_rect *clip);
 
diff --git a/drivers/gpu/drm/drm_format_helper.c 
b/drivers/gpu/drm/drm_format_helper.c
index 246775510c2e..00d716f14173 100644
--- a/drivers/gpu/drm/drm_format_helper.c
+++ b/drivers/gpu/drm/drm_format_helper.c
@@ -210,6 +210,66 @@ void drm_fb_xrgb_to_rgb565_dstclip(void *dst, unsigned 
int dst_pitch,
 }
 EXPORT_SYMBOL(drm_fb_xrgb_to_rgb565_dstclip);
 
+static void drm_fb_xrgb_to_rgb888_lines(void *dst, unsigned int dst_pitch,
+   void *src, unsigned int src_pitch,
+   unsigned int src_linelength,
+   unsigned int lines)
+{
+   unsigned int linepixels = src_linelength / 3;
+   unsigned int x, y;
+   u32 *sbuf;
+   u8 *dbuf;
+
+   sbuf = kmalloc(src_linelength, GFP_KERNEL);
+   if (!sbuf)
+   return;
+
+   for (y = 0; y < lines; y++) {
+   memcpy(sbuf, src, src_linelength);
+   dbuf = dst;
+   for (x = 0; x < linepixels; x++) {
+   *dbuf++ = (sbuf[x] & 0x00FF) >>  0;
+   *dbuf++ = (sbuf[x] & 0xFF00) >>  8;
+   *dbuf++ = (sbuf[x] & 0x00FF) >> 16;
+   }
+   src += src_pitch;
+   dst += dst_pitch;
+   }
+
+   kfree(sbuf);
+}
+
+/**
+ * drm_fb_xrgb_to_rgb888_dstclip - Convert XRGB to RGB888 clip buffer
+ * @dst: RGB565 destination buffer
+ * @dst_pitch: destination buffer pitch
+ * @vaddr: XRGB source buffer
+ * @fb: DRM framebuffer
+ * @clip: Clip rectangle area to copy
+ * @dstclip: Clip destination too.
+ *
+ * Drivers can use this function for RGB888 devices that don't natively
+ * support XRGB.
+ *
+ * This function applies clipping on dst, i.e. the destination is a
+ * full framebuffer but only the clip rect content is copied over.
+ */
+void drm_fb_xrgb_to_rgb888_dstclip(void *dst, unsigned int dst_pitch,
+  void *vaddr, struct drm_framebuffer *fb,
+  struct drm_rect *clip)
+{
+   unsigned int src_offset = (clip->y1 * fb->pitches[0])
+   + (clip->x1 * sizeof(u32));
+   unsigned int dst_offset = (clip->y1 * dst_pitch)
+   + (clip->x1 * 3);
+   size_t src_len = (clip->x2 - clip->x1) * sizeof(u32);
+
+   drm_fb_xrgb_to_rgb888_lines(dst + dst_offset, dst_pitch,
+   vaddr + src_offset, fb->pitches[0],
+   src_len, clip->y2 - clip->y1);
+}
+EXPORT_SYMBOL(drm_fb_xrgb_to_rgb888_dstclip);
+
 /**
  * drm_fb_xrgb_to_gray8 - Convert XRGB to grayscale
  * @dst: 8-bit grayscale destination buffer
-- 
2.18.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel