Re: [PATCH v3 4/7] drm/panel: simple: Add support for KEO TX31D200VM0BAA

2018-03-12 Thread Thierry Reding
On Sun, Feb 04, 2018 at 11:19:28PM +0530, Jagan Teki wrote:
> This adds support for the Kaohsiung Opto-Electronics.,
> TX31D200VM0BAA 12.3" HSXGA LVDS panel, which can be
> supported by the simple panel driver.
> 
> Signed-off-by: Jagan Teki 
> Reviewed-by: Rob Herring 
> ---
> Changes for v3:
> - collect Rob reiew tag 
> Changes for v2:
> - Updated binding info about optional properties, node and example
> 
>  .../bindings/display/panel/koe,tx31d200vm0baa.txt  | 25 
>  drivers/gpu/drm/panel/panel-simple.c   | 27 
> ++
>  2 files changed, 52 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/display/panel/koe,tx31d200vm0baa.txt

The koe vendor prefix is undocumented, please send a patch to add it to
Documentation/devicetree/bindings/vendor-prefixes.txt.

Thierry


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH v3 4/7] drm/panel: simple: Add support for KEO TX31D200VM0BAA

2018-02-04 Thread Jagan Teki
This adds support for the Kaohsiung Opto-Electronics.,
TX31D200VM0BAA 12.3" HSXGA LVDS panel, which can be
supported by the simple panel driver.

Signed-off-by: Jagan Teki 
Reviewed-by: Rob Herring 
---
Changes for v3:
- collect Rob reiew tag 
Changes for v2:
- Updated binding info about optional properties, node and example

 .../bindings/display/panel/koe,tx31d200vm0baa.txt  | 25 
 drivers/gpu/drm/panel/panel-simple.c   | 27 ++
 2 files changed, 52 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/display/panel/koe,tx31d200vm0baa.txt

diff --git 
a/Documentation/devicetree/bindings/display/panel/koe,tx31d200vm0baa.txt 
b/Documentation/devicetree/bindings/display/panel/koe,tx31d200vm0baa.txt
new file mode 100644
index 000..6a036ed
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/koe,tx31d200vm0baa.txt
@@ -0,0 +1,25 @@
+Kaohsiung Opto-Electronics. TX31D200VM0BAA 12.3" HSXGA LVDS panel
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
+
+Required properties:
+- compatible: should be "koe,tx31d200vm0baa"
+
+Optional properties:
+- backlight: phandle of the backlight device attached to the panel
+
+Optional nodes:
+- Video port for LVDS panel input.
+
+Example:
+   panel {
+   compatible = "koe,tx31d200vm0baa";
+   backlight = <&backlight_lvds>;
+
+   port {
+   panel_in: endpoint {
+   remote-endpoint = <&lvds0_out>;
+   };
+   };
+   };
diff --git a/drivers/gpu/drm/panel/panel-simple.c 
b/drivers/gpu/drm/panel/panel-simple.c
index 2ecc14b..8a0e4a8 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1241,6 +1241,30 @@ static const struct panel_desc innolux_zj070na_01p = {
},
 };
 
+static const struct display_timing koe_tx31d200vm0baa_timing = {
+   .pixelclock = { 3960, 4320, 4800 },
+   .hactive = { 1280, 1280, 1280 },
+   .hfront_porch = { 16, 36, 56 },
+   .hback_porch = { 16, 36, 56 },
+   .hsync_len = { 8, 8, 8 },
+   .vactive = { 480, 480, 480 },
+   .vfront_porch = { 6, 21, 33.5 },
+   .vback_porch = { 6, 21, 33.5 },
+   .vsync_len = { 8, 8, 8 },
+   .flags = DISPLAY_FLAGS_DE_HIGH,
+};
+
+static const struct panel_desc koe_tx31d200vm0baa = {
+   .timings = &koe_tx31d200vm0baa_timing,
+   .num_timings = 1,
+   .bpc = 6,
+   .size = {
+   .width = 292,
+   .height = 109,
+   },
+   .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
+};
+
 static const struct display_timing kyo_tcg121xglp_timing = {
.pixelclock = { 5200, 6500, 7100 },
.hactive = { 1024, 1024, 1024 },
@@ -2151,6 +2175,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "innolux,zj070na-01p",
.data = &innolux_zj070na_01p,
}, {
+   .compatible = "koe,tx31d200vm0baa",
+   .data = &koe_tx31d200vm0baa,
+   }, {
.compatible = "kyo,tcg121xglp",
.data = &kyo_tcg121xglp,
}, {
-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel