Re: [PATCH v3 4/8] drm/mediatek: add ddp component AAL1
Hi. CK: On Fri, 2018-05-25 at 12:23 +0800, CK Hu wrote: > Hi, Stu: > > On Fri, 2018-05-25 at 10:34 +0800, stu.hs...@mediatek.com wrote: > > From: Stu Hsieh> > > > This patch add component AAL1 and > > rename AAL to AAL0 > > > > Signed-off-by: Stu Hsieh > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > > b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > > index 0828cf8bf85c..eee3c0cc2632 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > > @@ -41,7 +41,8 @@ enum mtk_ddp_comp_type { > > }; > > > > enum mtk_ddp_comp_id { > > - DDP_COMPONENT_AAL, > > + DDP_COMPONENT_AAL0, > > + DDP_COMPONENT_AAL1, > > Be sure compiling is success when you apply each patch of a series. I > think when you apply to this patch, it would cause compiling error > because some related modification is in the patch 'Add support for > mediatek SOC MT2712'. So move the modification from that patch to this > patch. > > Regards, > CK I would move some modification related some component to associated patch from the patch 'Add support for mediatek SOC MT2712' Regards, Stu > > > DDP_COMPONENT_BLS, > > DDP_COMPONENT_COLOR0, > > DDP_COMPONENT_COLOR1, > > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v3 4/8] drm/mediatek: add ddp component AAL1
Hi, Stu: On Fri, 2018-05-25 at 10:34 +0800, stu.hs...@mediatek.com wrote: > From: Stu Hsieh> > This patch add component AAL1 and > rename AAL to AAL0 > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > index 0828cf8bf85c..eee3c0cc2632 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > @@ -41,7 +41,8 @@ enum mtk_ddp_comp_type { > }; > > enum mtk_ddp_comp_id { > - DDP_COMPONENT_AAL, > + DDP_COMPONENT_AAL0, > + DDP_COMPONENT_AAL1, Be sure compiling is success when you apply each patch of a series. I think when you apply to this patch, it would cause compiling error because some related modification is in the patch 'Add support for mediatek SOC MT2712'. So move the modification from that patch to this patch. Regards, CK > DDP_COMPONENT_BLS, > DDP_COMPONENT_COLOR0, > DDP_COMPONENT_COLOR1, ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v3 4/8] drm/mediatek: add ddp component AAL1
From: Stu HsiehThis patch add component AAL1 and rename AAL to AAL0 Signed-off-by: Stu Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h index 0828cf8bf85c..eee3c0cc2632 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h @@ -41,7 +41,8 @@ enum mtk_ddp_comp_type { }; enum mtk_ddp_comp_id { - DDP_COMPONENT_AAL, + DDP_COMPONENT_AAL0, + DDP_COMPONENT_AAL1, DDP_COMPONENT_BLS, DDP_COMPONENT_COLOR0, DDP_COMPONENT_COLOR1, -- 2.12.5 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel