Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186
Le mercredi 15 juin 2022 à 19:37 +0800, yunfei.d...@mediatek.com a écrit : > Hi Nicolas, > > Thanks for your comments. > On Mon, 2022-06-13 at 16:10 -0400, Nicolas Dufresne wrote: > > > > > > Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > > > Firstly, add mt8186 compatible and private data, then add document > > > for > > > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core > > > architecture, need to add new interface for h264 hardware decoder. > > > > Would be nice to take the habit of sharing fluster score for this new > > HW, I > > would expect no less then what the numbers you'd get from running > > over MT8195 or > > 92, remains nice to demonstrate that this was tested and document any > > oops along > > the way. > For we don't setup mt8186 fluster test environment. So not to run > fluster in mt8186. According to our plan, we will do fluster test for > every project begin from mt8188. > > When I'm free, we continue to setup the fluster test environment for > mt8186. I may be able to help here then if needed. Just let me know. Meanwhile, it seems a bit early to consider merging these patches as they seems to lack the level of testing we'd normally expect for non-staging driver changes. regards, Nicolas > > Thanks, > Yunfei Dong > > > Patche 1 add mt8186 compatible and private data. > > > Patche 2 add mt8186 compatible document. > > > Patche 3 add h264 single core driver. > > > --- > > > This patch depends on "support for MT8192 decoder"[1] > > > > > > [1] > > > https://patchwork.kernel.org/project/linux-mediatek/cover/20220512021950.29087-1-yunfei.d...@mediatek.com/ > > > --- > > > changed with v3: > > > - fix __iomem not reasonable, align share memory to dram. > > > changed with v2: > > > - fix sparse and smatch check fail for patch 3 > > > changed with v1: > > > - rebase driver to the latest media_stage. > > > --- > > > Yunfei Dong (3): > > > dt-bindings: media: mediatek: vcodec: Adds decoder dt-bindings > > > for > > > mt8186 > > > media: mediatek: vcodec: Support MT8186 > > > media: mediatek: vcodec: add h264 decoder driver for mt8186 > > > > > > .../media/mediatek,vcodec-subdev-decoder.yaml | 4 +- > > > .../platform/mediatek/vcodec/mtk_vcodec_dec.h | 1 + > > > .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 + > > > .../vcodec/mtk_vcodec_dec_stateless.c | 19 ++ > > > .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 > > > +- > > > 5 files changed, 203 insertions(+), 2 deletions(-) > > > > > > > >
Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186
Le lundi 13 juin 2022 à 16:10 -0400, Nicolas Dufresne a écrit : > Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > > Firstly, add mt8186 compatible and private data, then add document for > > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core > > architecture, need to add new interface for h264 hardware decoder. > > Would be nice to take the habit of sharing fluster score for this new HW, I > would expect no less then what the numbers you'd get from running over MT8195 > or > 92, remains nice to demonstrate that this was tested and document any oops > along > the way. > > > > Patche 1 add mt8186 compatible and private data. > > Patche 2 add mt8186 compatible document. > > Patche 3 add h264 single core driver. > > --- > > This patch depends on "support for MT8192 decoder"[1] > > > > [1] > > https://patchwork.kernel.org/project/linux-mediatek/cover/20220512021950.29087-1-yunfei.d...@mediatek.com/ I forgot earlier, but I suppose this will also depends on an scp.img firmware ? If so, any linux-firmware submission to link to ? > > --- > > changed with v3: > > - fix __iomem not reasonable, align share memory to dram. > > changed with v2: > > - fix sparse and smatch check fail for patch 3 > > changed with v1: > > - rebase driver to the latest media_stage. > > --- > > Yunfei Dong (3): > > dt-bindings: media: mediatek: vcodec: Adds decoder dt-bindings for > > mt8186 > > media: mediatek: vcodec: Support MT8186 > > media: mediatek: vcodec: add h264 decoder driver for mt8186 > > > > .../media/mediatek,vcodec-subdev-decoder.yaml | 4 +- > > .../platform/mediatek/vcodec/mtk_vcodec_dec.h | 1 + > > .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 + > > .../vcodec/mtk_vcodec_dec_stateless.c | 19 ++ > > .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 +- > > 5 files changed, 203 insertions(+), 2 deletions(-) > > >
Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186
Le jeudi 12 mai 2022 à 11:46 +0800, Yunfei Dong a écrit : > Firstly, add mt8186 compatible and private data, then add document for > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core > architecture, need to add new interface for h264 hardware decoder. Would be nice to take the habit of sharing fluster score for this new HW, I would expect no less then what the numbers you'd get from running over MT8195 or 92, remains nice to demonstrate that this was tested and document any oops along the way. > > Patche 1 add mt8186 compatible and private data. > Patche 2 add mt8186 compatible document. > Patche 3 add h264 single core driver. > --- > This patch depends on "support for MT8192 decoder"[1] > > [1] > https://patchwork.kernel.org/project/linux-mediatek/cover/20220512021950.29087-1-yunfei.d...@mediatek.com/ > --- > changed with v3: > - fix __iomem not reasonable, align share memory to dram. > changed with v2: > - fix sparse and smatch check fail for patch 3 > changed with v1: > - rebase driver to the latest media_stage. > --- > Yunfei Dong (3): > dt-bindings: media: mediatek: vcodec: Adds decoder dt-bindings for > mt8186 > media: mediatek: vcodec: Support MT8186 > media: mediatek: vcodec: add h264 decoder driver for mt8186 > > .../media/mediatek,vcodec-subdev-decoder.yaml | 4 +- > .../platform/mediatek/vcodec/mtk_vcodec_dec.h | 1 + > .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 + > .../vcodec/mtk_vcodec_dec_stateless.c | 19 ++ > .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 +- > 5 files changed, 203 insertions(+), 2 deletions(-) >
