Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

[Laurent Pinchart]

Hi Heiko,

On Monday, 4 December 2017 15:46:32 EET Heiko Stuebner wrote:
> Am Montag, 4. Dezember 2017, 15:22:07 CET schrieb Laurent Pinchart:
> > On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> > > From: Nickey Yang 
> > > 
> > > We might include additional ports in derivative device trees, so the
> > > 'port' node should have an address, and the parent 'ports' node needs
> > > /#{addres,size}-cells.
> > > 
> > > v4:
> > >  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
> > >  * separate from the rest of the series, since this is mostly
> > >  
> > >independent of the driver refactoring
> > > 
> > > Signed-off-by: Nickey Yang 
> > > Signed-off-by: Brian Norris 
> > 
> > Reviewed-by: Laurent Pinchart 
> 
> As I hadn't pushed that one yet, I've amended it with your Review-tag :-)

Thank you :-)

-- 
Regards,

Laurent Pinchart

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

[Heiko Stuebner]

Hi Laurent,

Am Montag, 4. Dezember 2017, 15:22:07 CET schrieb Laurent Pinchart:
> On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> > From: Nickey Yang 
> > 
> > We might include additional ports in derivative device trees, so the
> > 'port' node should have an address, and the parent 'ports' node needs
> > /#{addres,size}-cells.
> > 
> > v4:
> >  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
> >  * separate from the rest of the series, since this is mostly
> >independent of the driver refactoring
> > 
> > Signed-off-by: Nickey Yang 
> > Signed-off-by: Brian Norris 
> 
> Reviewed-by: Laurent Pinchart 

As I hadn't pushed that one yet, I've amended it with your Review-tag :-)

Thanks
Heiko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

[Laurent Pinchart]

Hi Nickey,

Thank you for the patch.

On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> From: Nickey Yang 
> 
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
> 
> v4:
>  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
>  * separate from the rest of the series, since this is mostly
>independent of the driver refactoring
> 
> Signed-off-by: Nickey Yang 
> Signed-off-by: Brian Norris 

Reviewed-by: Laurent Pinchart 

> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index d340b58ab184..c6dae25a3f23
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1652,7 +1652,11 @@
>   status = "disabled";
> 
>   ports {
> - mipi_in: port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mipi_in: port@0 {
> + reg = <0>;
>   #address-cells = <1>;
>   #size-cells = <0>;


-- 
Regards,

Laurent Pinchart

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

[Heiko Stuebner]

Am Mittwoch, 29. November 2017, 10:47:55 CET schrieb Brian Norris:
> From: Nickey Yang 
> 
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
> 
> v4:
>  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
>  * separate from the rest of the series, since this is mostly
>independent of the driver refactoring
> 
> Signed-off-by: Nickey Yang 
> Signed-off-by: Brian Norris 

applied for 4.16 with Doug's Review

Thanks
Heiko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

[Doug Anderson]

Hi,

On Wed, Nov 29, 2017 at 10:47 AM, Brian Norris  wrote:
> From: Nickey Yang 
>
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
>
> v4:
>  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
>  * separate from the rest of the series, since this is mostly
>independent of the driver refactoring
>
> Signed-off-by: Nickey Yang 
> Signed-off-by: Brian Norris 
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)

This seems sane to me according to my current understanding and
reading of the bindings.

Reviewed-by: Douglas Anderson 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

[Brian Norris]

From: Nickey Yang 

We might include additional ports in derivative device trees, so the
'port' node should have an address, and the parent 'ports' node needs
/#{addres,size}-cells.

v4:
 * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
 * separate from the rest of the series, since this is mostly
   independent of the driver refactoring

Signed-off-by: Nickey Yang 
Signed-off-by: Brian Norris 
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi 
b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index d340b58ab184..c6dae25a3f23 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1652,7 +1652,11 @@
status = "disabled";
 
ports {
-   mipi_in: port {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   mipi_in: port@0 {
+   reg = <0>;
#address-cells = <1>;
#size-cells = <0>;
 
-- 
2.15.0.531.g2ccb3012c9-goog

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel