Re: [PATCH v4 0/6] SimpleDRM Driver
Hi David, On Wed, Sep 4, 2013 at 7:34 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Sun, Sep 1, 2013 at 3:36 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi With the upcoming 3.12 merge-window, I thought people might find themselves with nothing to do, so here's a new SimpleDRM series. Comments welcome! This depends on the tip/x86/fb series in the x86-tip tree: http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/log/?h=x86/fb Which, as far as I understood, will be pushed into 3.12 by the x86 people. FYI, this is now merged in Linus' tree. See: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=228abe73ad67665d71eacd6a8a347dd76b0115ae So hopefully we can get SimpleDRM ready for 3.13. Now that simplefb works for me, I finally got around to testing this. Just a couple of comments: * I guess you need to add the modalias platform:simple-framebuffer in addition to the of:... one to get module auto loading working. * the driver currently doesn't work with your IORESOURCE_BUSY fix to sysfb (as might be expected(?)): simple-framebuffer simple-framebuffer.0: cannot reserve VMEM simple-framebuffer: probe of simple-framebuffer.0 failed with error -5 * except for that, fbcon on top of the fbdev fallback support works fine for me. I didn't yet try the drm driver itself, what clients (if any) are supposed to work with this, kmscon, weston? Cheers, Tom ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4 0/6] SimpleDRM Driver
Hi On Sun, Sep 8, 2013 at 1:33 PM, Tom Gundersen t...@jklm.no wrote: Hi David, On Wed, Sep 4, 2013 at 7:34 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Sun, Sep 1, 2013 at 3:36 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi With the upcoming 3.12 merge-window, I thought people might find themselves with nothing to do, so here's a new SimpleDRM series. Comments welcome! This depends on the tip/x86/fb series in the x86-tip tree: http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/log/?h=x86/fb Which, as far as I understood, will be pushed into 3.12 by the x86 people. FYI, this is now merged in Linus' tree. See: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=228abe73ad67665d71eacd6a8a347dd76b0115ae So hopefully we can get SimpleDRM ready for 3.13. Now that simplefb works for me, I finally got around to testing this. Just a couple of comments: * I guess you need to add the modalias platform:simple-framebuffer in addition to the of:... one to get module auto loading working. Yes, sounds good. * the driver currently doesn't work with your IORESOURCE_BUSY fix to sysfb (as might be expected(?)): simple-framebuffer simple-framebuffer.0: cannot reserve VMEM simple-framebuffer: probe of simple-framebuffer.0 failed with error -5 Yes, if the simple-framebuffer region is already marked BUSY, simpleDRM must not (and doesn't have to) call __request_region() (or request_mem_region()). I have to remove that call if the BUSY fix gets applied. * except for that, fbcon on top of the fbdev fallback support works fine for me. I didn't yet try the drm driver itself, what clients (if any) are supposed to work with this, kmscon, weston? Obviously, simpledrm doesn't support double-buffering, page-flipping or other advanced techniques. So I currently doubt you can use any real application on it as they all at least require 2 buffers. I haven't decided whether to emulate these in the kernel driver or to rely on user-space to deal with this reduced driver. It's quite likely I will go with both. That means, a compatibility option that makes simpledrm emulate any required techniques (multiple FBs, page-flipping) but also user-space patches to maybe some day be able to disable the kernel emulation. Thanks a lot for testing all this. I will try to get the fixes into rc2. The speed-improvements might have to wait for 3.13, though. Cheers David ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4 0/6] SimpleDRM Driver
Hi On Sun, Sep 1, 2013 at 3:36 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi With the upcoming 3.12 merge-window, I thought people might find themselves with nothing to do, so here's a new SimpleDRM series. Comments welcome! This depends on the tip/x86/fb series in the x86-tip tree: http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/log/?h=x86/fb Which, as far as I understood, will be pushed into 3.12 by the x86 people. FYI, this is now merged in Linus' tree. See: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=228abe73ad67665d71eacd6a8a347dd76b0115ae So hopefully we can get SimpleDRM ready for 3.13. Cheers David ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v4 0/6] SimpleDRM Driver
Hi With the upcoming 3.12 merge-window, I thought people might find themselves with nothing to do, so here's a new SimpleDRM series. Comments welcome! This depends on the tip/x86/fb series in the x86-tip tree: http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/log/?h=x86/fb Which, as far as I understood, will be pushed into 3.12 by the x86 people. Patches #1 and #2 implement the SimpleDRM driver which can replace vesafb, efifb, simplefb, vgafb and more. Just enable the CONFIG_X86_SYSFB option and you're good to go. Patches #3 to #6 implement drm_kick_out_firmware() to make x86 drivers kick out firmware-DRM drivers instead of only fbdev via remove_conflicting_framebuffers(). I tested this based on drm-next plus the x86/fb series merged with i915 and nouveau and it worked just fine. Regards David David Herrmann (6): drm: add SimpleDRM driver drm: simpledrm: add fbdev fallback support drm: add helpers to kick out firmware drivers drm: nouveau: kick out firmware drivers during probe drm/i915: use new drm_kick_out_firmware() drm/radeon: use new drm_kick_out_firmware() MAINTAINERS | 8 + drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/drm_pci.c | 1 + drivers/gpu/drm/drm_platform.c | 1 + drivers/gpu/drm/drm_stub.c | 118 + drivers/gpu/drm/drm_usb.c | 1 + drivers/gpu/drm/i915/i915_dma.c | 6 +- drivers/gpu/drm/nouveau/nouveau_drm.c | 29 ++- drivers/gpu/drm/radeon/radeon_drv.c | 28 --- drivers/gpu/drm/radeon/radeon_kms.c | 30 +++ drivers/gpu/drm/simpledrm/Kconfig | 29 +++ drivers/gpu/drm/simpledrm/Makefile | 4 + drivers/gpu/drm/simpledrm/simpledrm.h | 112 + drivers/gpu/drm/simpledrm/simpledrm_drv.c | 226 + drivers/gpu/drm/simpledrm/simpledrm_fbdev.c | 153 drivers/gpu/drm/simpledrm/simpledrm_main.c | 363 drivers/gpu/drm/simpledrm/simpledrm_mem.c | 242 +++ include/drm/drmP.h | 26 ++ 19 files changed, 1342 insertions(+), 38 deletions(-) create mode 100644 drivers/gpu/drm/simpledrm/Kconfig create mode 100644 drivers/gpu/drm/simpledrm/Makefile create mode 100644 drivers/gpu/drm/simpledrm/simpledrm.h create mode 100644 drivers/gpu/drm/simpledrm/simpledrm_drv.c create mode 100644 drivers/gpu/drm/simpledrm/simpledrm_fbdev.c create mode 100644 drivers/gpu/drm/simpledrm/simpledrm_main.c create mode 100644 drivers/gpu/drm/simpledrm/simpledrm_mem.c -- 1.8.4 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
