Re: [PATCH v4 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

[Krzysztof Kozlowski]

On 26/04/2024 19:22, Alexandre Mergnat wrote:
>regulators:
>  type: object
>  $ref: /schemas/regulator/mediatek,mt6357-regulator.yaml
> @@ -83,6 +111,12 @@ examples:
>  interrupt-controller;
>  #interrupt-cells = <2>;
>  
> +audio-codec {
> +mediatek,micbias0-microvolt = <170>;
> +mediatek,micbias1-microvolt = <170>;
> +vaud28-supply = <_vaud28_reg>;

And now you should see how odd it looks. Supplies are part of entire
chip, not subblock, even if they supply dedicated domain within that chip.

That's why I asked to put it in the parent node.

Best regards,
Krzysztof

[PATCH v4 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

[Alexandre Mergnat]

Add the audio codec sub-device. This sub-device is used to set required
and optional voltage needed according to the hardware.
The properties are:
  - phandle of the required power supply.
  - Setup of microphone bias voltage.
  - Setup of the speaker pin pull-down.

Signed-off-by: Alexandre Mergnat 
---
 .../devicetree/bindings/mfd/mediatek,mt6357.yaml   | 34 ++
 1 file changed, 34 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml 
b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml
index 37423c2e0fdf..30234f13a810 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml
@@ -37,6 +37,34 @@ properties:
   "#interrupt-cells":
 const: 2
 
+  audio-codec:
+type: object
+properties:
+  vaud28-supply:
+description: 2.8 volt supply phandle for the audio codec
+
+  mediatek,hp-pull-down:
+description:
+  Earphone driver positive output stage short to
+  the audio reference ground.
+type: boolean
+
+  mediatek,micbias0-microvolt:
+description: Selects MIC Bias 0 output voltage.
+enum: [170, 180, 190, 200,
+   210, 250, 260, 270]
+default: 170
+
+  mediatek,micbias1-microvolt:
+description: Selects MIC Bias 1 output voltage.
+enum: [170, 180, 190, 200,
+   210, 250, 260, 270]
+default: 170
+
+required:
+  - vaud28-supply
+unevaluatedProperties: false
+
   regulators:
 type: object
 $ref: /schemas/regulator/mediatek,mt6357-regulator.yaml
@@ -83,6 +111,12 @@ examples:
 interrupt-controller;
 #interrupt-cells = <2>;
 
+audio-codec {
+mediatek,micbias0-microvolt = <170>;
+mediatek,micbias1-microvolt = <170>;
+vaud28-supply = <_vaud28_reg>;
+};
+
 regulators {
 mt6357_vproc_reg: buck-vproc {
 regulator-name = "vproc";

-- 
2.25.1