Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

[Frank Binns]

Hi Krzysztof,

On Tue, 2023-07-18 at 08:19 +0200, Krzysztof Kozlowski wrote:
> On 14/07/2023 16:30, Sarah Walker wrote:
> > Add the Series AXE GPU node to the AM62 device tree.
> > 
> > Signed-off-by: Sarah Walker 
> > ---
> >  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi 
> > b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index b3e4857bbbe4..ad13414acf18 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -892,4 +892,17 @@ mcasp2: audio-controller@2b2 {
> > power-domains = <_pds 192 TI_SCI_PD_EXCLUSIVE>;
> > status = "disabled";
> > };
> > +
> > +gpu: gpu@fd0 {
> > +compatible = "ti,am62-gpu", "img,powervr-seriesaxe";
> > +reg = <0 0x0fd0 0 0x2>;
> > +power-domains = <_pds 187 TI_SCI_PD_EXCLUSIVE>;
> > +clocks = <_clks 187 0>;
> > +clock-names = "core";
> > +interrupts = ;
> > +interrupt-names = "gpu";
> > +#cooling-cells = <2>;
> > +#cooling-min-level = <0>;
> > +#cooling-max-level = <3>;
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).

Thank you for the tip. I'll have a read through.

Frank

> 
> Best regards,
> Krzysztof
> 

Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

[Krzysztof Kozlowski]

On 14/07/2023 16:30, Sarah Walker wrote:
> Add the Series AXE GPU node to the AM62 device tree.
> 
> Signed-off-by: Sarah Walker 
> ---
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi 
> b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index b3e4857bbbe4..ad13414acf18 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -892,4 +892,17 @@ mcasp2: audio-controller@2b2 {
>   power-domains = <_pds 192 TI_SCI_PD_EXCLUSIVE>;
>   status = "disabled";
>   };
> +
> +gpu: gpu@fd0 {
> +compatible = "ti,am62-gpu", "img,powervr-seriesaxe";
> +reg = <0 0x0fd0 0 0x2>;
> +power-domains = <_pds 187 TI_SCI_PD_EXCLUSIVE>;
> +clocks = <_clks 187 0>;
> +clock-names = "core";
> +interrupts = ;
> +interrupt-names = "gpu";
> +#cooling-cells = <2>;
> +#cooling-min-level = <0>;
> +#cooling-max-level = <3>;

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Best regards,
Krzysztof

Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

[Maxime Ripard]

Hi,

On Fri, Jul 14, 2023 at 03:30:33PM +0100, Sarah Walker wrote:
> Add the Series AXE GPU node to the AM62 device tree.
> 
> Signed-off-by: Sarah Walker 

Checkpatch complains about that one because you indented the node with
spaces instead of tabs.

Once fixed:
Reviewed-by: Maxime Ripard 

Maxime


signature.asc
Description: PGP signature

[PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

[Sarah Walker]

Add the Series AXE GPU node to the AM62 device tree.

Signed-off-by: Sarah Walker 
---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi 
b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index b3e4857bbbe4..ad13414acf18 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -892,4 +892,17 @@ mcasp2: audio-controller@2b2 {
power-domains = <_pds 192 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};
+
+gpu: gpu@fd0 {
+compatible = "ti,am62-gpu", "img,powervr-seriesaxe";
+reg = <0 0x0fd0 0 0x2>;
+power-domains = <_pds 187 TI_SCI_PD_EXCLUSIVE>;
+clocks = <_clks 187 0>;
+clock-names = "core";
+interrupts = ;
+interrupt-names = "gpu";
+#cooling-cells = <2>;
+#cooling-min-level = <0>;
+#cooling-max-level = <3>;
+};
 };
-- 
2.41.0