Re: [PATCH v5 0/3] Allow ASYNC flip with atomic helpers.

[Edward O'Callaghan]

Reviewed-by: Edward O'Callaghan 

On 02/04/2017 04:46 AM, Alex Deucher wrote:
> On Thu, Feb 2, 2017 at 4:56 PM, Andrey Grodzovsky
>  wrote:
>> This series is a folow-up on
>> https://patchwork.kernel.org/patch/9501787/
>>
>> The first patch makes changes to atomic helpers to allow for drives with 
>> ASYNC flip support to use them.
>> Patch 2 is to use this in AMDGPU/DC.
>> Patch 3 is possible cleanup in nouveau/kms who seems to have to duplicate 
>> the helper as we did to support ASYNC flips.
>>
>> v2:
>> Resend drm/atomic: Save flip flags in drm_plane_state since the original 
>> patch was incomplete.
>> Squash 2 AMD changes into one to not break compilation.
>>
>> v3:
>> Following Daniel's comments, save flip flags in crtc_state instead of 
>> plane_state.
>>
>> v4:
>> Lauren's comment, reset flp flags before using again.
>> Harry's comment, fix identation in amd/display.
>>
>> v5:
>> Rename the flag, fix typo in header.
> 
> Looks good.  The series is:
> Reviewed-by: Alex Deucher 
> Unless there are any objections I'll push to drm-misc today.
> 
> Thanks!
> 
> Alex
> 
>>
>> Andrey Grodzovsky (3):
>>   drm/atomic: Save flip flags in drm_crtc_state
>>   drm/nouveau/kms/nv50: Switch to using atomic helper for flip.
>>   drm/amd/display: Switch to using atomic_helper for flip.
>>
>>  drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h   |   1 -
>>  .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.c| 113 
>> +
>>  drivers/gpu/drm/drm_atomic_helper.c|  20 ++--
>>  drivers/gpu/drm/nouveau/nv50_display.c |  84 ++-
>>  include/drm/drm_crtc.h |   9 +-
>>  5 files changed, 48 insertions(+), 179 deletions(-)
>>
>> --
>> 1.9.1
>>
>> ___
>> amd-gfx mailing list
>> amd-...@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> ___
> amd-gfx mailing list
> amd-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 



signature.asc
Description: OpenPGP digital signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 0/3] Allow ASYNC flip with atomic helpers.

[Alex Deucher]

On Thu, Feb 2, 2017 at 4:56 PM, Andrey Grodzovsky
 wrote:
> This series is a folow-up on
> https://patchwork.kernel.org/patch/9501787/
>
> The first patch makes changes to atomic helpers to allow for drives with 
> ASYNC flip support to use them.
> Patch 2 is to use this in AMDGPU/DC.
> Patch 3 is possible cleanup in nouveau/kms who seems to have to duplicate the 
> helper as we did to support ASYNC flips.
>
> v2:
> Resend drm/atomic: Save flip flags in drm_plane_state since the original 
> patch was incomplete.
> Squash 2 AMD changes into one to not break compilation.
>
> v3:
> Following Daniel's comments, save flip flags in crtc_state instead of 
> plane_state.
>
> v4:
> Lauren's comment, reset flp flags before using again.
> Harry's comment, fix identation in amd/display.
>
> v5:
> Rename the flag, fix typo in header.

Looks good.  The series is:
Reviewed-by: Alex Deucher 
Unless there are any objections I'll push to drm-misc today.

Thanks!

Alex

>
> Andrey Grodzovsky (3):
>   drm/atomic: Save flip flags in drm_crtc_state
>   drm/nouveau/kms/nv50: Switch to using atomic helper for flip.
>   drm/amd/display: Switch to using atomic_helper for flip.
>
>  drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h   |   1 -
>  .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.c| 113 
> +
>  drivers/gpu/drm/drm_atomic_helper.c|  20 ++--
>  drivers/gpu/drm/nouveau/nv50_display.c |  84 ++-
>  include/drm/drm_crtc.h |   9 +-
>  5 files changed, 48 insertions(+), 179 deletions(-)
>
> --
> 1.9.1
>
> ___
> amd-gfx mailing list
> amd-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v5 0/3] Allow ASYNC flip with atomic helpers.

[Andrey Grodzovsky]

This series is a folow-up on
https://patchwork.kernel.org/patch/9501787/

The first patch makes changes to atomic helpers to allow for drives with ASYNC 
flip support to use them.
Patch 2 is to use this in AMDGPU/DC.
Patch 3 is possible cleanup in nouveau/kms who seems to have to duplicate the 
helper as we did to support ASYNC flips. 

v2: 
Resend drm/atomic: Save flip flags in drm_plane_state since the original patch 
was incomplete.
Squash 2 AMD changes into one to not break compilation.

v3:
Following Daniel's comments, save flip flags in crtc_state instead of 
plane_state.

v4:
Lauren's comment, reset flp flags before using again.
Harry's comment, fix identation in amd/display.

v5:
Rename the flag, fix typo in header.

Andrey Grodzovsky (3):
  drm/atomic: Save flip flags in drm_crtc_state
  drm/nouveau/kms/nv50: Switch to using atomic helper for flip.
  drm/amd/display: Switch to using atomic_helper for flip.

 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h   |   1 -
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.c| 113 +
 drivers/gpu/drm/drm_atomic_helper.c|  20 ++--
 drivers/gpu/drm/nouveau/nv50_display.c |  84 ++-
 include/drm/drm_crtc.h |   9 +-
 5 files changed, 48 insertions(+), 179 deletions(-)

-- 
1.9.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel