Re: [PATCH v5 1/8] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation
Hi Jacopo,
On Tue, Oct 15, 2019 at 12:44 PM Jacopo Mondi wrote:
> Add device tree bindings documentation for the Renesas R-Car Display
> Unit Color Management Module.
>
> CMM is the image enhancement module available on each R-Car DU video
> channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded).
V2H is excluded, too.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH v5 1/8] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation
Hi Jacopo,
On 15/10/2019 11:46, Jacopo Mondi wrote:
> Add device tree bindings documentation for the Renesas R-Car Display
> Unit Color Management Module.
>
> CMM is the image enhancement module available on each R-Car DU video
> channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded).
>
LGTM. Good to see how we get started with the new yaml bindings. I guess
we've got plenty of conversion work to do there ..
Reviewed-by: Kieran Bingham
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Jacopo Mondi
> ---
> .../bindings/display/renesas,cmm.yaml | 67 +++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/renesas,cmm.yaml
> b/Documentation/devicetree/bindings/display/renesas,cmm.yaml
> new file mode 100644
> index ..a57037b9e9ba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/renesas,cmm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R-Car Color Management Module (CMM)
> +
> +maintainers:
> + - Laurent Pinchart
> + - Kieran Bingham
> + - Jacopo Mondi
> +
> +description: |+
> + Renesas R-Car color management module connected to R-Car DU video channels.
> + It provides image enhancement functions such as 1-D look-up tables (LUT),
> + 3-D look-up tables (CLU), 1D-histogram generation (HGO), and color
> + space conversion (CSC).
> +
> +properties:
> + compatible:
> +oneOf:
> + - items:
> +- enum:
> + - renesas,r8a7795-cmm
> + - renesas,r8a7796-cmm
> + - renesas,r8a77965-cmm
> + - renesas,r8a77990-cmm
> + - renesas,r8a77995-cmm
> +- const: renesas,rcar-gen3-cmm
> + - items:
> +- const: renesas,rcar-gen2-cmm
> +
> + reg:
> +maxItems: 1
> +
> + clocks:
> +maxItems: 1
> +
> + resets:
> +maxItems: 1
> +
> + power-domains:
> +maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - resets
> + - power-domains
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +#include
> +#include
> +
> +cmm0: cmm@fea4 {
> + compatible = "renesas,r8a7796-cmm",
> + "renesas,rcar-gen3-cmm";
> + reg = <0 0xfea4 0 0x1000>;
> + power-domains = < R8A7796_PD_ALWAYS_ON>;
> + clocks = < CPG_MOD 711>;
> + resets = < 711>;
> +};
> --
> 2.23.0
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v5 1/8] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation
Add device tree bindings documentation for the Renesas R-Car Display
Unit Color Management Module.
CMM is the image enhancement module available on each R-Car DU video
channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded).
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
.../bindings/display/renesas,cmm.yaml | 67 +++
1 file changed, 67 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.yaml
diff --git a/Documentation/devicetree/bindings/display/renesas,cmm.yaml
b/Documentation/devicetree/bindings/display/renesas,cmm.yaml
new file mode 100644
index ..a57037b9e9ba
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/renesas,cmm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas R-Car Color Management Module (CMM)
+
+maintainers:
+ - Laurent Pinchart
+ - Kieran Bingham
+ - Jacopo Mondi
+
+description: |+
+ Renesas R-Car color management module connected to R-Car DU video channels.
+ It provides image enhancement functions such as 1-D look-up tables (LUT),
+ 3-D look-up tables (CLU), 1D-histogram generation (HGO), and color
+ space conversion (CSC).
+
+properties:
+ compatible:
+oneOf:
+ - items:
+- enum:
+ - renesas,r8a7795-cmm
+ - renesas,r8a7796-cmm
+ - renesas,r8a77965-cmm
+ - renesas,r8a77990-cmm
+ - renesas,r8a77995-cmm
+- const: renesas,rcar-gen3-cmm
+ - items:
+- const: renesas,rcar-gen2-cmm
+
+ reg:
+maxItems: 1
+
+ clocks:
+maxItems: 1
+
+ resets:
+maxItems: 1
+
+ power-domains:
+maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - resets
+ - power-domains
+
+additionalProperties: false
+
+examples:
+ - |
+#include
+#include
+
+cmm0: cmm@fea4 {
+ compatible = "renesas,r8a7796-cmm",
+ "renesas,rcar-gen3-cmm";
+ reg = <0 0xfea4 0 0x1000>;
+ power-domains = < R8A7796_PD_ALWAYS_ON>;
+ clocks = < CPG_MOD 711>;
+ resets = < 711>;
+};
--
2.23.0
