Re: [PATCH v5 22/22] checkpatch: reword long-line warn about commit-msg

[Joe Perches]

On Tue, 2023-08-01 at 17:35 -0600, Jim Cromie wrote:
> Reword the warning to complain about line length 1st, since thats
> whats actually tested.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3272,7 +3272,7 @@ sub process {
>   # A Fixes:, link or signature tag line
> $commit_log_possible_stack_dump)) {
>   WARN("COMMIT_LOG_LONG_LINE",
> -  "Possible unwrapped commit description (prefer a 
> maximum 75 chars per line)\n" . $herecurr);
> +  "Prefer a maximum 75 chars per line (possible 
> unwrapped commit description?)\n" . $herecurr);
>   $commit_log_long_line = 1;
>   }

I don't think this adds any clarity.  Anyone else? 

[PATCH v5 22/22] checkpatch: reword long-line warn about commit-msg

[Jim Cromie]

Reword the warning to complain about line length 1st, since thats
whats actually tested.

Cc: a...@canonical.com
Cc: j...@perches.com
Signed-off-by: Jim Cromie 
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f6b6b2a50dfe..31c55e3ece09 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3272,7 +3272,7 @@ sub process {
# A Fixes:, link or signature tag line
  $commit_log_possible_stack_dump)) {
WARN("COMMIT_LOG_LONG_LINE",
-"Possible unwrapped commit description (prefer a 
maximum 75 chars per line)\n" . $herecurr);
+"Prefer a maximum 75 chars per line (possible 
unwrapped commit description?)\n" . $herecurr);
$commit_log_long_line = 1;
}
 
-- 
2.41.0

[PATCH v5 22/22] checkpatch: reword long-line warn about commit-msg

[Jim Cromie]

Reword the warning to complain about line length 1st, since thats
whats actually tested.

Cc: a...@canonical.com
Cc: j...@perches.com
Signed-off-by: Jim Cromie 
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f6b6b2a50dfe..31c55e3ece09 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3272,7 +3272,7 @@ sub process {
# A Fixes:, link or signature tag line
  $commit_log_possible_stack_dump)) {
WARN("COMMIT_LOG_LONG_LINE",
-"Possible unwrapped commit description (prefer a 
maximum 75 chars per line)\n" . $herecurr);
+"Prefer a maximum 75 chars per line (possible 
unwrapped commit description?)\n" . $herecurr);
$commit_log_long_line = 1;
}
 
-- 
2.41.0