[PATCH v5 3/4] drm/bridge: Add ti-tfp410 DVI transmitter driver

2016-11-29 Thread Jyri Sarha
On 11/29/16 22:26, Laurent Pinchart wrote:
> Hi Jyri,
> 
> On Tuesday 29 Nov 2016 22:18:25 Jyri Sarha wrote:
>> > The module unload should not be allowed while the bridge is attached. So
>> > still need to add these:
>> > 
>> > On 11/25/16 11:02, Jyri Sarha wrote:
>>> > > +
>>> > > +static int tfp410_attach(struct drm_bridge *bridge)
>>> > > +{
>>> > > +   struct tfp410 *dvi = drm_bridge_to_tfp410(bridge);
>>> > > +   int ret;
>>> > > +
>> > 
>> > +   if (!try_module_get(THIS_MODULE)) {
>> > +   dev_err(dvi->dev, "Module unloading\n");
>> > +   return -ENODEV;
>> > +   }
>> > +
> Shouldn't this be done in core code ?
> 

Hmmm, probably. I'll send a patch shortly.

Cheers,
Jyri


[PATCH v5 3/4] drm/bridge: Add ti-tfp410 DVI transmitter driver

2016-11-29 Thread Laurent Pinchart
Hi Jyri,

On Tuesday 29 Nov 2016 22:18:25 Jyri Sarha wrote:
> The module unload should not be allowed while the bridge is attached. So
> still need to add these:
> 
> On 11/25/16 11:02, Jyri Sarha wrote:
> > +
> > +static int tfp410_attach(struct drm_bridge *bridge)
> > +{
> > +   struct tfp410 *dvi = drm_bridge_to_tfp410(bridge);
> > +   int ret;
> > +
> 
> +   if (!try_module_get(THIS_MODULE)) {
> +   dev_err(dvi->dev, "Module unloading\n");
> +   return -ENODEV;
> +   }
> +

Shouldn't this be done in core code ?

> > +   if (!bridge->encoder) {
> > +   dev_err(dvi->dev, "Missing encoder\n");
> > +   return -ENODEV;
> > +   }
> > +
> > +   drm_connector_helper_add(>connector,
> > +_con_helper_funcs);
> > +   ret = drm_connector_init(bridge->dev, >connector,
> > +_con_funcs, DRM_MODE_CONNECTOR_HDMIA);
> > +   if (ret) {
> > +   dev_err(dvi->dev, "drm_connector_init() failed: %d\n", ret);
> > +   return ret;
> > +   }
> > +
> > +   drm_mode_connector_attach_encoder(>connector,
> > + bridge->encoder);
> > +
> > +   return 0;
> > +}
> 
> +static void tfp410_detach(struct drm_bridge *bridge)
> +{
> +   module_put(THIS_MODULE);
> +}
> +
> 
> > +
> > +static const struct drm_bridge_funcs tfp410_bridge_funcs = {
> > +   .attach = tfp410_attach,
> 
> +   .detach = tfp410_detach,
> 
> > +};
> > +

-- 
Regards,

Laurent Pinchart



[PATCH v5 3/4] drm/bridge: Add ti-tfp410 DVI transmitter driver

2016-11-29 Thread Jyri Sarha
The module unload should not be allowed while the bridge is attached. So
still need to add these:

On 11/25/16 11:02, Jyri Sarha wrote:
> +
> +static int tfp410_attach(struct drm_bridge *bridge)
> +{
> + struct tfp410 *dvi = drm_bridge_to_tfp410(bridge);
> + int ret;
> +


+   if (!try_module_get(THIS_MODULE)) {
+   dev_err(dvi->dev, "Module unloading\n");
+   return -ENODEV;
+   }
+


> + if (!bridge->encoder) {
> + dev_err(dvi->dev, "Missing encoder\n");
> + return -ENODEV;
> + }
> +
> + drm_connector_helper_add(>connector,
> +  _con_helper_funcs);
> + ret = drm_connector_init(bridge->dev, >connector,
> +  _con_funcs, DRM_MODE_CONNECTOR_HDMIA);
> + if (ret) {
> + dev_err(dvi->dev, "drm_connector_init() failed: %d\n", ret);
> + return ret;
> + }
> +
> + drm_mode_connector_attach_encoder(>connector,
> +   bridge->encoder);
> +
> + return 0;
> +}

+static void tfp410_detach(struct drm_bridge *bridge)
+{
+   module_put(THIS_MODULE);
+}
+

> +
> +static const struct drm_bridge_funcs tfp410_bridge_funcs = {
> + .attach = tfp410_attach,

+   .detach = tfp410_detach,

> +};
> +



[PATCH v5 3/4] drm/bridge: Add ti-tfp410 DVI transmitter driver

2016-11-25 Thread Jyri Sarha
Add very basic ti-tfp410 DVI transmitter driver. The only feature
separating this from a completely dummy bridge is the EDID read
support trough DDC I2C. Even that functionality should be in a
separate generic connector driver. However, because of missing DRM
infrastructure support the connector is implemented within the bridge
driver. Some tfp410 HW specific features may be added later if needed,
because there is a set of registers behind i2c if it is connected.

This implementation is tested against my new tilcdc bridge support
and it works with BeagleBone DVI-D Cape Rev A3. A DT binding document
is also updated.

Signed-off-by: Jyri Sarha 
---
 .../bindings/display/bridge/ti,tfp410.txt  |   9 +-
 drivers/gpu/drm/bridge/Kconfig |   7 +
 drivers/gpu/drm/bridge/Makefile|   1 +
 drivers/gpu/drm/bridge/ti-tfp410.c | 317 +
 4 files changed, 332 insertions(+), 2 deletions(-)
 create mode 100644 drivers/gpu/drm/bridge/ti-tfp410.c

diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt 
b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
index 2cbe32a..54d7e31 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
+++ b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
@@ -6,10 +6,15 @@ Required properties:

 Optional properties:
 - powerdown-gpios: power-down gpio
+- reg: I2C address. If and only if present the device node
+   should be placed into the i2c controller node where the
+   tfp410 i2c is connected to.

 Required nodes:
-- Video port 0 for DPI input
-- Video port 1 for DVI output
+- Video port 0 for DPI input [1].
+- Video port 1 for DVI output [1].
+
+[1]: Documentation/devicetree/bindings/media/video-interfaces.txt

 Example
 ---
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index bd6acc8..a424e03 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -81,6 +81,13 @@ config DRM_TOSHIBA_TC358767
---help---
  Toshiba TC358767 eDP bridge chip driver.

+config DRM_TI_TFP410
+   tristate "TI TFP410 DVI/HDMI bridge"
+   depends on OF
+   select DRM_KMS_HELPER
+   ---help---
+ Texas Instruments TFP410 DVI/HDMI Transmitter driver
+
 source "drivers/gpu/drm/bridge/analogix/Kconfig"

 source "drivers/gpu/drm/bridge/adv7511/Kconfig"
diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile
index 97ed1a5..8b065d9 100644
--- a/drivers/gpu/drm/bridge/Makefile
+++ b/drivers/gpu/drm/bridge/Makefile
@@ -11,3 +11,4 @@ obj-$(CONFIG_DRM_SII902X) += sii902x.o
 obj-$(CONFIG_DRM_TOSHIBA_TC358767) += tc358767.o
 obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix/
 obj-$(CONFIG_DRM_I2C_ADV7511) += adv7511/
+obj-$(CONFIG_DRM_TI_TFP410) += ti-tfp410.o
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c 
b/drivers/gpu/drm/bridge/ti-tfp410.c
new file mode 100644
index 000..b054ea3
--- /dev/null
+++ b/drivers/gpu/drm/bridge/ti-tfp410.c
@@ -0,0 +1,317 @@
+/*
+ * Copyright (C) 2016 Texas Instruments
+ * Author: Jyri Sarha 
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published by
+ * the Free Software Foundation.
+ *
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+struct tfp410 {
+   struct drm_bridge   bridge;
+   struct drm_connectorconnector;
+
+   struct i2c_adapter  *ddc;
+
+   struct device *dev;
+};
+
+static inline struct tfp410 *
+drm_bridge_to_tfp410(struct drm_bridge *bridge)
+{
+   return container_of(bridge, struct tfp410, bridge);
+}
+
+static inline struct tfp410 *
+drm_connector_to_tfp410(struct drm_connector *connector)
+{
+   return container_of(connector, struct tfp410, connector);
+}
+
+static int tfp410_get_modes(struct drm_connector *connector)
+{
+   struct tfp410 *dvi = drm_connector_to_tfp410(connector);
+   struct edid *edid;
+   int ret;
+
+   if (!dvi->ddc)
+   goto fallback;
+
+   edid = drm_get_edid(connector, dvi->ddc);
+   if (!edid) {
+   DRM_INFO("EDID read failed. Fallback to standard modes\n");
+   goto fallback;
+   }
+
+   drm_mode_connector_update_edid_property(connector, edid);
+
+   return drm_add_edid_modes(connector, edid);
+fallback:
+   /* No EDID, fallback on the XGA standard modes */
+   ret = drm_add_modes_noedid(connector, 1920, 1200);
+
+   /* And prefer a mode pretty much anything can handle */
+   drm_set_preferred_mode(connector, 1024, 768);
+
+   return ret;
+}
+
+static const struct drm_connector_helper_funcs tfp410_con_helper_funcs = {
+   .get_modes  = tfp410_get_modes,
+};
+
+static enum drm_connector_status
+tfp410_connector_detect(struct drm_connector *connector, bool force)
+{
+   struct tfp410 *dvi =