Re: [RFC PATCH v1 06/12] soc: qcom: pmic_glink_altmode: fix DRM connector type
On Mon, Sep 04, 2023 at 12:41:44AM +0300, Dmitry Baryshkov wrote: > During discussions regarding USB-C vs native DisplayPort it was pointed > out that other implementations (i915, AMD) are using > DRM_MODE_CONNECTOR_DisplayPort for both native and USB-C-wrapped DP > output. Follow this example and make the pmic_glink_altmode driver also > report DipslayPort connector rather than the USB one. I started off with this, but on devices with both USB Type-C and (native) DisplayPort, it seemed much more reasonable to make the distinction; and thereby get the outputs named "USB-n". Similarly, it looks quite reasonable that the output on my laptop are eDP-1, USB-1 and USB-2. But, if this is not the way its intended to be used, feel free to pick this together with the other patches. Acked-by: Bjorn Andersson Regards, Bjorn
[RFC PATCH v1 06/12] soc: qcom: pmic_glink_altmode: fix DRM connector type
During discussions regarding USB-C vs native DisplayPort it was pointed out that other implementations (i915, AMD) are using DRM_MODE_CONNECTOR_DisplayPort for both native and USB-C-wrapped DP output. Follow this example and make the pmic_glink_altmode driver also report DipslayPort connector rather than the USB one. Cc: Simon Ser --- drivers/soc/qcom/pmic_glink_altmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c index d05e0d6edf49..974c14d1e0bf 100644 --- a/drivers/soc/qcom/pmic_glink_altmode.c +++ b/drivers/soc/qcom/pmic_glink_altmode.c @@ -465,7 +465,7 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev, alt_port->bridge.funcs = _glink_altmode_bridge_funcs; alt_port->bridge.of_node = to_of_node(fwnode); alt_port->bridge.ops = DRM_BRIDGE_OP_HPD; - alt_port->bridge.type = DRM_MODE_CONNECTOR_USB; + alt_port->bridge.type = DRM_MODE_CONNECTOR_DisplayPort; ret = devm_drm_bridge_add(dev, _port->bridge); if (ret) -- 2.39.2