Re: [Xen-devel] [RFC PATCH 01/60] hyper_dmabuf: initial working version of hyper_dmabuf drv
On Wed, Dec 20, 2017 at 09:17:07AM +0100, Juergen Gross wrote: > On 20/12/17 00:27, Dongwon Kim wrote: > > I forgot to include this brief information about this patch series. > > > > This patch series contains the implementation of a new device driver, > > hyper_dmabuf, which provides a method for DMA-BUF sharing across > > different OSes running on the same virtual OS platform powered by > > a hypervisor. > > Some general remarks regarding this series: > > You are starting the whole driver in drivers/xen/ and in the last patch > you move it over to drivers/dma-buf/. Why don't you use drivers/dma-buf/ > from the beginning? The same applies to e.g. patch 22 changing the > license. Please make it easier for the reviewers by not letting us > review the development history of your work. Yeah, I tried to clean up our developement history but because of dependencies among patches, I couldn't make those things clear in the first place. I will try to clean things up further. > > Please run ./scripts/checkpatch.pl on each patch and correct the issues > it is reporting. At the first glance I've seen several style problems > which I won't comment until the next round. hmm.. I ran the script only on the final version and try to fix all the issues after that. If it's required for individual patches, I will clean up every patch once again. > > Please add the maintainers as Cc:, not only the related mailing lists. > As you seem to aim supporting other hypervisors than Xen you might want > to add virtualizat...@lists.linux-foundation.org as well. Ok, thanks! > > > Juergen ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [Xen-devel] [RFC PATCH 01/60] hyper_dmabuf: initial working version of hyper_dmabuf drv
Yes, I will post a test application. Thanks On Wed, Dec 20, 2017 at 10:38:08AM +0200, Oleksandr Andrushchenko wrote: > > On 12/20/2017 01:27 AM, Dongwon Kim wrote: > >This patch series contains the implementation of a new device driver, > >hyper_dmabuf, which provides a method for DMA-BUF sharing across > >different OSes running on the same virtual OS platform powered by > >a hypervisor. > This is very interesting at least in context of embedded systems. > Could you please share use-cases for this work and, if possible, > sources of the test applications if any. > > Thank you, > Oleksandr ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [Xen-devel] [RFC PATCH 01/60] hyper_dmabuf: initial working version of hyper_dmabuf drv
On 12/20/2017 01:27 AM, Dongwon Kim wrote: This patch series contains the implementation of a new device driver, hyper_dmabuf, which provides a method for DMA-BUF sharing across different OSes running on the same virtual OS platform powered by a hypervisor. This is very interesting at least in context of embedded systems. Could you please share use-cases for this work and, if possible, sources of the test applications if any. Thank you, Oleksandr ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [Xen-devel] [RFC PATCH 01/60] hyper_dmabuf: initial working version of hyper_dmabuf drv
On 20/12/17 00:27, Dongwon Kim wrote: > I forgot to include this brief information about this patch series. > > This patch series contains the implementation of a new device driver, > hyper_dmabuf, which provides a method for DMA-BUF sharing across > different OSes running on the same virtual OS platform powered by > a hypervisor. Some general remarks regarding this series: You are starting the whole driver in drivers/xen/ and in the last patch you move it over to drivers/dma-buf/. Why don't you use drivers/dma-buf/ from the beginning? The same applies to e.g. patch 22 changing the license. Please make it easier for the reviewers by not letting us review the development history of your work. Please run ./scripts/checkpatch.pl on each patch and correct the issues it is reporting. At the first glance I've seen several style problems which I won't comment until the next round. Please add the maintainers as Cc:, not only the related mailing lists. As you seem to aim supporting other hypervisors than Xen you might want to add virtualizat...@lists.linux-foundation.org as well. Juergen ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
