Re: [kbuild-all] Re: [radeon-alex:amd-20.45 2127/2427] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: sparse: sparse: incorrect type in argument 1 (different base types)
On Wed, Dec 16, 2020 at 04:20:58PM +, Deucher, Alexander wrote: > [AMD Official Use Only - Internal Distribution Only] > > You can add amd-21.xx as well, since they will coming up next year. Maybe > amd-2*? Got it, we will ignore amd-2.* pattern. > > Alex > > > From: Rong Chen > Sent: Wednesday, December 16, 2020 3:48 AM > To: Deucher, Alexander ; Qinglang Miao > ; kernel test robot > Cc: kbuild-...@lists.01.org ; > dri-devel@lists.freedesktop.org ; Felix > <"Xiong, "@ml01.01.org> > Subject: Re: [kbuild-all] Re: [radeon-alex:amd-20.45 2127/2427] > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: > sparse: sparse: incorrect type in argument 1 (different base types) > > Hi Alex, > > We have ignored the amd-20.xx branches: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fintel%2Flkp-tests%2Fcommit%2Facb8d1f213ec6841900e0d7e9737f8ea0960e4d3&data=04%7C01%7CAlexander.Deucher%40amd.com%7C2f283fc47a6641db05cd08d8a19f7d80%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637437053682479635%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=U2aA%2B31wbSToDkIHiUrJWriNOPNNJ162W3F1HjYG6mc%3D&reserved=0 > > Best Regards, > Rong Chen > > On 12/15/20 10:24 PM, Deucher, Alexander wrote: > > > > [AMD Public Use] > > > > > > The test robot should probably not be testing the amd-20.xx branches > > in the first place. They are just mirrors of our packaged drivers so > > they contain a bunch of stuff that will never go upstream like kernel > > compatibility layers and dkms support. > > > > Alex > > > > > > *From:* Qinglang Miao > > *Sent:* Tuesday, December 15, 2020 3:21 AM > > *To:* kernel test robot ; Deucher, Alexander > > > > *Cc:* kbuild-...@lists.01.org ; > > dri-devel@lists.freedesktop.org ; > > Xiong, Yang (Felix) > > *Subject:* Re: [radeon-alex:amd-20.45 2127/2427] > > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: > > sparse: sparse: incorrect type in argument 1 (different base types) > > Hi Alex, > > > > I think it's not a valid report from kernel test robot, for __le16 ought > > to be the right type for cpu_to_le16. The sparse warnings seems not > > right so I did't try effort to reproduce it. > > > > otherwise, when I take a carful look at this patch, an unconditional > > braces exists and I'm not sure about its benefit. > > > > if (bp_params->flags.INTERLACE) { > > params.susModeMiscInfo.usAccess = > > cpu_to_le16(le16_to_cpu(params.susModeMiscInfo.usAccess) | > > ATOM_INTERLACE); > > { > > le16_add_cpu(¶ms.usV_SyncOffset, 1); > > } > > } > > > > patch link: > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2FCADnq5_PunHA1VHHj7VtEHG6o2Z_Z1WS325y_R9xO%2BgsV_JCOXw%40mail.gmail.com%2F&data=04%7C01%7CAlexander.Deucher%40amd.com%7C2f283fc47a6641db05cd08d8a19f7d80%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637437053682489591%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=loDpCZcwzSthBMwesVesMIEwtgf%2BGZoycOyTwBpqkfI%3D&reserved=0 > > > > How do you think? > > > > 在 2020/12/15 14:44, kernel test robot 写道: > > > tree: git://people.freedesktop.org/~agd5f/linux.git amd-20.45 > > > head: a3950d94b046fb206e58fd3ec717f071c0203ba3 > > > commit: c82b6c9ed412fb7009b02dd82e50ee24f451e9a8 [2127/2427] > > drm/amd/display: convert to use le16_add_cpu() > > > config: arc-randconfig-s031-20201214 (attached as .config) > > > compiler: arc-elf-gcc (GCC) 9.3.0 > > > reproduce: > > > wget > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=04%7C01%7CAlexander.Deucher%40amd.com%7C2f283fc47a6641db05cd08d8a19f7d80%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637437053682489591%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=a6yKdL%2BoYm1zc5fYftUrWwmas%2BOfrTjqpivV14xci1Y%3D&reserved=0 > > -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # apt-get install sparse > > > # sparse version: v0.6.3-184-g1b896707-dirty > > > git remote add radeon-alex > > git://people.freedesktop.org/~agd5f/linux.git
Re: [kbuild-all] Re: [radeon-alex:amd-20.45 2127/2427] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: sparse: sparse: incorrect type in argument 1 (different base types)
[AMD Official Use Only - Internal Distribution Only] You can add amd-21.xx as well, since they will coming up next year. Maybe amd-2*? Alex From: Rong Chen Sent: Wednesday, December 16, 2020 3:48 AM To: Deucher, Alexander ; Qinglang Miao ; kernel test robot Cc: kbuild-...@lists.01.org ; dri-devel@lists.freedesktop.org ; Felix <"Xiong, "@ml01.01.org> Subject: Re: [kbuild-all] Re: [radeon-alex:amd-20.45 2127/2427] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: sparse: sparse: incorrect type in argument 1 (different base types) Hi Alex, We have ignored the amd-20.xx branches: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fintel%2Flkp-tests%2Fcommit%2Facb8d1f213ec6841900e0d7e9737f8ea0960e4d3&data=04%7C01%7CAlexander.Deucher%40amd.com%7C2f283fc47a6641db05cd08d8a19f7d80%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637437053682479635%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=U2aA%2B31wbSToDkIHiUrJWriNOPNNJ162W3F1HjYG6mc%3D&reserved=0 Best Regards, Rong Chen On 12/15/20 10:24 PM, Deucher, Alexander wrote: > > [AMD Public Use] > > > The test robot should probably not be testing the amd-20.xx branches > in the first place. They are just mirrors of our packaged drivers so > they contain a bunch of stuff that will never go upstream like kernel > compatibility layers and dkms support. > > Alex > > > *From:* Qinglang Miao > *Sent:* Tuesday, December 15, 2020 3:21 AM > *To:* kernel test robot ; Deucher, Alexander > > *Cc:* kbuild-...@lists.01.org ; > dri-devel@lists.freedesktop.org ; > Xiong, Yang (Felix) > *Subject:* Re: [radeon-alex:amd-20.45 2127/2427] > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: > sparse: sparse: incorrect type in argument 1 (different base types) > Hi Alex, > > I think it's not a valid report from kernel test robot, for __le16 ought > to be the right type for cpu_to_le16. The sparse warnings seems not > right so I did't try effort to reproduce it. > > otherwise, when I take a carful look at this patch, an unconditional > braces exists and I'm not sure about its benefit. > > if (bp_params->flags.INTERLACE) { > params.susModeMiscInfo.usAccess = > cpu_to_le16(le16_to_cpu(params.susModeMiscInfo.usAccess) | > ATOM_INTERLACE); > { > le16_add_cpu(¶ms.usV_SyncOffset, 1); > } > } > > patch link: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2FCADnq5_PunHA1VHHj7VtEHG6o2Z_Z1WS325y_R9xO%2BgsV_JCOXw%40mail.gmail.com%2F&data=04%7C01%7CAlexander.Deucher%40amd.com%7C2f283fc47a6641db05cd08d8a19f7d80%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637437053682489591%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=loDpCZcwzSthBMwesVesMIEwtgf%2BGZoycOyTwBpqkfI%3D&reserved=0 > > How do you think? > > 在 2020/12/15 14:44, kernel test robot 写道: > > tree: git://people.freedesktop.org/~agd5f/linux.git amd-20.45 > > head: a3950d94b046fb206e58fd3ec717f071c0203ba3 > > commit: c82b6c9ed412fb7009b02dd82e50ee24f451e9a8 [2127/2427] > drm/amd/display: convert to use le16_add_cpu() > > config: arc-randconfig-s031-20201214 (attached as .config) > > compiler: arc-elf-gcc (GCC) 9.3.0 > > reproduce: > > wget > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=04%7C01%7CAlexander.Deucher%40amd.com%7C2f283fc47a6641db05cd08d8a19f7d80%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637437053682489591%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=a6yKdL%2BoYm1zc5fYftUrWwmas%2BOfrTjqpivV14xci1Y%3D&reserved=0 > -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # apt-get install sparse > > # sparse version: v0.6.3-184-g1b896707-dirty > > git remote add radeon-alex > git://people.freedesktop.org/~agd5f/linux.git > > git fetch --no-tags radeon-alex amd-20.45 > > git checkout c82b6c9ed412fb7009b02dd82e50ee24f451e9a8 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 > make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arc > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > > > "sparse warnings: (new ones prefix
Re: [kbuild-all] Re: [radeon-alex:amd-20.45 2127/2427] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: sparse: sparse: incorrect type in argument 1 (different base types)
Hi Alex, We have ignored the amd-20.xx branches: https://github.com/intel/lkp-tests/commit/acb8d1f213ec6841900e0d7e9737f8ea0960e4d3 Best Regards, Rong Chen On 12/15/20 10:24 PM, Deucher, Alexander wrote: [AMD Public Use] The test robot should probably not be testing the amd-20.xx branches in the first place. They are just mirrors of our packaged drivers so they contain a bunch of stuff that will never go upstream like kernel compatibility layers and dkms support. Alex *From:* Qinglang Miao *Sent:* Tuesday, December 15, 2020 3:21 AM *To:* kernel test robot ; Deucher, Alexander *Cc:* kbuild-...@lists.01.org ; dri-devel@lists.freedesktop.org ; Xiong, Yang (Felix) *Subject:* Re: [radeon-alex:amd-20.45 2127/2427] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1880:39: sparse: sparse: incorrect type in argument 1 (different base types) Hi Alex, I think it's not a valid report from kernel test robot, for __le16 ought to be the right type for cpu_to_le16. The sparse warnings seems not right so I did't try effort to reproduce it. otherwise, when I take a carful look at this patch, an unconditional braces exists and I'm not sure about its benefit. if (bp_params->flags.INTERLACE) { params.susModeMiscInfo.usAccess = cpu_to_le16(le16_to_cpu(params.susModeMiscInfo.usAccess) | ATOM_INTERLACE); { le16_add_cpu(¶ms.usV_SyncOffset, 1); } } patch link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flkml%2FCADnq5_PunHA1VHHj7VtEHG6o2Z_Z1WS325y_R9xO%2BgsV_JCOXw%40mail.gmail.com%2F&data=04%7C01%7Calexander.deucher%40amd.com%7Cc9a5d9273f464451b1f808d8a0d271fe%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637436173010744629%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=1TmtjBXJLf60sxq%2BH%2BVmMhnRV%2FuyIKQD2BYDVWMxmUA%3D&reserved=0 How do you think? 在 2020/12/15 14:44, kernel test robot 写道: > tree: git://people.freedesktop.org/~agd5f/linux.git amd-20.45 > head: a3950d94b046fb206e58fd3ec717f071c0203ba3 > commit: c82b6c9ed412fb7009b02dd82e50ee24f451e9a8 [2127/2427] drm/amd/display: convert to use le16_add_cpu() > config: arc-randconfig-s031-20201214 (attached as .config) > compiler: arc-elf-gcc (GCC) 9.3.0 > reproduce: > wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=04%7C01%7Calexander.deucher%40amd.com%7Cc9a5d9273f464451b1f808d8a0d271fe%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637436173010754583%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=DCHDVGjiXhPDoCTofTf0pxHspdydDs1JXneGoSGPgFQ%3D&reserved=0 -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.3-184-g1b896707-dirty > git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git > git fetch --no-tags radeon-alex amd-20.45 > git checkout c82b6c9ed412fb7009b02dd82e50ee24f451e9a8 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arc > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > > "sparse warnings: (new ones prefixed by >>)" > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:879:43: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [addressable] [assigned] [usertype] ulSymClock @@ got restricted __le16 [usertype] @@ > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:879:43: sparse: expected unsigned int [addressable] [assigned] [usertype] ulSymClock > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:879:43: sparse: got restricted __le16 [usertype] > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:956:40: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] usRefDiv @@ got restricted __le16 [usertype] @@ > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:956:40: sparse: expected unsigned short [addressable] [assigned] [usertype] usRefDiv > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:956:40: sparse: got restricted __le16 [usertype] > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:958:39: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [addressable] [assigned] [usertype] usFbDiv @@ got restricted __le16 [usertype] @@ > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:958:39: sparse: expected unsigned shor