subject:"\[patch\] gma500\: silence an unused variable warning"

[patch] gma500: silence an unused variable warning

2012-05-10 Thread Alan Cox

On Thu, 10 May 2012 10:33:02 +0300
Dan Carpenter  wrote:

> If CONFIG_BACKLIGHT_CLASS_DEVICE is disabled then GCC warns that:
>   drivers/gpu/drm/gma500/opregion.c:154:6: warning:
>   unused variable ?max? [-Wunused-variable]
> 
> Which give me a chance to use the new config_enabled() macro.  :)
> 
> Signed-off-by: Dan Carpenter 

Acked-by: Alan Cox

[patch] gma500: silence an unused variable warning

2012-05-10 Thread Kirill A. Shutemov

On Thu, May 10, 2012 at 10:33:02AM +0300, Dan Carpenter wrote:
> If CONFIG_BACKLIGHT_CLASS_DEVICE is disabled then GCC warns that:
>   drivers/gpu/drm/gma500/opregion.c:154:6: warning:
>   unused variable ?max? [-Wunused-variable]
> 
> Which give me a chance to use the new config_enabled() macro.  :)

The first [direct] user of config_enabled()! :)

Acked-by: Kirill A. Shutemov 

> 
> Signed-off-by: Dan Carpenter 
> 
> diff --git a/drivers/gpu/drm/gma500/opregion.c 
> b/drivers/gpu/drm/gma500/opregion.c
> index 05661bf..d2125ba 100644
> --- a/drivers/gpu/drm/gma500/opregion.c
> +++ b/drivers/gpu/drm/gma500/opregion.c
> @@ -151,7 +151,6 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 
> bclp)
>   struct drm_psb_private *dev_priv = dev->dev_private;
>   struct opregion_asle *asle = dev_priv->opregion.asle;
>   struct backlight_device *bd = dev_priv->backlight_device;
> - u32 max;
>  
>   DRM_DEBUG_DRIVER("asle set backlight %x\n", bclp);
>  
> @@ -165,11 +164,12 @@ static u32 asle_set_backlight(struct drm_device *dev, 
> u32 bclp)
>   if (bclp > 255)
>   return ASLE_BACKLIGHT_FAILED;
>  
> -#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
> - max = bd->props.max_brightness;
> - bd->props.brightness = bclp * max / 255;
> - backlight_update_status(bd);
> -#endif
> + if (config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)) {
> + int max = bd->props.max_brightness;
> + bd->props.brightness = bclp * max / 255;
> + backlight_update_status(bd);
> + }
> +
>   asle->cblv = (bclp * 0x64) / 0xff | ASLE_CBLV_VALID;
>  
>   return 0;

-- 
 Kirill A. Shutemov
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL:

[patch] gma500: silence an unused variable warning

2012-05-10 Thread Dan Carpenter

If CONFIG_BACKLIGHT_CLASS_DEVICE is disabled then GCC warns that:
drivers/gpu/drm/gma500/opregion.c:154:6: warning:
unused variable ?max? [-Wunused-variable]

Which give me a chance to use the new config_enabled() macro.  :)

Signed-off-by: Dan Carpenter 

diff --git a/drivers/gpu/drm/gma500/opregion.c 
b/drivers/gpu/drm/gma500/opregion.c
index 05661bf..d2125ba 100644
--- a/drivers/gpu/drm/gma500/opregion.c
+++ b/drivers/gpu/drm/gma500/opregion.c
@@ -151,7 +151,6 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 
bclp)
struct drm_psb_private *dev_priv = dev->dev_private;
struct opregion_asle *asle = dev_priv->opregion.asle;
struct backlight_device *bd = dev_priv->backlight_device;
-   u32 max;

DRM_DEBUG_DRIVER("asle set backlight %x\n", bclp);

@@ -165,11 +164,12 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 
bclp)
if (bclp > 255)
return ASLE_BACKLIGHT_FAILED;

-#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
-   max = bd->props.max_brightness;
-   bd->props.brightness = bclp * max / 255;
-   backlight_update_status(bd);
-#endif
+   if (config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)) {
+   int max = bd->props.max_brightness;
+   bd->props.brightness = bclp * max / 255;
+   backlight_update_status(bd);
+   }
+
asle->cblv = (bclp * 0x64) / 0xff | ASLE_CBLV_VALID;

return 0;

[patch] gma500: silence an unused variable warning

2012-05-10 Thread Paul Menzel

Am Donnerstag, den 10.05.2012, 10:33 +0300 schrieb Dan Carpenter:
> If CONFIG_BACKLIGHT_CLASS_DEVICE is disabled then GCC warns that:
>   drivers/gpu/drm/gma500/opregion.c:154:6: warning:
>   unused variable ?max? [-Wunused-variable]
> 
> Which give me a chance to use the new config_enabled() macro.  :)

Also the variable type is changed from `u32` to `int`.

> Signed-off-by: Dan Carpenter 

Acked-by: Paul Menzel 

> diff --git a/drivers/gpu/drm/gma500/opregion.c 
> b/drivers/gpu/drm/gma500/opregion.c
> index 05661bf..d2125ba 100644
> --- a/drivers/gpu/drm/gma500/opregion.c
> +++ b/drivers/gpu/drm/gma500/opregion.c
> @@ -151,7 +151,6 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 
> bclp)
>   struct drm_psb_private *dev_priv = dev->dev_private;
>   struct opregion_asle *asle = dev_priv->opregion.asle;
>   struct backlight_device *bd = dev_priv->backlight_device;
> - u32 max;
>  
>   DRM_DEBUG_DRIVER("asle set backlight %x\n", bclp);
>  
> @@ -165,11 +164,12 @@ static u32 asle_set_backlight(struct drm_device *dev, 
> u32 bclp)
>   if (bclp > 255)
>   return ASLE_BACKLIGHT_FAILED;
>  
> -#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
> - max = bd->props.max_brightness;
> - bd->props.brightness = bclp * max / 255;
> - backlight_update_status(bd);
> -#endif
> + if (config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)) {
> + int max = bd->props.max_brightness;
> + bd->props.brightness = bclp * max / 255;
> + backlight_update_status(bd);
> + }
> +
>   asle->cblv = (bclp * 0x64) / 0xff | ASLE_CBLV_VALID;
>  
>   return 0;
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL:

Re: [patch] gma500: silence an unused variable warning

2012-05-10 Thread Kirill A. Shutemov

On Thu, May 10, 2012 at 10:33:02AM +0300, Dan Carpenter wrote:
 If CONFIG_BACKLIGHT_CLASS_DEVICE is disabled then GCC warns that:
   drivers/gpu/drm/gma500/opregion.c:154:6: warning:
   unused variable ‘max’ [-Wunused-variable]
 
 Which give me a chance to use the new config_enabled() macro.  :)

The first [direct] user of config_enabled()! :)

Acked-by: Kirill A. Shutemov kirill.shute...@linux.intel.com

 
 Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
 
 diff --git a/drivers/gpu/drm/gma500/opregion.c 
 b/drivers/gpu/drm/gma500/opregion.c
 index 05661bf..d2125ba 100644
 --- a/drivers/gpu/drm/gma500/opregion.c
 +++ b/drivers/gpu/drm/gma500/opregion.c
 @@ -151,7 +151,6 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 
 bclp)
   struct drm_psb_private *dev_priv = dev-dev_private;
   struct opregion_asle *asle = dev_priv-opregion.asle;
   struct backlight_device *bd = dev_priv-backlight_device;
 - u32 max;
  
   DRM_DEBUG_DRIVER(asle set backlight %x\n, bclp);
  
 @@ -165,11 +164,12 @@ static u32 asle_set_backlight(struct drm_device *dev, 
 u32 bclp)
   if (bclp  255)
   return ASLE_BACKLIGHT_FAILED;
  
 -#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
 - max = bd-props.max_brightness;
 - bd-props.brightness = bclp * max / 255;
 - backlight_update_status(bd);
 -#endif
 + if (config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)) {
 + int max = bd-props.max_brightness;
 + bd-props.brightness = bclp * max / 255;
 + backlight_update_status(bd);
 + }
 +
   asle-cblv = (bclp * 0x64) / 0xff | ASLE_CBLV_VALID;
  
   return 0;

-- 
 Kirill A. Shutemov


signature.asc
Description: Digital signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [patch] gma500: silence an unused variable warning

2012-05-10 Thread Paul Menzel

Am Donnerstag, den 10.05.2012, 10:33 +0300 schrieb Dan Carpenter:
 If CONFIG_BACKLIGHT_CLASS_DEVICE is disabled then GCC warns that:
   drivers/gpu/drm/gma500/opregion.c:154:6: warning:
   unused variable ‘max’ [-Wunused-variable]
 
 Which give me a chance to use the new config_enabled() macro.  :)

Also the variable type is changed from `u32` to `int`.

 Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

Acked-by: Paul Menzel paulepan...@users.sourceforge.net

 diff --git a/drivers/gpu/drm/gma500/opregion.c 
 b/drivers/gpu/drm/gma500/opregion.c
 index 05661bf..d2125ba 100644
 --- a/drivers/gpu/drm/gma500/opregion.c
 +++ b/drivers/gpu/drm/gma500/opregion.c
 @@ -151,7 +151,6 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 
 bclp)
   struct drm_psb_private *dev_priv = dev-dev_private;
   struct opregion_asle *asle = dev_priv-opregion.asle;
   struct backlight_device *bd = dev_priv-backlight_device;
 - u32 max;
  
   DRM_DEBUG_DRIVER(asle set backlight %x\n, bclp);
  
 @@ -165,11 +164,12 @@ static u32 asle_set_backlight(struct drm_device *dev, 
 u32 bclp)
   if (bclp  255)
   return ASLE_BACKLIGHT_FAILED;
  
 -#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE
 - max = bd-props.max_brightness;
 - bd-props.brightness = bclp * max / 255;
 - backlight_update_status(bd);
 -#endif
 + if (config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)) {
 + int max = bd-props.max_brightness;
 + bd-props.brightness = bclp * max / 255;
 + backlight_update_status(bd);
 + }
 +
   asle-cblv = (bclp * 0x64) / 0xff | ASLE_CBLV_VALID;
  
   return 0;


signature.asc
Description: This is a digitally signed message part
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[patch] gma500: silence an unused variable warning

[patch] gma500: silence an unused variable warning

[patch] gma500: silence an unused variable warning

[patch] gma500: silence an unused variable warning

Re: [patch] gma500: silence an unused variable warning

Re: [patch] gma500: silence an unused variable warning

6 matches

Site Navigation

Mail list logo

Footer information