RE: [v1 1/2] dt-bindings: display: panel: Add Truly NT36672E LCD DSI panel

2024-01-04 Thread Ritesh Kumar 
Hi Krzysztof,

>-Original Message-
>From: Krzysztof Kozlowski 
>Sent: Friday, December 22, 2023 9:02 PM
>To: Ritesh Kumar (QUIC) ; dri-
>de...@lists.freedesktop.org; devicet...@vger.kernel.org; linux-
>ker...@vger.kernel.org
>Cc: neil.armstr...@linaro.org; Jessica Zhang (QUIC)
>; s...@ravnborg.org;
>maarten.lankho...@linux.intel.com; mrip...@kernel.org;
>tzimmerm...@suse.de; airl...@gmail.com; dan...@ffwll.ch;
>robh...@kernel.org; krzysztof.kozlowski...@linaro.org; conor...@kernel.org;
>Abhinav Kumar (QUIC) ; Rajeev Nandan (QUIC)
>; Vishnuvardhan Prodduturi (QUIC)
>
>Subject: Re: [v1 1/2] dt-bindings: display: panel: Add Truly NT36672E LCD DSI
>panel
>
>WARNING: This email originated from outside of Qualcomm. Please be wary of
>any links or attachments, and do not enable macros.
>
>On 22/12/2023 12:07, Ritesh Kumar wrote:
>> Document Truly NT36672E FHD+ LCD DSI panel.
>>
>> Signed-off-by: Ritesh Kumar 
>> ---
>>  .../display/panel/truly,nt36672e.yaml | 66 +++
>>  1 file changed, 66 insertions(+)
>>  create mode 100644
>> Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>> b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
>> new file mode 100644
>> index ..39ab05c5b103
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.y
>> +++ aml
>> @@ -0,0 +1,66 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/panel/truly,nt36672e.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Truly NT36672E LCD DSI Panel
>> +
>> +maintainers:
>> +  - Ritesh Kumar 
>> +
>> +allOf:
>> +  - $ref: panel-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +const: truly,nt36672e
>
>Eee? This is existing Novatek, isn't it?

This is novatek nt36672e panel. Existing novatek is nt36672a panel.
They differ in resolution, power on/off sequence (init sequence, delays), panel 
reset sequence.
NT36672E panel supports refresh rates of 60Hz, 90Hz, 120Hz and 144Hz. It also 
supports DSC.
To start with, I have added support for uncompressed 60Hz. In subsequent 
patches, other configurations
support will be added.

>
>> +
>> +  reg:
>> +maxItems: 1
>> +description: DSI virtual channel
>> +
>> +  vddi-supply: true
>> +  avdd-supply: true
>> +  avee-supply: true
>> +  port: true
>> +  reset-gpios: true
>> +  backlight: true
>> +
>> +additionalProperties: false
>
>
>This goes after required:.

Thanks, will change in next version.

Thanks,
Ritesh

[v1 1/2] dt-bindings: display: panel: Add Truly NT36672E LCD DSI panel

2023-12-22 Thread Ritesh Kumar 
Document Truly NT36672E FHD+ LCD DSI panel.

Signed-off-by: Ritesh Kumar 
---
 .../display/panel/truly,nt36672e.yaml | 66 +++
 1 file changed, 66 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml

diff --git 
a/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml 
b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
new file mode 100644
index ..39ab05c5b103
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/truly,nt36672e.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Truly NT36672E LCD DSI Panel
+
+maintainers:
+  - Ritesh Kumar 
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+const: truly,nt36672e
+
+  reg:
+maxItems: 1
+description: DSI virtual channel
+
+  vddi-supply: true
+  avdd-supply: true
+  avee-supply: true
+  port: true
+  reset-gpios: true
+  backlight: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - vddi-supply
+  - avdd-supply
+  - avee-supply
+  - reset-gpios
+  - port
+
+examples:
+  - |
+#include 
+dsi {
+#address-cells = <1>;
+#size-cells = <0>;
+panel@0 {
+compatible = "truly,nt36672e";
+reg = <0>;
+
+reset-gpios = < 44 GPIO_ACTIVE_HIGH>;
+
+vddi-supply = <_l8c_1p8>;
+avdd-supply = <_avdd>;
+avee-supply = <_avee>;
+
+backlight = <_backlight>;
+
+port {
+panel0_in: endpoint {
+remote-endpoint = <_out>;
+};
+};
+};
+};
+...
-- 
2.17.1

Re: [v1 1/2] dt-bindings: display: panel: Add Truly NT36672E LCD DSI panel

2023-12-22 Thread Krzysztof Kozlowski 
On 22/12/2023 12:07, Ritesh Kumar wrote:
> Document Truly NT36672E FHD+ LCD DSI panel.
> 
> Signed-off-by: Ritesh Kumar 
> ---
>  .../display/panel/truly,nt36672e.yaml | 66 +++
>  1 file changed, 66 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml 
> b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
> new file mode 100644
> index ..39ab05c5b103
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/truly,nt36672e.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/truly,nt36672e.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Truly NT36672E LCD DSI Panel
> +
> +maintainers:
> +  - Ritesh Kumar 
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +const: truly,nt36672e

Eee? This is existing Novatek, isn't it?

> +
> +  reg:
> +maxItems: 1
> +description: DSI virtual channel
> +
> +  vddi-supply: true
> +  avdd-supply: true
> +  avee-supply: true
> +  port: true
> +  reset-gpios: true
> +  backlight: true
> +
> +additionalProperties: false


This goes after required:.


Best regards,
Krzysztof