Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-15 Thread Takashi Iwai
On Mon, 14 Aug 2023 17:06:02 +0200,
Takashi Iwai wrote:
> 
> On Mon, 14 Aug 2023 16:51:08 +0200,
> Karol Herbst wrote:
> > 
> > I've sent a patch out to address this memory corruption
> > https://patchwork.freedesktop.org/patch/552642/
> > 
> > It might or might not fix regressions from the original I2C fix, so
> > please test and report if there are remaining issues.
> 
> Thanks!  I'll build a test kernel and ask the reporter for testing
> with it.  Let's cross fingers :)

The feedback is positive, so far.  It seems fixing the regression
reported for 6.4.8 kernel.


thanks,

Takashi


Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Takashi Iwai
On Mon, 14 Aug 2023 16:51:08 +0200,
Karol Herbst wrote:
> 
> I've sent a patch out to address this memory corruption
> https://patchwork.freedesktop.org/patch/552642/
> 
> It might or might not fix regressions from the original I2C fix, so
> please test and report if there are remaining issues.

Thanks!  I'll build a test kernel and ask the reporter for testing
with it.  Let's cross fingers :)


Takashi


Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Mon, Aug 14, 2023 at 4:19 PM Karol Herbst  wrote:
>
> On Mon, Aug 14, 2023 at 3:35 PM Takashi Iwai  wrote:
> >
> > On Mon, 14 Aug 2023 15:19:11 +0200,
> > Karol Herbst wrote:
> > >
> > > On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst  wrote:
> > > >
> > > > On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai  wrote:
> > > > >
> > > > > On Mon, 14 Aug 2023 14:38:18 +0200,
> > > > > Karol Herbst wrote:
> > > > > >
> > > > > > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai  wrote:
> > > > > > >
> > > > > > > On Wed, 09 Aug 2023 16:46:38 +0200,
> > > > > > > Takashi Iwai wrote:
> > > > > > > >
> > > > > > > > On Wed, 09 Aug 2023 15:13:23 +0200,
> > > > > > > > Takashi Iwai wrote:
> > > > > > > > >
> > > > > > > > > On Wed, 09 Aug 2023 14:19:23 +0200,
> > > > > > > > > Karol Herbst wrote:
> > > > > > > > > >
> > > > > > > > > > On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai  
> > > > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > On Wed, 09 Aug 2023 13:42:09 +0200,
> > > > > > > > > > > Karol Herbst wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai 
> > > > > > > > > > > >  wrote:
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > > > > > > > > > > > Karol Herbst wrote:
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov 
> > > > > > > > > > > > > >  wrote:
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol 
> > > > > > > > > > > > > > > Herbst wrote:
> > > > > > > > > > > > > > > > in what way does it stop? Just not progressing? 
> > > > > > > > > > > > > > > > That would be kinda
> > > > > > > > > > > > > > > > concerning. Mind tracing with what arguments 
> > > > > > > > > > > > > > > > `nvkm_uevent_add` is
> > > > > > > > > > > > > > > > called with and without that patch?
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Well, me dumping those args I guess made the box 
> > > > > > > > > > > > > > > not freeze before
> > > > > > > > > > > > > > > catching a #PF over serial. Does that help?
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > [3.410135] Unpacking initramfs...
> > > > > > > > > > > > > > > [3.416319] software IO TLB: mapped [mem 
> > > > > > > > > > > > > > > 0xa877d000-0xac77d000] (64MB)
> > > > > > > > > > > > > > > [3.418227] Initialise system trusted keyrings
> > > > > > > > > > > > > > > [3.432273] workingset: timestamp_bits=56 
> > > > > > > > > > > > > > > max_order=22 bucket_order=0
> > > > > > > > > > > > > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > > > > > > > > > > > > [3.443368] fuse: init (API version 7.38)
> > > > > > > > > > > > > > > [3.447601] 9p: Installing v9fs 9p2000 file 
> > > > > > > > > > > > > > > system support
> > > > > > > > > > > > > > > [3.453223] Key type asymmetric registered
> > > > > > > > > > > > > > > [3.457332] Asymmetric key parser 'x509' 
> > > > > > > > > > > > > > > registered
> > > > > > > > > > > > > > > [3.462236] Block layer SCSI generic (bsg) 
> > > > > > > > > > > > > > > driver version 0.4 loaded (major 250)
> > > > > > > > > > > > > > > [3.475865] efifb: probing for efifb
> > > > > > > > > > > > > > > [3.479458] efifb: framebuffer at 0xf900, 
> > > > > > > > > > > > > > > using 1920k, total 1920k
> > > > > > > > > > > > > > > [3.485969] efifb: mode is 800x600x32, 
> > > > > > > > > > > > > > > linelength=3200, pages=1
> > > > > > > > > > > > > > > [3.491872] efifb: scrolling: redraw
> > > > > > > > > > > > > > > [3.495438] efifb: Truecolor: size=8:8:8:8, 
> > > > > > > > > > > > > > > shift=24:16:8:0
> > > > > > > > > > > > > > > [3.502349] Console: switching to colour frame 
> > > > > > > > > > > > > > > buffer device 100x37
> > > > > > > > > > > > > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > > > > > > > > > > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle 
> > > > > > > > > > > > > > > states
> > > > > > > > > > > > > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle 
> > > > > > > > > > > > > > > states
> > > > > > > > > > > > > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle 
> > > > > > > > > > > > > > > states
> > > > > > > > > > > > > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle 
> > > > > > > > > > > > > > > states
> > > > > > > > > > > > > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle 
> > > > > > > > > > > > > > > states
> > > > > > > > > > > > > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle 
> > > > > > > > > > > > > > > states
> > > > > > > > > > > > > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle 
> > > > > > > > > > > > > > > states
> > > > > > > > > > > > > > > [3.544219] Freeing initrd memory: 8196K
> > > > > > > > > > > > > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle 
> > > > > > > > > > > > > > > states
> > > > > > > > > > > > > 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Mon, Aug 14, 2023 at 3:35 PM Takashi Iwai  wrote:
>
> On Mon, 14 Aug 2023 15:19:11 +0200,
> Karol Herbst wrote:
> >
> > On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst  wrote:
> > >
> > > On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai  wrote:
> > > >
> > > > On Mon, 14 Aug 2023 14:38:18 +0200,
> > > > Karol Herbst wrote:
> > > > >
> > > > > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai  wrote:
> > > > > >
> > > > > > On Wed, 09 Aug 2023 16:46:38 +0200,
> > > > > > Takashi Iwai wrote:
> > > > > > >
> > > > > > > On Wed, 09 Aug 2023 15:13:23 +0200,
> > > > > > > Takashi Iwai wrote:
> > > > > > > >
> > > > > > > > On Wed, 09 Aug 2023 14:19:23 +0200,
> > > > > > > > Karol Herbst wrote:
> > > > > > > > >
> > > > > > > > > On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai  
> > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > On Wed, 09 Aug 2023 13:42:09 +0200,
> > > > > > > > > > Karol Herbst wrote:
> > > > > > > > > > >
> > > > > > > > > > > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai 
> > > > > > > > > > >  wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > > > > > > > > > > Karol Herbst wrote:
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov 
> > > > > > > > > > > > >  wrote:
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol 
> > > > > > > > > > > > > > Herbst wrote:
> > > > > > > > > > > > > > > in what way does it stop? Just not progressing? 
> > > > > > > > > > > > > > > That would be kinda
> > > > > > > > > > > > > > > concerning. Mind tracing with what arguments 
> > > > > > > > > > > > > > > `nvkm_uevent_add` is
> > > > > > > > > > > > > > > called with and without that patch?
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > Well, me dumping those args I guess made the box 
> > > > > > > > > > > > > > not freeze before
> > > > > > > > > > > > > > catching a #PF over serial. Does that help?
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > 
> > > > > > > > > > > > > > [3.410135] Unpacking initramfs...
> > > > > > > > > > > > > > [3.416319] software IO TLB: mapped [mem 
> > > > > > > > > > > > > > 0xa877d000-0xac77d000] (64MB)
> > > > > > > > > > > > > > [3.418227] Initialise system trusted keyrings
> > > > > > > > > > > > > > [3.432273] workingset: timestamp_bits=56 
> > > > > > > > > > > > > > max_order=22 bucket_order=0
> > > > > > > > > > > > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > > > > > > > > > > > [3.443368] fuse: init (API version 7.38)
> > > > > > > > > > > > > > [3.447601] 9p: Installing v9fs 9p2000 file 
> > > > > > > > > > > > > > system support
> > > > > > > > > > > > > > [3.453223] Key type asymmetric registered
> > > > > > > > > > > > > > [3.457332] Asymmetric key parser 'x509' 
> > > > > > > > > > > > > > registered
> > > > > > > > > > > > > > [3.462236] Block layer SCSI generic (bsg) 
> > > > > > > > > > > > > > driver version 0.4 loaded (major 250)
> > > > > > > > > > > > > > [3.475865] efifb: probing for efifb
> > > > > > > > > > > > > > [3.479458] efifb: framebuffer at 0xf900, 
> > > > > > > > > > > > > > using 1920k, total 1920k
> > > > > > > > > > > > > > [3.485969] efifb: mode is 800x600x32, 
> > > > > > > > > > > > > > linelength=3200, pages=1
> > > > > > > > > > > > > > [3.491872] efifb: scrolling: redraw
> > > > > > > > > > > > > > [3.495438] efifb: Truecolor: size=8:8:8:8, 
> > > > > > > > > > > > > > shift=24:16:8:0
> > > > > > > > > > > > > > [3.502349] Console: switching to colour frame 
> > > > > > > > > > > > > > buffer device 100x37
> > > > > > > > > > > > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > > > > > > > > > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > > > > > > > > > > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > > > > > > > > > > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > > > > > > > > > > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > > > > > > > > > > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > > > > > > > > > > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > > > > > > > > > > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > > > > > > > > > > > > [3.544219] Freeing initrd memory: 8196K
> > > > > > > > > > > > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > > > > > > > > > > > > [3.609542] Serial: 8250/16550 driver, 4 ports, 
> > > > > > > > > > > > > > IRQ sharing enabled
> > > > > > > > > > > > > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, 
> > > > > > > > > > > > > > base_baud = 115200) is a 16550A
> > > > > > > > > > > > > > [3.625552] serial :00:16.3: enabling device 
> > > > > > > > > > > > > > ( -> 0003)
> > > > > > > > > > > > > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 
> > > > > > > > > > > > > > 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Takashi Iwai
On Mon, 14 Aug 2023 15:19:11 +0200,
Karol Herbst wrote:
> 
> On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst  wrote:
> >
> > On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai  wrote:
> > >
> > > On Mon, 14 Aug 2023 14:38:18 +0200,
> > > Karol Herbst wrote:
> > > >
> > > > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai  wrote:
> > > > >
> > > > > On Wed, 09 Aug 2023 16:46:38 +0200,
> > > > > Takashi Iwai wrote:
> > > > > >
> > > > > > On Wed, 09 Aug 2023 15:13:23 +0200,
> > > > > > Takashi Iwai wrote:
> > > > > > >
> > > > > > > On Wed, 09 Aug 2023 14:19:23 +0200,
> > > > > > > Karol Herbst wrote:
> > > > > > > >
> > > > > > > > On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai  
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > On Wed, 09 Aug 2023 13:42:09 +0200,
> > > > > > > > > Karol Herbst wrote:
> > > > > > > > > >
> > > > > > > > > > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai 
> > > > > > > > > >  wrote:
> > > > > > > > > > >
> > > > > > > > > > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > > > > > > > > > Karol Herbst wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov 
> > > > > > > > > > > >  wrote:
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol 
> > > > > > > > > > > > > Herbst wrote:
> > > > > > > > > > > > > > in what way does it stop? Just not progressing? 
> > > > > > > > > > > > > > That would be kinda
> > > > > > > > > > > > > > concerning. Mind tracing with what arguments 
> > > > > > > > > > > > > > `nvkm_uevent_add` is
> > > > > > > > > > > > > > called with and without that patch?
> > > > > > > > > > > > >
> > > > > > > > > > > > > Well, me dumping those args I guess made the box not 
> > > > > > > > > > > > > freeze before
> > > > > > > > > > > > > catching a #PF over serial. Does that help?
> > > > > > > > > > > > >
> > > > > > > > > > > > > 
> > > > > > > > > > > > > [3.410135] Unpacking initramfs...
> > > > > > > > > > > > > [3.416319] software IO TLB: mapped [mem 
> > > > > > > > > > > > > 0xa877d000-0xac77d000] (64MB)
> > > > > > > > > > > > > [3.418227] Initialise system trusted keyrings
> > > > > > > > > > > > > [3.432273] workingset: timestamp_bits=56 
> > > > > > > > > > > > > max_order=22 bucket_order=0
> > > > > > > > > > > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > > > > > > > > > > [3.443368] fuse: init (API version 7.38)
> > > > > > > > > > > > > [3.447601] 9p: Installing v9fs 9p2000 file system 
> > > > > > > > > > > > > support
> > > > > > > > > > > > > [3.453223] Key type asymmetric registered
> > > > > > > > > > > > > [3.457332] Asymmetric key parser 'x509' registered
> > > > > > > > > > > > > [3.462236] Block layer SCSI generic (bsg) driver 
> > > > > > > > > > > > > version 0.4 loaded (major 250)
> > > > > > > > > > > > > [3.475865] efifb: probing for efifb
> > > > > > > > > > > > > [3.479458] efifb: framebuffer at 0xf900, 
> > > > > > > > > > > > > using 1920k, total 1920k
> > > > > > > > > > > > > [3.485969] efifb: mode is 800x600x32, 
> > > > > > > > > > > > > linelength=3200, pages=1
> > > > > > > > > > > > > [3.491872] efifb: scrolling: redraw
> > > > > > > > > > > > > [3.495438] efifb: Truecolor: size=8:8:8:8, 
> > > > > > > > > > > > > shift=24:16:8:0
> > > > > > > > > > > > > [3.502349] Console: switching to colour frame 
> > > > > > > > > > > > > buffer device 100x37
> > > > > > > > > > > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > > > > > > > > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > > > > > > > > > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > > > > > > > > > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > > > > > > > > > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > > > > > > > > > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > > > > > > > > > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > > > > > > > > > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > > > > > > > > > > > [3.544219] Freeing initrd memory: 8196K
> > > > > > > > > > > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > > > > > > > > > > > [3.609542] Serial: 8250/16550 driver, 4 ports, 
> > > > > > > > > > > > > IRQ sharing enabled
> > > > > > > > > > > > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, 
> > > > > > > > > > > > > base_baud = 115200) is a 16550A
> > > > > > > > > > > > > [3.625552] serial :00:16.3: enabling device 
> > > > > > > > > > > > > ( -> 0003)
> > > > > > > > > > > > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq 
> > > > > > > > > > > > > = 17, base_baud = 115200) is a 16550A
> > > > > > > > > > > > > [3.642451] Linux agpgart interface v0.103
> > > > > > > > > > > > > [3.647141] ACPI: bus type drm_connector registered
> > > > > > > > > > > > > [3.653261] Console: switching to colour 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Tue, Aug 8, 2023 at 3:47 PM Borislav Petkov  wrote:
>
> On Tue, Aug 08, 2023 at 12:39:32PM +0200, Karol Herbst wrote:
> > ahh, that would have been good to know :)
>
> Yeah, I didn't see it before - it would only freeze. Only after I added
> the printk you requested.
>
> > Mind figuring out what's exactly NULL inside nvif_object_mthd? Or
> > rather what line `nvif_object_mthd+0x136` belongs to, then it should
> > be easy to figure out what's wrong here.
>
> That looks like this:
>
> 816ddfee:   e8 8d 04 4e 00  callq  81bbe480 
> <__memcpy>
> 816ddff3:   41 8d 56 20 lea0x20(%r14),%edx
> 816ddff7:   49 8b 44 24 08  mov0x8(%r12),%rax
> 816ddffc:   83 fa 17cmp$0x17,%edx
> 816ddfff:   76 7d   jbe816de07e 
> 
> 816de001:   49 39 c4cmp%rax,%r12
> 816de004:   74 45   je 816de04b 
> 
>
> <--- RIP points here.
>
> The 0x20 also fits the deref address: 0020.
>
> Which means %rax is 0. Yap.
>
> 816de006:   48 8b 78 20 mov0x20(%rax),%rdi
> 816de00a:   4c 89 64 24 10  mov%r12,0x10(%rsp)
> 816de00f:   48 8b 40 38 mov0x38(%rax),%rax
> 816de013:   c6 44 24 06 ff  movb   $0xff,0x6(%rsp)
> 816de018:   31 c9   xor%ecx,%ecx
> 816de01a:   48 89 e6mov%rsp,%rsi
> 816de01d:   48 8b 40 28 mov0x28(%rax),%rax
> 816de021:   e8 3a 0c 4f 00  callq  81bcec60 
> <__x86_indirect_thunk_array>
>
>
> Now, the preprocessed asm version of nvif/object.c says around here:
>
>
> callmemcpy  #
> # drivers/gpu/drm/nouveau/nvif/object.c:160:ret = 
> nvif_object_ioctl(object, args, sizeof(*args) + size, NULL);
> leal32(%r14), %edx  #, _108
> # drivers/gpu/drm/nouveau/nvif/object.c:33: struct nvif_client *client = 
> object->client;
> movq8(%r12), %rax   # object_19(D)->client, client
> # drivers/gpu/drm/nouveau/nvif/object.c:38: if (size >= sizeof(*args) && 
> args->v0.version == 0) {
> cmpl$23, %edx   #, _108
> jbe .L69#,
> # drivers/gpu/drm/nouveau/nvif/object.c:39: if (object != 
> >object)
> cmpq%rax, %r12  # client, object
> je  .L70#,
> # drivers/gpu/drm/nouveau/nvif/object.c:47: return 
> client->driver->ioctl(client->object.priv, data, size, hack);
> movq32(%rax), %rdi  # client_109->object.priv, 
> client_109->object.priv
>
>
> So I'd say that client is NULL. IINM.
>
>
> movq%r12, 16(%rsp)  # object, MEM[(union  *)].v0.object
> # drivers/gpu/drm/nouveau/nvif/object.c:47: return 
> client->driver->ioctl(client->object.priv, data, size, hack);
> movq56(%rax), %rax  # client_109->driver, client_109->driver
> # drivers/gpu/drm/nouveau/nvif/object.c:43: args->v0.owner = 
> NVIF_IOCTL_V0_OWNER_ANY;
> movb$-1, 6(%rsp)#, MEM[(union  *)].v0.owner
> .L64:
> # drivers/gpu/drm/nouveau/nvif/object.c:47: return 
> client->driver->ioctl(client->object.priv, data, size, hack);
> xorl%ecx, %ecx  #
> movq%rsp, %rsi  #,
> movq40(%rax), %rax  #, _77->ioctl
> call__x86_indirect_thunk_rax
> # drivers/gpu/drm/nouveau/nvif/object.c:161:memcpy(data, args->mthd.data, 
> size);
>
> > > [4.144676] #PF: supervisor read access in kernel mode
> > > [4.144676] #PF: error_code(0x) - not-present page
> > > [4.144676] PGD 0 P4D 0
> > > [4.144676] Oops:  [#1] PREEMPT SMP PTI
> > > [4.144676] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 6.5.0-rc5-dirty 
> > > #1
> > > [4.144676] Hardware name: Dell Inc. Precision T3600/0PTTT9, BIOS A13 
> > > 05/11/2014
> > > [4.144676] RIP: 0010:nvif_object_mthd+0x136/0x1e0
> > > [4.144676] Code: f2 4c 89 ee 48 8d 7c 24 20 66 89 04 24 c6 44 24 18 
> > > 00 e8 8d 04 4e 00 41 8d 56 20 49 8b 44 24 08 83 fa 17 76 7d 49 39 c4 74 
> > > 45 <48> 8b 78 20 4c 89 64 24 10 48 8b 40 38 c6 44 24 06 ff 31 c9 48 89
>
> Opcode bytes around RIP look correct too:
>
> ./scripts/decodecode < /tmp/oops
> [ 4.144676] Code: f2 4c 89 ee 48 8d 7c 24 20 66 89 04 24 c6 44 24 18 00 e8 8d 
> 04 4e 00 41 8d 56 20 49 8b 44 24 08 83 fa 17 76 7d 49 39 c4 74 45 <48> 8b 78 
> 20 4c 89 64 24 10 48 8b 40 38 c6 44 24 06 ff 31 c9 48 89
> All code
> 
>0:   f2 4c 89 ee repnz mov %r13,%rsi
>4:   48 8d 7c 24 20  lea0x20(%rsp),%rdi
>9:   66 89 04 24 mov%ax,(%rsp)
>d:   c6 44 24 18 00  movb   $0x0,0x18(%rsp)
>   12:   e8 8d 04 4e 00  callq  0x4e04a4
>   17:   41 8d 56 20 lea0x20(%r14),%edx
>   1b:   49 8b 44 24 08  mov0x8(%r12),%rax
>   20: 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Mon, Aug 14, 2023 at 2:56 PM Karol Herbst  wrote:
>
> On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai  wrote:
> >
> > On Mon, 14 Aug 2023 14:38:18 +0200,
> > Karol Herbst wrote:
> > >
> > > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai  wrote:
> > > >
> > > > On Wed, 09 Aug 2023 16:46:38 +0200,
> > > > Takashi Iwai wrote:
> > > > >
> > > > > On Wed, 09 Aug 2023 15:13:23 +0200,
> > > > > Takashi Iwai wrote:
> > > > > >
> > > > > > On Wed, 09 Aug 2023 14:19:23 +0200,
> > > > > > Karol Herbst wrote:
> > > > > > >
> > > > > > > On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai  wrote:
> > > > > > > >
> > > > > > > > On Wed, 09 Aug 2023 13:42:09 +0200,
> > > > > > > > Karol Herbst wrote:
> > > > > > > > >
> > > > > > > > > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai  
> > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > > > > > > > > Karol Herbst wrote:
> > > > > > > > > > >
> > > > > > > > > > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov 
> > > > > > > > > > >  wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst 
> > > > > > > > > > > > wrote:
> > > > > > > > > > > > > in what way does it stop? Just not progressing? That 
> > > > > > > > > > > > > would be kinda
> > > > > > > > > > > > > concerning. Mind tracing with what arguments 
> > > > > > > > > > > > > `nvkm_uevent_add` is
> > > > > > > > > > > > > called with and without that patch?
> > > > > > > > > > > >
> > > > > > > > > > > > Well, me dumping those args I guess made the box not 
> > > > > > > > > > > > freeze before
> > > > > > > > > > > > catching a #PF over serial. Does that help?
> > > > > > > > > > > >
> > > > > > > > > > > > 
> > > > > > > > > > > > [3.410135] Unpacking initramfs...
> > > > > > > > > > > > [3.416319] software IO TLB: mapped [mem 
> > > > > > > > > > > > 0xa877d000-0xac77d000] (64MB)
> > > > > > > > > > > > [3.418227] Initialise system trusted keyrings
> > > > > > > > > > > > [3.432273] workingset: timestamp_bits=56 
> > > > > > > > > > > > max_order=22 bucket_order=0
> > > > > > > > > > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > > > > > > > > > [3.443368] fuse: init (API version 7.38)
> > > > > > > > > > > > [3.447601] 9p: Installing v9fs 9p2000 file system 
> > > > > > > > > > > > support
> > > > > > > > > > > > [3.453223] Key type asymmetric registered
> > > > > > > > > > > > [3.457332] Asymmetric key parser 'x509' registered
> > > > > > > > > > > > [3.462236] Block layer SCSI generic (bsg) driver 
> > > > > > > > > > > > version 0.4 loaded (major 250)
> > > > > > > > > > > > [3.475865] efifb: probing for efifb
> > > > > > > > > > > > [3.479458] efifb: framebuffer at 0xf900, using 
> > > > > > > > > > > > 1920k, total 1920k
> > > > > > > > > > > > [3.485969] efifb: mode is 800x600x32, 
> > > > > > > > > > > > linelength=3200, pages=1
> > > > > > > > > > > > [3.491872] efifb: scrolling: redraw
> > > > > > > > > > > > [3.495438] efifb: Truecolor: size=8:8:8:8, 
> > > > > > > > > > > > shift=24:16:8:0
> > > > > > > > > > > > [3.502349] Console: switching to colour frame 
> > > > > > > > > > > > buffer device 100x37
> > > > > > > > > > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > > > > > > > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > > > > > > > > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > > > > > > > > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > > > > > > > > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > > > > > > > > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > > > > > > > > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > > > > > > > > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > > > > > > > > > > [3.544219] Freeing initrd memory: 8196K
> > > > > > > > > > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > > > > > > > > > > [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ 
> > > > > > > > > > > > sharing enabled
> > > > > > > > > > > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, 
> > > > > > > > > > > > base_baud = 115200) is a 16550A
> > > > > > > > > > > > [3.625552] serial :00:16.3: enabling device 
> > > > > > > > > > > > ( -> 0003)
> > > > > > > > > > > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 
> > > > > > > > > > > > 17, base_baud = 115200) is a 16550A
> > > > > > > > > > > > [3.642451] Linux agpgart interface v0.103
> > > > > > > > > > > > [3.647141] ACPI: bus type drm_connector registered
> > > > > > > > > > > > [3.653261] Console: switching to colour dummy 
> > > > > > > > > > > > device 80x25
> > > > > > > > > > > > [3.659092] nouveau :03:00.0: vgaarb: deactivate 
> > > > > > > > > > > > vga console
> > > > > > > > > > > > [3.665174] nouveau :03:00.0: NVIDIA GT218 
> > > > > > > > > > > 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Mon, Aug 14, 2023 at 2:48 PM Takashi Iwai  wrote:
>
> On Mon, 14 Aug 2023 14:38:18 +0200,
> Karol Herbst wrote:
> >
> > On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai  wrote:
> > >
> > > On Wed, 09 Aug 2023 16:46:38 +0200,
> > > Takashi Iwai wrote:
> > > >
> > > > On Wed, 09 Aug 2023 15:13:23 +0200,
> > > > Takashi Iwai wrote:
> > > > >
> > > > > On Wed, 09 Aug 2023 14:19:23 +0200,
> > > > > Karol Herbst wrote:
> > > > > >
> > > > > > On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai  wrote:
> > > > > > >
> > > > > > > On Wed, 09 Aug 2023 13:42:09 +0200,
> > > > > > > Karol Herbst wrote:
> > > > > > > >
> > > > > > > > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai  
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > > > > > > > Karol Herbst wrote:
> > > > > > > > > >
> > > > > > > > > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov 
> > > > > > > > > >  wrote:
> > > > > > > > > > >
> > > > > > > > > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst 
> > > > > > > > > > > wrote:
> > > > > > > > > > > > in what way does it stop? Just not progressing? That 
> > > > > > > > > > > > would be kinda
> > > > > > > > > > > > concerning. Mind tracing with what arguments 
> > > > > > > > > > > > `nvkm_uevent_add` is
> > > > > > > > > > > > called with and without that patch?
> > > > > > > > > > >
> > > > > > > > > > > Well, me dumping those args I guess made the box not 
> > > > > > > > > > > freeze before
> > > > > > > > > > > catching a #PF over serial. Does that help?
> > > > > > > > > > >
> > > > > > > > > > > 
> > > > > > > > > > > [3.410135] Unpacking initramfs...
> > > > > > > > > > > [3.416319] software IO TLB: mapped [mem 
> > > > > > > > > > > 0xa877d000-0xac77d000] (64MB)
> > > > > > > > > > > [3.418227] Initialise system trusted keyrings
> > > > > > > > > > > [3.432273] workingset: timestamp_bits=56 max_order=22 
> > > > > > > > > > > bucket_order=0
> > > > > > > > > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > > > > > > > > [3.443368] fuse: init (API version 7.38)
> > > > > > > > > > > [3.447601] 9p: Installing v9fs 9p2000 file system 
> > > > > > > > > > > support
> > > > > > > > > > > [3.453223] Key type asymmetric registered
> > > > > > > > > > > [3.457332] Asymmetric key parser 'x509' registered
> > > > > > > > > > > [3.462236] Block layer SCSI generic (bsg) driver 
> > > > > > > > > > > version 0.4 loaded (major 250)
> > > > > > > > > > > [3.475865] efifb: probing for efifb
> > > > > > > > > > > [3.479458] efifb: framebuffer at 0xf900, using 
> > > > > > > > > > > 1920k, total 1920k
> > > > > > > > > > > [3.485969] efifb: mode is 800x600x32, 
> > > > > > > > > > > linelength=3200, pages=1
> > > > > > > > > > > [3.491872] efifb: scrolling: redraw
> > > > > > > > > > > [3.495438] efifb: Truecolor: size=8:8:8:8, 
> > > > > > > > > > > shift=24:16:8:0
> > > > > > > > > > > [3.502349] Console: switching to colour frame buffer 
> > > > > > > > > > > device 100x37
> > > > > > > > > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > > > > > > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > > > > > > > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > > > > > > > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > > > > > > > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > > > > > > > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > > > > > > > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > > > > > > > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > > > > > > > > > [3.544219] Freeing initrd memory: 8196K
> > > > > > > > > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > > > > > > > > > [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ 
> > > > > > > > > > > sharing enabled
> > > > > > > > > > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, 
> > > > > > > > > > > base_baud = 115200) is a 16550A
> > > > > > > > > > > [3.625552] serial :00:16.3: enabling device ( 
> > > > > > > > > > > -> 0003)
> > > > > > > > > > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 
> > > > > > > > > > > 17, base_baud = 115200) is a 16550A
> > > > > > > > > > > [3.642451] Linux agpgart interface v0.103
> > > > > > > > > > > [3.647141] ACPI: bus type drm_connector registered
> > > > > > > > > > > [3.653261] Console: switching to colour dummy device 
> > > > > > > > > > > 80x25
> > > > > > > > > > > [3.659092] nouveau :03:00.0: vgaarb: deactivate 
> > > > > > > > > > > vga console
> > > > > > > > > > > [3.665174] nouveau :03:00.0: NVIDIA GT218 
> > > > > > > > > > > (0a8c00b1)
> > > > > > > > > > > [3.784585] nouveau :03:00.0: bios: version 
> > > > > > > > > > > 70.18.83.00.08
> > > > > > > > > > > [3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
> > > > > > > > > > > [3.948786] 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Takashi Iwai
On Mon, 14 Aug 2023 14:38:18 +0200,
Karol Herbst wrote:
> 
> On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai  wrote:
> >
> > On Wed, 09 Aug 2023 16:46:38 +0200,
> > Takashi Iwai wrote:
> > >
> > > On Wed, 09 Aug 2023 15:13:23 +0200,
> > > Takashi Iwai wrote:
> > > >
> > > > On Wed, 09 Aug 2023 14:19:23 +0200,
> > > > Karol Herbst wrote:
> > > > >
> > > > > On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai  wrote:
> > > > > >
> > > > > > On Wed, 09 Aug 2023 13:42:09 +0200,
> > > > > > Karol Herbst wrote:
> > > > > > >
> > > > > > > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai  
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > > > > > > Karol Herbst wrote:
> > > > > > > > >
> > > > > > > > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov 
> > > > > > > > >  wrote:
> > > > > > > > > >
> > > > > > > > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst 
> > > > > > > > > > wrote:
> > > > > > > > > > > in what way does it stop? Just not progressing? That 
> > > > > > > > > > > would be kinda
> > > > > > > > > > > concerning. Mind tracing with what arguments 
> > > > > > > > > > > `nvkm_uevent_add` is
> > > > > > > > > > > called with and without that patch?
> > > > > > > > > >
> > > > > > > > > > Well, me dumping those args I guess made the box not freeze 
> > > > > > > > > > before
> > > > > > > > > > catching a #PF over serial. Does that help?
> > > > > > > > > >
> > > > > > > > > > 
> > > > > > > > > > [3.410135] Unpacking initramfs...
> > > > > > > > > > [3.416319] software IO TLB: mapped [mem 
> > > > > > > > > > 0xa877d000-0xac77d000] (64MB)
> > > > > > > > > > [3.418227] Initialise system trusted keyrings
> > > > > > > > > > [3.432273] workingset: timestamp_bits=56 max_order=22 
> > > > > > > > > > bucket_order=0
> > > > > > > > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > > > > > > > [3.443368] fuse: init (API version 7.38)
> > > > > > > > > > [3.447601] 9p: Installing v9fs 9p2000 file system 
> > > > > > > > > > support
> > > > > > > > > > [3.453223] Key type asymmetric registered
> > > > > > > > > > [3.457332] Asymmetric key parser 'x509' registered
> > > > > > > > > > [3.462236] Block layer SCSI generic (bsg) driver 
> > > > > > > > > > version 0.4 loaded (major 250)
> > > > > > > > > > [3.475865] efifb: probing for efifb
> > > > > > > > > > [3.479458] efifb: framebuffer at 0xf900, using 
> > > > > > > > > > 1920k, total 1920k
> > > > > > > > > > [3.485969] efifb: mode is 800x600x32, linelength=3200, 
> > > > > > > > > > pages=1
> > > > > > > > > > [3.491872] efifb: scrolling: redraw
> > > > > > > > > > [3.495438] efifb: Truecolor: size=8:8:8:8, 
> > > > > > > > > > shift=24:16:8:0
> > > > > > > > > > [3.502349] Console: switching to colour frame buffer 
> > > > > > > > > > device 100x37
> > > > > > > > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > > > > > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > > > > > > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > > > > > > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > > > > > > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > > > > > > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > > > > > > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > > > > > > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > > > > > > > > [3.544219] Freeing initrd memory: 8196K
> > > > > > > > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > > > > > > > > [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ 
> > > > > > > > > > sharing enabled
> > > > > > > > > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, 
> > > > > > > > > > base_baud = 115200) is a 16550A
> > > > > > > > > > [3.625552] serial :00:16.3: enabling device ( 
> > > > > > > > > > -> 0003)
> > > > > > > > > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, 
> > > > > > > > > > base_baud = 115200) is a 16550A
> > > > > > > > > > [3.642451] Linux agpgart interface v0.103
> > > > > > > > > > [3.647141] ACPI: bus type drm_connector registered
> > > > > > > > > > [3.653261] Console: switching to colour dummy device 
> > > > > > > > > > 80x25
> > > > > > > > > > [3.659092] nouveau :03:00.0: vgaarb: deactivate vga 
> > > > > > > > > > console
> > > > > > > > > > [3.665174] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> > > > > > > > > > [3.784585] nouveau :03:00.0: bios: version 
> > > > > > > > > > 70.18.83.00.08
> > > > > > > > > > [3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
> > > > > > > > > > [3.948786] nouveau :03:00.0: DRM: VRAM: 512 MiB
> > > > > > > > > > [3.953755] nouveau :03:00.0: DRM: GART: 1048576 MiB
> > > > > > > > > > [3.959073] nouveau :03:00.0: DRM: TMDS table 
> > > > > > > > > > version 2.0
> > > > > > > > > > [3.964808] 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-14 Thread Karol Herbst
On Wed, Aug 9, 2023 at 6:16 PM Takashi Iwai  wrote:
>
> On Wed, 09 Aug 2023 16:46:38 +0200,
> Takashi Iwai wrote:
> >
> > On Wed, 09 Aug 2023 15:13:23 +0200,
> > Takashi Iwai wrote:
> > >
> > > On Wed, 09 Aug 2023 14:19:23 +0200,
> > > Karol Herbst wrote:
> > > >
> > > > On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai  wrote:
> > > > >
> > > > > On Wed, 09 Aug 2023 13:42:09 +0200,
> > > > > Karol Herbst wrote:
> > > > > >
> > > > > > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai  wrote:
> > > > > > >
> > > > > > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > > > > > Karol Herbst wrote:
> > > > > > > >
> > > > > > > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov  
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> > > > > > > > > > in what way does it stop? Just not progressing? That would 
> > > > > > > > > > be kinda
> > > > > > > > > > concerning. Mind tracing with what arguments 
> > > > > > > > > > `nvkm_uevent_add` is
> > > > > > > > > > called with and without that patch?
> > > > > > > > >
> > > > > > > > > Well, me dumping those args I guess made the box not freeze 
> > > > > > > > > before
> > > > > > > > > catching a #PF over serial. Does that help?
> > > > > > > > >
> > > > > > > > > 
> > > > > > > > > [3.410135] Unpacking initramfs...
> > > > > > > > > [3.416319] software IO TLB: mapped [mem 
> > > > > > > > > 0xa877d000-0xac77d000] (64MB)
> > > > > > > > > [3.418227] Initialise system trusted keyrings
> > > > > > > > > [3.432273] workingset: timestamp_bits=56 max_order=22 
> > > > > > > > > bucket_order=0
> > > > > > > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > > > > > > [3.443368] fuse: init (API version 7.38)
> > > > > > > > > [3.447601] 9p: Installing v9fs 9p2000 file system support
> > > > > > > > > [3.453223] Key type asymmetric registered
> > > > > > > > > [3.457332] Asymmetric key parser 'x509' registered
> > > > > > > > > [3.462236] Block layer SCSI generic (bsg) driver version 
> > > > > > > > > 0.4 loaded (major 250)
> > > > > > > > > [3.475865] efifb: probing for efifb
> > > > > > > > > [3.479458] efifb: framebuffer at 0xf900, using 1920k, 
> > > > > > > > > total 1920k
> > > > > > > > > [3.485969] efifb: mode is 800x600x32, linelength=3200, 
> > > > > > > > > pages=1
> > > > > > > > > [3.491872] efifb: scrolling: redraw
> > > > > > > > > [3.495438] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
> > > > > > > > > [3.502349] Console: switching to colour frame buffer 
> > > > > > > > > device 100x37
> > > > > > > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > > > > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > > > > > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > > > > > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > > > > > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > > > > > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > > > > > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > > > > > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > > > > > > > [3.544219] Freeing initrd memory: 8196K
> > > > > > > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > > > > > > > [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ 
> > > > > > > > > sharing enabled
> > > > > > > > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud 
> > > > > > > > > = 115200) is a 16550A
> > > > > > > > > [3.625552] serial :00:16.3: enabling device ( -> 
> > > > > > > > > 0003)
> > > > > > > > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, 
> > > > > > > > > base_baud = 115200) is a 16550A
> > > > > > > > > [3.642451] Linux agpgart interface v0.103
> > > > > > > > > [3.647141] ACPI: bus type drm_connector registered
> > > > > > > > > [3.653261] Console: switching to colour dummy device 80x25
> > > > > > > > > [3.659092] nouveau :03:00.0: vgaarb: deactivate vga 
> > > > > > > > > console
> > > > > > > > > [3.665174] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> > > > > > > > > [3.784585] nouveau :03:00.0: bios: version 
> > > > > > > > > 70.18.83.00.08
> > > > > > > > > [3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
> > > > > > > > > [3.948786] nouveau :03:00.0: DRM: VRAM: 512 MiB
> > > > > > > > > [3.953755] nouveau :03:00.0: DRM: GART: 1048576 MiB
> > > > > > > > > [3.959073] nouveau :03:00.0: DRM: TMDS table version 
> > > > > > > > > 2.0
> > > > > > > > > [3.964808] nouveau :03:00.0: DRM: DCB version 4.0
> > > > > > > > > [3.969938] nouveau :03:00.0: DRM: DCB outp 00: 
> > > > > > > > > 02000360 
> > > > > > > > > [3.976367] nouveau :03:00.0: DRM: DCB outp 01: 
> > > > > > > > > 02000362 00020010
> > > > > > > > > [3.982792] nouveau :03:00.0: DRM: DCB outp 02: 
> > > > 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-09 Thread Karol Herbst
On Wed, Aug 9, 2023 at 8:28 PM Karol Herbst  wrote:
>
> On Wed, Aug 9, 2023 at 4:04 PM Thorsten Leemhuis
>  wrote:
> >
> > On 09.08.23 15:13, Takashi Iwai wrote:
> > >
> > > If this can't be fixed quickly, I suppose it's safer to revert it from
> > > 6.4.y for now.  6.5 is still being cooked, but 6.4.x is already in
> > > wide deployment, hence the regression has to be addressed quickly.
> >
>
> feel free to send reverts to mainline and add my r-by tage to it and I
> can push those changes up. Sadly those patches fixed another
> use-after-free, but it seems like we have to take another shot unless
> somebody does have time to look into it promptly.
>

uhm and the two patches around that one,
752a281032b2d6f4564be827e082bde6f7d2fd4fand
ea293f823a8805735d9e00124df81a8f448ed1ae

> > Good luck with that. To quote
> > https://docs.kernel.org/process/handling-regressions.html :
> >
> > ```
> > Regarding stable and longterm kernels:
> >
> > [...]
> >
> > * Whenever you want to swiftly resolve a regression that recently also
> > made it into a proper mainline, stable, or longterm release, fix it
> > quickly in mainline; when appropriate thus involve Linus to fast-track
> > the fix (see above). That's because the stable team normally does
> > neither revert nor fix any changes that cause the same problems in mainline.
> > ```
> >
> > Note the "normally" in there, so there is a chance.
> >
> > Ciao, Thorsten
> >



Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-09 Thread Karol Herbst
On Wed, Aug 9, 2023 at 4:04 PM Thorsten Leemhuis
 wrote:
>
> On 09.08.23 15:13, Takashi Iwai wrote:
> >
> > If this can't be fixed quickly, I suppose it's safer to revert it from
> > 6.4.y for now.  6.5 is still being cooked, but 6.4.x is already in
> > wide deployment, hence the regression has to be addressed quickly.
>

feel free to send reverts to mainline and add my r-by tage to it and I
can push those changes up. Sadly those patches fixed another
use-after-free, but it seems like we have to take another shot unless
somebody does have time to look into it promptly.

> Good luck with that. To quote
> https://docs.kernel.org/process/handling-regressions.html :
>
> ```
> Regarding stable and longterm kernels:
>
> [...]
>
> * Whenever you want to swiftly resolve a regression that recently also
> made it into a proper mainline, stable, or longterm release, fix it
> quickly in mainline; when appropriate thus involve Linus to fast-track
> the fix (see above). That's because the stable team normally does
> neither revert nor fix any changes that cause the same problems in mainline.
> ```
>
> Note the "normally" in there, so there is a chance.
>
> Ciao, Thorsten
>



Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-09 Thread Takashi Iwai
On Wed, 09 Aug 2023 16:46:38 +0200,
Takashi Iwai wrote:
> 
> On Wed, 09 Aug 2023 15:13:23 +0200,
> Takashi Iwai wrote:
> > 
> > On Wed, 09 Aug 2023 14:19:23 +0200,
> > Karol Herbst wrote:
> > > 
> > > On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai  wrote:
> > > >
> > > > On Wed, 09 Aug 2023 13:42:09 +0200,
> > > > Karol Herbst wrote:
> > > > >
> > > > > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai  wrote:
> > > > > >
> > > > > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > > > > Karol Herbst wrote:
> > > > > > >
> > > > > > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov  
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> > > > > > > > > in what way does it stop? Just not progressing? That would be 
> > > > > > > > > kinda
> > > > > > > > > concerning. Mind tracing with what arguments 
> > > > > > > > > `nvkm_uevent_add` is
> > > > > > > > > called with and without that patch?
> > > > > > > >
> > > > > > > > Well, me dumping those args I guess made the box not freeze 
> > > > > > > > before
> > > > > > > > catching a #PF over serial. Does that help?
> > > > > > > >
> > > > > > > > 
> > > > > > > > [3.410135] Unpacking initramfs...
> > > > > > > > [3.416319] software IO TLB: mapped [mem 
> > > > > > > > 0xa877d000-0xac77d000] (64MB)
> > > > > > > > [3.418227] Initialise system trusted keyrings
> > > > > > > > [3.432273] workingset: timestamp_bits=56 max_order=22 
> > > > > > > > bucket_order=0
> > > > > > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > > > > > [3.443368] fuse: init (API version 7.38)
> > > > > > > > [3.447601] 9p: Installing v9fs 9p2000 file system support
> > > > > > > > [3.453223] Key type asymmetric registered
> > > > > > > > [3.457332] Asymmetric key parser 'x509' registered
> > > > > > > > [3.462236] Block layer SCSI generic (bsg) driver version 
> > > > > > > > 0.4 loaded (major 250)
> > > > > > > > [3.475865] efifb: probing for efifb
> > > > > > > > [3.479458] efifb: framebuffer at 0xf900, using 1920k, 
> > > > > > > > total 1920k
> > > > > > > > [3.485969] efifb: mode is 800x600x32, linelength=3200, 
> > > > > > > > pages=1
> > > > > > > > [3.491872] efifb: scrolling: redraw
> > > > > > > > [3.495438] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
> > > > > > > > [3.502349] Console: switching to colour frame buffer device 
> > > > > > > > 100x37
> > > > > > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > > > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > > > > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > > > > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > > > > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > > > > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > > > > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > > > > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > > > > > > [3.544219] Freeing initrd memory: 8196K
> > > > > > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > > > > > > [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ sharing 
> > > > > > > > enabled
> > > > > > > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 
> > > > > > > > 115200) is a 16550A
> > > > > > > > [3.625552] serial :00:16.3: enabling device ( -> 
> > > > > > > > 0003)
> > > > > > > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, 
> > > > > > > > base_baud = 115200) is a 16550A
> > > > > > > > [3.642451] Linux agpgart interface v0.103
> > > > > > > > [3.647141] ACPI: bus type drm_connector registered
> > > > > > > > [3.653261] Console: switching to colour dummy device 80x25
> > > > > > > > [3.659092] nouveau :03:00.0: vgaarb: deactivate vga 
> > > > > > > > console
> > > > > > > > [3.665174] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> > > > > > > > [3.784585] nouveau :03:00.0: bios: version 
> > > > > > > > 70.18.83.00.08
> > > > > > > > [3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
> > > > > > > > [3.948786] nouveau :03:00.0: DRM: VRAM: 512 MiB
> > > > > > > > [3.953755] nouveau :03:00.0: DRM: GART: 1048576 MiB
> > > > > > > > [3.959073] nouveau :03:00.0: DRM: TMDS table version 2.0
> > > > > > > > [3.964808] nouveau :03:00.0: DRM: DCB version 4.0
> > > > > > > > [3.969938] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
> > > > > > > > 
> > > > > > > > [3.976367] nouveau :03:00.0: DRM: DCB outp 01: 02000362 
> > > > > > > > 00020010
> > > > > > > > [3.982792] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 
> > > > > > > > 0f220010
> > > > > > > > [3.989223] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
> > > > > > > > 
> > > > > > > > [3.995647] nouveau :03:00.0: DRM: DCB outp 04: 08011382 
> > > > > > > > 00020010
> > > > > > > > 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-09 Thread Takashi Iwai
On Wed, 09 Aug 2023 15:13:23 +0200,
Takashi Iwai wrote:
> 
> On Wed, 09 Aug 2023 14:19:23 +0200,
> Karol Herbst wrote:
> > 
> > On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai  wrote:
> > >
> > > On Wed, 09 Aug 2023 13:42:09 +0200,
> > > Karol Herbst wrote:
> > > >
> > > > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai  wrote:
> > > > >
> > > > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > > > Karol Herbst wrote:
> > > > > >
> > > > > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov  
> > > > > > wrote:
> > > > > > >
> > > > > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> > > > > > > > in what way does it stop? Just not progressing? That would be 
> > > > > > > > kinda
> > > > > > > > concerning. Mind tracing with what arguments `nvkm_uevent_add` 
> > > > > > > > is
> > > > > > > > called with and without that patch?
> > > > > > >
> > > > > > > Well, me dumping those args I guess made the box not freeze before
> > > > > > > catching a #PF over serial. Does that help?
> > > > > > >
> > > > > > > 
> > > > > > > [3.410135] Unpacking initramfs...
> > > > > > > [3.416319] software IO TLB: mapped [mem 
> > > > > > > 0xa877d000-0xac77d000] (64MB)
> > > > > > > [3.418227] Initialise system trusted keyrings
> > > > > > > [3.432273] workingset: timestamp_bits=56 max_order=22 
> > > > > > > bucket_order=0
> > > > > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > > > > [3.443368] fuse: init (API version 7.38)
> > > > > > > [3.447601] 9p: Installing v9fs 9p2000 file system support
> > > > > > > [3.453223] Key type asymmetric registered
> > > > > > > [3.457332] Asymmetric key parser 'x509' registered
> > > > > > > [3.462236] Block layer SCSI generic (bsg) driver version 0.4 
> > > > > > > loaded (major 250)
> > > > > > > [3.475865] efifb: probing for efifb
> > > > > > > [3.479458] efifb: framebuffer at 0xf900, using 1920k, 
> > > > > > > total 1920k
> > > > > > > [3.485969] efifb: mode is 800x600x32, linelength=3200, pages=1
> > > > > > > [3.491872] efifb: scrolling: redraw
> > > > > > > [3.495438] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
> > > > > > > [3.502349] Console: switching to colour frame buffer device 
> > > > > > > 100x37
> > > > > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > > > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > > > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > > > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > > > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > > > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > > > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > > > > > [3.544219] Freeing initrd memory: 8196K
> > > > > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > > > > > [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ sharing 
> > > > > > > enabled
> > > > > > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 
> > > > > > > 115200) is a 16550A
> > > > > > > [3.625552] serial :00:16.3: enabling device ( -> 0003)
> > > > > > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, 
> > > > > > > base_baud = 115200) is a 16550A
> > > > > > > [3.642451] Linux agpgart interface v0.103
> > > > > > > [3.647141] ACPI: bus type drm_connector registered
> > > > > > > [3.653261] Console: switching to colour dummy device 80x25
> > > > > > > [3.659092] nouveau :03:00.0: vgaarb: deactivate vga 
> > > > > > > console
> > > > > > > [3.665174] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> > > > > > > [3.784585] nouveau :03:00.0: bios: version 70.18.83.00.08
> > > > > > > [3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
> > > > > > > [3.948786] nouveau :03:00.0: DRM: VRAM: 512 MiB
> > > > > > > [3.953755] nouveau :03:00.0: DRM: GART: 1048576 MiB
> > > > > > > [3.959073] nouveau :03:00.0: DRM: TMDS table version 2.0
> > > > > > > [3.964808] nouveau :03:00.0: DRM: DCB version 4.0
> > > > > > > [3.969938] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
> > > > > > > 
> > > > > > > [3.976367] nouveau :03:00.0: DRM: DCB outp 01: 02000362 
> > > > > > > 00020010
> > > > > > > [3.982792] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 
> > > > > > > 0f220010
> > > > > > > [3.989223] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
> > > > > > > 
> > > > > > > [3.995647] nouveau :03:00.0: DRM: DCB outp 04: 08011382 
> > > > > > > 00020010
> > > > > > > [4.002076] nouveau :03:00.0: DRM: DCB outp 05: 088113c6 
> > > > > > > 0f220010
> > > > > > > [4.008511] nouveau :03:00.0: DRM: DCB conn 00: 00101064
> > > > > > > [4.014151] nouveau :03:00.0: DRM: DCB conn 01: 00202165
> > > > > > > [4.021710] nvkm_uevent_add: uevent: 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-09 Thread Thorsten Leemhuis
On 09.08.23 15:13, Takashi Iwai wrote:
> 
> If this can't be fixed quickly, I suppose it's safer to revert it from
> 6.4.y for now.  6.5 is still being cooked, but 6.4.x is already in
> wide deployment, hence the regression has to be addressed quickly.

Good luck with that. To quote
https://docs.kernel.org/process/handling-regressions.html :

```
Regarding stable and longterm kernels:

[...]

* Whenever you want to swiftly resolve a regression that recently also
made it into a proper mainline, stable, or longterm release, fix it
quickly in mainline; when appropriate thus involve Linus to fast-track
the fix (see above). That's because the stable team normally does
neither revert nor fix any changes that cause the same problems in mainline.
```

Note the "normally" in there, so there is a chance.

Ciao, Thorsten


Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-09 Thread Takashi Iwai
On Wed, 09 Aug 2023 14:19:23 +0200,
Karol Herbst wrote:
> 
> On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai  wrote:
> >
> > On Wed, 09 Aug 2023 13:42:09 +0200,
> > Karol Herbst wrote:
> > >
> > > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai  wrote:
> > > >
> > > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > > Karol Herbst wrote:
> > > > >
> > > > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov  wrote:
> > > > > >
> > > > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> > > > > > > in what way does it stop? Just not progressing? That would be 
> > > > > > > kinda
> > > > > > > concerning. Mind tracing with what arguments `nvkm_uevent_add` is
> > > > > > > called with and without that patch?
> > > > > >
> > > > > > Well, me dumping those args I guess made the box not freeze before
> > > > > > catching a #PF over serial. Does that help?
> > > > > >
> > > > > > 
> > > > > > [3.410135] Unpacking initramfs...
> > > > > > [3.416319] software IO TLB: mapped [mem 
> > > > > > 0xa877d000-0xac77d000] (64MB)
> > > > > > [3.418227] Initialise system trusted keyrings
> > > > > > [3.432273] workingset: timestamp_bits=56 max_order=22 
> > > > > > bucket_order=0
> > > > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > > > [3.443368] fuse: init (API version 7.38)
> > > > > > [3.447601] 9p: Installing v9fs 9p2000 file system support
> > > > > > [3.453223] Key type asymmetric registered
> > > > > > [3.457332] Asymmetric key parser 'x509' registered
> > > > > > [3.462236] Block layer SCSI generic (bsg) driver version 0.4 
> > > > > > loaded (major 250)
> > > > > > [3.475865] efifb: probing for efifb
> > > > > > [3.479458] efifb: framebuffer at 0xf900, using 1920k, total 
> > > > > > 1920k
> > > > > > [3.485969] efifb: mode is 800x600x32, linelength=3200, pages=1
> > > > > > [3.491872] efifb: scrolling: redraw
> > > > > > [3.495438] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
> > > > > > [3.502349] Console: switching to colour frame buffer device 
> > > > > > 100x37
> > > > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > > > > [3.544219] Freeing initrd memory: 8196K
> > > > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > > > > [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ sharing 
> > > > > > enabled
> > > > > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 
> > > > > > 115200) is a 16550A
> > > > > > [3.625552] serial :00:16.3: enabling device ( -> 0003)
> > > > > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, 
> > > > > > base_baud = 115200) is a 16550A
> > > > > > [3.642451] Linux agpgart interface v0.103
> > > > > > [3.647141] ACPI: bus type drm_connector registered
> > > > > > [3.653261] Console: switching to colour dummy device 80x25
> > > > > > [3.659092] nouveau :03:00.0: vgaarb: deactivate vga console
> > > > > > [3.665174] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> > > > > > [3.784585] nouveau :03:00.0: bios: version 70.18.83.00.08
> > > > > > [3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
> > > > > > [3.948786] nouveau :03:00.0: DRM: VRAM: 512 MiB
> > > > > > [3.953755] nouveau :03:00.0: DRM: GART: 1048576 MiB
> > > > > > [3.959073] nouveau :03:00.0: DRM: TMDS table version 2.0
> > > > > > [3.964808] nouveau :03:00.0: DRM: DCB version 4.0
> > > > > > [3.969938] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
> > > > > > 
> > > > > > [3.976367] nouveau :03:00.0: DRM: DCB outp 01: 02000362 
> > > > > > 00020010
> > > > > > [3.982792] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 
> > > > > > 0f220010
> > > > > > [3.989223] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
> > > > > > 
> > > > > > [3.995647] nouveau :03:00.0: DRM: DCB outp 04: 08011382 
> > > > > > 00020010
> > > > > > [4.002076] nouveau :03:00.0: DRM: DCB outp 05: 088113c6 
> > > > > > 0f220010
> > > > > > [4.008511] nouveau :03:00.0: DRM: DCB conn 00: 00101064
> > > > > > [4.014151] nouveau :03:00.0: DRM: DCB conn 01: 00202165
> > > > > > [4.021710] nvkm_uevent_add: uevent: 0x888100242100, event: 
> > > > > > 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> > > > > > [4.033680] nvkm_uevent_add: uevent: 0x888100242300, event: 
> > > > > > 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> > > > > > [4.045429] 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-09 Thread Karol Herbst
On Wed, Aug 9, 2023 at 1:46 PM Takashi Iwai  wrote:
>
> On Wed, 09 Aug 2023 13:42:09 +0200,
> Karol Herbst wrote:
> >
> > On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai  wrote:
> > >
> > > On Tue, 08 Aug 2023 12:39:32 +0200,
> > > Karol Herbst wrote:
> > > >
> > > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov  wrote:
> > > > >
> > > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> > > > > > in what way does it stop? Just not progressing? That would be kinda
> > > > > > concerning. Mind tracing with what arguments `nvkm_uevent_add` is
> > > > > > called with and without that patch?
> > > > >
> > > > > Well, me dumping those args I guess made the box not freeze before
> > > > > catching a #PF over serial. Does that help?
> > > > >
> > > > > 
> > > > > [3.410135] Unpacking initramfs...
> > > > > [3.416319] software IO TLB: mapped [mem 
> > > > > 0xa877d000-0xac77d000] (64MB)
> > > > > [3.418227] Initialise system trusted keyrings
> > > > > [3.432273] workingset: timestamp_bits=56 max_order=22 
> > > > > bucket_order=0
> > > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > > [3.443368] fuse: init (API version 7.38)
> > > > > [3.447601] 9p: Installing v9fs 9p2000 file system support
> > > > > [3.453223] Key type asymmetric registered
> > > > > [3.457332] Asymmetric key parser 'x509' registered
> > > > > [3.462236] Block layer SCSI generic (bsg) driver version 0.4 
> > > > > loaded (major 250)
> > > > > [3.475865] efifb: probing for efifb
> > > > > [3.479458] efifb: framebuffer at 0xf900, using 1920k, total 
> > > > > 1920k
> > > > > [3.485969] efifb: mode is 800x600x32, linelength=3200, pages=1
> > > > > [3.491872] efifb: scrolling: redraw
> > > > > [3.495438] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
> > > > > [3.502349] Console: switching to colour frame buffer device 100x37
> > > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > > > [3.544219] Freeing initrd memory: 8196K
> > > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > > > [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
> > > > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 
> > > > > 115200) is a 16550A
> > > > > [3.625552] serial :00:16.3: enabling device ( -> 0003)
> > > > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, base_baud 
> > > > > = 115200) is a 16550A
> > > > > [3.642451] Linux agpgart interface v0.103
> > > > > [3.647141] ACPI: bus type drm_connector registered
> > > > > [3.653261] Console: switching to colour dummy device 80x25
> > > > > [3.659092] nouveau :03:00.0: vgaarb: deactivate vga console
> > > > > [3.665174] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> > > > > [3.784585] nouveau :03:00.0: bios: version 70.18.83.00.08
> > > > > [3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
> > > > > [3.948786] nouveau :03:00.0: DRM: VRAM: 512 MiB
> > > > > [3.953755] nouveau :03:00.0: DRM: GART: 1048576 MiB
> > > > > [3.959073] nouveau :03:00.0: DRM: TMDS table version 2.0
> > > > > [3.964808] nouveau :03:00.0: DRM: DCB version 4.0
> > > > > [3.969938] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
> > > > > 
> > > > > [3.976367] nouveau :03:00.0: DRM: DCB outp 01: 02000362 
> > > > > 00020010
> > > > > [3.982792] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 
> > > > > 0f220010
> > > > > [3.989223] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
> > > > > 
> > > > > [3.995647] nouveau :03:00.0: DRM: DCB outp 04: 08011382 
> > > > > 00020010
> > > > > [4.002076] nouveau :03:00.0: DRM: DCB outp 05: 088113c6 
> > > > > 0f220010
> > > > > [4.008511] nouveau :03:00.0: DRM: DCB conn 00: 00101064
> > > > > [4.014151] nouveau :03:00.0: DRM: DCB conn 01: 00202165
> > > > > [4.021710] nvkm_uevent_add: uevent: 0x888100242100, event: 
> > > > > 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> > > > > [4.033680] nvkm_uevent_add: uevent: 0x888100242300, event: 
> > > > > 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> > > > > [4.045429] nouveau :03:00.0: DRM: MM: using COPY for buffer 
> > > > > copies
> > > > > [4.052059] stackdepot: allocating hash table of 1048576 entries 
> > > > > via kvcalloc
> > > > > [4.067191] nvkm_uevent_add: uevent: 0x888100242800, event: 
> > > > > 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-09 Thread Takashi Iwai
On Wed, 09 Aug 2023 13:42:09 +0200,
Karol Herbst wrote:
> 
> On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai  wrote:
> >
> > On Tue, 08 Aug 2023 12:39:32 +0200,
> > Karol Herbst wrote:
> > >
> > > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov  wrote:
> > > >
> > > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> > > > > in what way does it stop? Just not progressing? That would be kinda
> > > > > concerning. Mind tracing with what arguments `nvkm_uevent_add` is
> > > > > called with and without that patch?
> > > >
> > > > Well, me dumping those args I guess made the box not freeze before
> > > > catching a #PF over serial. Does that help?
> > > >
> > > > 
> > > > [3.410135] Unpacking initramfs...
> > > > [3.416319] software IO TLB: mapped [mem 
> > > > 0xa877d000-0xac77d000] (64MB)
> > > > [3.418227] Initialise system trusted keyrings
> > > > [3.432273] workingset: timestamp_bits=56 max_order=22 bucket_order=0
> > > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > > [3.443368] fuse: init (API version 7.38)
> > > > [3.447601] 9p: Installing v9fs 9p2000 file system support
> > > > [3.453223] Key type asymmetric registered
> > > > [3.457332] Asymmetric key parser 'x509' registered
> > > > [3.462236] Block layer SCSI generic (bsg) driver version 0.4 loaded 
> > > > (major 250)
> > > > [3.475865] efifb: probing for efifb
> > > > [3.479458] efifb: framebuffer at 0xf900, using 1920k, total 
> > > > 1920k
> > > > [3.485969] efifb: mode is 800x600x32, linelength=3200, pages=1
> > > > [3.491872] efifb: scrolling: redraw
> > > > [3.495438] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
> > > > [3.502349] Console: switching to colour frame buffer device 100x37
> > > > [3.509564] fb0: EFI VGA frame buffer device
> > > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > > [3.544219] Freeing initrd memory: 8196K
> > > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > > [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
> > > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) 
> > > > is a 16550A
> > > > [3.625552] serial :00:16.3: enabling device ( -> 0003)
> > > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, base_baud = 
> > > > 115200) is a 16550A
> > > > [3.642451] Linux agpgart interface v0.103
> > > > [3.647141] ACPI: bus type drm_connector registered
> > > > [3.653261] Console: switching to colour dummy device 80x25
> > > > [3.659092] nouveau :03:00.0: vgaarb: deactivate vga console
> > > > [3.665174] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> > > > [3.784585] nouveau :03:00.0: bios: version 70.18.83.00.08
> > > > [3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
> > > > [3.948786] nouveau :03:00.0: DRM: VRAM: 512 MiB
> > > > [3.953755] nouveau :03:00.0: DRM: GART: 1048576 MiB
> > > > [3.959073] nouveau :03:00.0: DRM: TMDS table version 2.0
> > > > [3.964808] nouveau :03:00.0: DRM: DCB version 4.0
> > > > [3.969938] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
> > > > [3.976367] nouveau :03:00.0: DRM: DCB outp 01: 02000362 00020010
> > > > [3.982792] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 0f220010
> > > > [3.989223] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
> > > > [3.995647] nouveau :03:00.0: DRM: DCB outp 04: 08011382 00020010
> > > > [4.002076] nouveau :03:00.0: DRM: DCB outp 05: 088113c6 0f220010
> > > > [4.008511] nouveau :03:00.0: DRM: DCB conn 00: 00101064
> > > > [4.014151] nouveau :03:00.0: DRM: DCB conn 01: 00202165
> > > > [4.021710] nvkm_uevent_add: uevent: 0x888100242100, event: 
> > > > 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> > > > [4.033680] nvkm_uevent_add: uevent: 0x888100242300, event: 
> > > > 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> > > > [4.045429] nouveau :03:00.0: DRM: MM: using COPY for buffer 
> > > > copies
> > > > [4.052059] stackdepot: allocating hash table of 1048576 entries via 
> > > > kvcalloc
> > > > [4.067191] nvkm_uevent_add: uevent: 0x888100242800, event: 
> > > > 0x888104b3e260, id: 0x0, bits: 0x1, func: 0x
> > > > [4.078936] nvkm_uevent_add: uevent: 0x888100242900, event: 
> > > > 0x888104b3e260, id: 0x1, bits: 0x1, func: 0x
> > > > [4.090514] nvkm_uevent_add: uevent: 0x888100242a00, event: 
> > > > 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-09 Thread Karol Herbst
On Wed, Aug 9, 2023 at 11:22 AM Takashi Iwai  wrote:
>
> On Tue, 08 Aug 2023 12:39:32 +0200,
> Karol Herbst wrote:
> >
> > On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov  wrote:
> > >
> > > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> > > > in what way does it stop? Just not progressing? That would be kinda
> > > > concerning. Mind tracing with what arguments `nvkm_uevent_add` is
> > > > called with and without that patch?
> > >
> > > Well, me dumping those args I guess made the box not freeze before
> > > catching a #PF over serial. Does that help?
> > >
> > > 
> > > [3.410135] Unpacking initramfs...
> > > [3.416319] software IO TLB: mapped [mem 
> > > 0xa877d000-0xac77d000] (64MB)
> > > [3.418227] Initialise system trusted keyrings
> > > [3.432273] workingset: timestamp_bits=56 max_order=22 bucket_order=0
> > > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > > [3.443368] fuse: init (API version 7.38)
> > > [3.447601] 9p: Installing v9fs 9p2000 file system support
> > > [3.453223] Key type asymmetric registered
> > > [3.457332] Asymmetric key parser 'x509' registered
> > > [3.462236] Block layer SCSI generic (bsg) driver version 0.4 loaded 
> > > (major 250)
> > > [3.475865] efifb: probing for efifb
> > > [3.479458] efifb: framebuffer at 0xf900, using 1920k, total 1920k
> > > [3.485969] efifb: mode is 800x600x32, linelength=3200, pages=1
> > > [3.491872] efifb: scrolling: redraw
> > > [3.495438] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
> > > [3.502349] Console: switching to colour frame buffer device 100x37
> > > [3.509564] fb0: EFI VGA frame buffer device
> > > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > > [3.544219] Freeing initrd memory: 8196K
> > > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > > [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
> > > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is 
> > > a 16550A
> > > [3.625552] serial :00:16.3: enabling device ( -> 0003)
> > > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, base_baud = 
> > > 115200) is a 16550A
> > > [3.642451] Linux agpgart interface v0.103
> > > [3.647141] ACPI: bus type drm_connector registered
> > > [3.653261] Console: switching to colour dummy device 80x25
> > > [3.659092] nouveau :03:00.0: vgaarb: deactivate vga console
> > > [3.665174] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> > > [3.784585] nouveau :03:00.0: bios: version 70.18.83.00.08
> > > [3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
> > > [3.948786] nouveau :03:00.0: DRM: VRAM: 512 MiB
> > > [3.953755] nouveau :03:00.0: DRM: GART: 1048576 MiB
> > > [3.959073] nouveau :03:00.0: DRM: TMDS table version 2.0
> > > [3.964808] nouveau :03:00.0: DRM: DCB version 4.0
> > > [3.969938] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
> > > [3.976367] nouveau :03:00.0: DRM: DCB outp 01: 02000362 00020010
> > > [3.982792] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 0f220010
> > > [3.989223] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
> > > [3.995647] nouveau :03:00.0: DRM: DCB outp 04: 08011382 00020010
> > > [4.002076] nouveau :03:00.0: DRM: DCB outp 05: 088113c6 0f220010
> > > [4.008511] nouveau :03:00.0: DRM: DCB conn 00: 00101064
> > > [4.014151] nouveau :03:00.0: DRM: DCB conn 01: 00202165
> > > [4.021710] nvkm_uevent_add: uevent: 0x888100242100, event: 
> > > 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> > > [4.033680] nvkm_uevent_add: uevent: 0x888100242300, event: 
> > > 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> > > [4.045429] nouveau :03:00.0: DRM: MM: using COPY for buffer copies
> > > [4.052059] stackdepot: allocating hash table of 1048576 entries via 
> > > kvcalloc
> > > [4.067191] nvkm_uevent_add: uevent: 0x888100242800, event: 
> > > 0x888104b3e260, id: 0x0, bits: 0x1, func: 0x
> > > [4.078936] nvkm_uevent_add: uevent: 0x888100242900, event: 
> > > 0x888104b3e260, id: 0x1, bits: 0x1, func: 0x
> > > [4.090514] nvkm_uevent_add: uevent: 0x888100242a00, event: 
> > > 0x888102091f28, id: 0x1, bits: 0x3, func: 0x8177b700
> > > [4.102118] tsc: Refined TSC clocksource calibration: 3591.345 MHz
> > > [4.108342] clocksource: tsc: mask: 0x max_cycles: 
> > > 0x33c4635c383, max_idle_ns: 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-09 Thread Takashi Iwai
On Tue, 08 Aug 2023 12:39:32 +0200,
Karol Herbst wrote:
> 
> On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov  wrote:
> >
> > On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> > > in what way does it stop? Just not progressing? That would be kinda
> > > concerning. Mind tracing with what arguments `nvkm_uevent_add` is
> > > called with and without that patch?
> >
> > Well, me dumping those args I guess made the box not freeze before
> > catching a #PF over serial. Does that help?
> >
> > 
> > [3.410135] Unpacking initramfs...
> > [3.416319] software IO TLB: mapped [mem 
> > 0xa877d000-0xac77d000] (64MB)
> > [3.418227] Initialise system trusted keyrings
> > [3.432273] workingset: timestamp_bits=56 max_order=22 bucket_order=0
> > [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> > [3.443368] fuse: init (API version 7.38)
> > [3.447601] 9p: Installing v9fs 9p2000 file system support
> > [3.453223] Key type asymmetric registered
> > [3.457332] Asymmetric key parser 'x509' registered
> > [3.462236] Block layer SCSI generic (bsg) driver version 0.4 loaded 
> > (major 250)
> > [3.475865] efifb: probing for efifb
> > [3.479458] efifb: framebuffer at 0xf900, using 1920k, total 1920k
> > [3.485969] efifb: mode is 800x600x32, linelength=3200, pages=1
> > [3.491872] efifb: scrolling: redraw
> > [3.495438] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
> > [3.502349] Console: switching to colour frame buffer device 100x37
> > [3.509564] fb0: EFI VGA frame buffer device
> > [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> > [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> > [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> > [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> > [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> > [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> > [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> > [3.544219] Freeing initrd memory: 8196K
> > [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> > [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
> > [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 
> > 16550A
> > [3.625552] serial :00:16.3: enabling device ( -> 0003)
> > [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, base_baud = 
> > 115200) is a 16550A
> > [3.642451] Linux agpgart interface v0.103
> > [3.647141] ACPI: bus type drm_connector registered
> > [3.653261] Console: switching to colour dummy device 80x25
> > [3.659092] nouveau :03:00.0: vgaarb: deactivate vga console
> > [3.665174] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> > [3.784585] nouveau :03:00.0: bios: version 70.18.83.00.08
> > [3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
> > [3.948786] nouveau :03:00.0: DRM: VRAM: 512 MiB
> > [3.953755] nouveau :03:00.0: DRM: GART: 1048576 MiB
> > [3.959073] nouveau :03:00.0: DRM: TMDS table version 2.0
> > [3.964808] nouveau :03:00.0: DRM: DCB version 4.0
> > [3.969938] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
> > [3.976367] nouveau :03:00.0: DRM: DCB outp 01: 02000362 00020010
> > [3.982792] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 0f220010
> > [3.989223] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
> > [3.995647] nouveau :03:00.0: DRM: DCB outp 04: 08011382 00020010
> > [4.002076] nouveau :03:00.0: DRM: DCB outp 05: 088113c6 0f220010
> > [4.008511] nouveau :03:00.0: DRM: DCB conn 00: 00101064
> > [4.014151] nouveau :03:00.0: DRM: DCB conn 01: 00202165
> > [4.021710] nvkm_uevent_add: uevent: 0x888100242100, event: 
> > 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> > [4.033680] nvkm_uevent_add: uevent: 0x888100242300, event: 
> > 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> > [4.045429] nouveau :03:00.0: DRM: MM: using COPY for buffer copies
> > [4.052059] stackdepot: allocating hash table of 1048576 entries via 
> > kvcalloc
> > [4.067191] nvkm_uevent_add: uevent: 0x888100242800, event: 
> > 0x888104b3e260, id: 0x0, bits: 0x1, func: 0x
> > [4.078936] nvkm_uevent_add: uevent: 0x888100242900, event: 
> > 0x888104b3e260, id: 0x1, bits: 0x1, func: 0x
> > [4.090514] nvkm_uevent_add: uevent: 0x888100242a00, event: 
> > 0x888102091f28, id: 0x1, bits: 0x3, func: 0x8177b700
> > [4.102118] tsc: Refined TSC clocksource calibration: 3591.345 MHz
> > [4.108342] clocksource: tsc: mask: 0x max_cycles: 
> > 0x33c4635c383, max_idle_ns: 440795314831 ns
> > [4.108401] nvkm_uevent_add: uevent: 0x8881020b6000, event: 
> > 0x888102091f28, id: 0xf, bits: 0x3, func: 0x8177b700
> > [4.129864] clocksource: Switched to clocksource tsc
> > [  

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-08 Thread Borislav Petkov
On Tue, Aug 08, 2023 at 12:39:32PM +0200, Karol Herbst wrote:
> ahh, that would have been good to know :)

Yeah, I didn't see it before - it would only freeze. Only after I added
the printk you requested.

> Mind figuring out what's exactly NULL inside nvif_object_mthd? Or
> rather what line `nvif_object_mthd+0x136` belongs to, then it should
> be easy to figure out what's wrong here.

That looks like this:

816ddfee:   e8 8d 04 4e 00  callq  81bbe480 
<__memcpy>
816ddff3:   41 8d 56 20 lea0x20(%r14),%edx
816ddff7:   49 8b 44 24 08  mov0x8(%r12),%rax
816ddffc:   83 fa 17cmp$0x17,%edx
816ddfff:   76 7d   jbe816de07e 

816de001:   49 39 c4cmp%rax,%r12
816de004:   74 45   je 816de04b 


<--- RIP points here.

The 0x20 also fits the deref address: 0020.

Which means %rax is 0. Yap.

816de006:   48 8b 78 20 mov0x20(%rax),%rdi
816de00a:   4c 89 64 24 10  mov%r12,0x10(%rsp)
816de00f:   48 8b 40 38 mov0x38(%rax),%rax
816de013:   c6 44 24 06 ff  movb   $0xff,0x6(%rsp)
816de018:   31 c9   xor%ecx,%ecx
816de01a:   48 89 e6mov%rsp,%rsi
816de01d:   48 8b 40 28 mov0x28(%rax),%rax
816de021:   e8 3a 0c 4f 00  callq  81bcec60 
<__x86_indirect_thunk_array>


Now, the preprocessed asm version of nvif/object.c says around here:


callmemcpy  #
# drivers/gpu/drm/nouveau/nvif/object.c:160:ret = nvif_object_ioctl(object, 
args, sizeof(*args) + size, NULL);
leal32(%r14), %edx  #, _108
# drivers/gpu/drm/nouveau/nvif/object.c:33: struct nvif_client *client = 
object->client;
movq8(%r12), %rax   # object_19(D)->client, client
# drivers/gpu/drm/nouveau/nvif/object.c:38: if (size >= sizeof(*args) && 
args->v0.version == 0) {
cmpl$23, %edx   #, _108
jbe .L69#,
# drivers/gpu/drm/nouveau/nvif/object.c:39: if (object != 
>object)
cmpq%rax, %r12  # client, object
je  .L70#,
# drivers/gpu/drm/nouveau/nvif/object.c:47: return 
client->driver->ioctl(client->object.priv, data, size, hack);
movq32(%rax), %rdi  # client_109->object.priv, 
client_109->object.priv


So I'd say that client is NULL. IINM.


movq%r12, 16(%rsp)  # object, MEM[(union  *)].v0.object
# drivers/gpu/drm/nouveau/nvif/object.c:47: return 
client->driver->ioctl(client->object.priv, data, size, hack);
movq56(%rax), %rax  # client_109->driver, client_109->driver
# drivers/gpu/drm/nouveau/nvif/object.c:43: args->v0.owner = 
NVIF_IOCTL_V0_OWNER_ANY;
movb$-1, 6(%rsp)#, MEM[(union  *)].v0.owner
.L64:
# drivers/gpu/drm/nouveau/nvif/object.c:47: return 
client->driver->ioctl(client->object.priv, data, size, hack);
xorl%ecx, %ecx  #
movq%rsp, %rsi  #,
movq40(%rax), %rax  #, _77->ioctl
call__x86_indirect_thunk_rax
# drivers/gpu/drm/nouveau/nvif/object.c:161:memcpy(data, args->mthd.data, 
size);

> > [4.144676] #PF: supervisor read access in kernel mode
> > [4.144676] #PF: error_code(0x) - not-present page
> > [4.144676] PGD 0 P4D 0
> > [4.144676] Oops:  [#1] PREEMPT SMP PTI
> > [4.144676] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 6.5.0-rc5-dirty #1
> > [4.144676] Hardware name: Dell Inc. Precision T3600/0PTTT9, BIOS A13 
> > 05/11/2014
> > [4.144676] RIP: 0010:nvif_object_mthd+0x136/0x1e0
> > [4.144676] Code: f2 4c 89 ee 48 8d 7c 24 20 66 89 04 24 c6 44 24 18 00 
> > e8 8d 04 4e 00 41 8d 56 20 49 8b 44 24 08 83 fa 17 76 7d 49 39 c4 74 45 
> > <48> 8b 78 20 4c 89 64 24 10 48 8b 40 38 c6 44 24 06 ff 31 c9 48 89

Opcode bytes around RIP look correct too:

./scripts/decodecode < /tmp/oops
[ 4.144676] Code: f2 4c 89 ee 48 8d 7c 24 20 66 89 04 24 c6 44 24 18 00 e8 8d 
04 4e 00 41 8d 56 20 49 8b 44 24 08 83 fa 17 76 7d 49 39 c4 74 45 <48> 8b 78 20 
4c 89 64 24 10 48 8b 40 38 c6 44 24 06 ff 31 c9 48 89
All code

   0:   f2 4c 89 ee repnz mov %r13,%rsi
   4:   48 8d 7c 24 20  lea0x20(%rsp),%rdi
   9:   66 89 04 24 mov%ax,(%rsp)
   d:   c6 44 24 18 00  movb   $0x0,0x18(%rsp)
  12:   e8 8d 04 4e 00  callq  0x4e04a4
  17:   41 8d 56 20 lea0x20(%r14),%edx
  1b:   49 8b 44 24 08  mov0x8(%r12),%rax
  20:   83 fa 17cmp$0x17,%edx
  23:   76 7d   jbe0xa2
  25:   49 39 c4cmp%rax,%r12
  28:   74 45   je 0x6f
  2a:*  48 8b 78 20 mov0x20(%rax),%rdi  <-- trapping 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-08 Thread Karol Herbst
On Mon, Aug 7, 2023 at 5:05 PM Borislav Petkov  wrote:
>
> On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> > in what way does it stop? Just not progressing? That would be kinda
> > concerning. Mind tracing with what arguments `nvkm_uevent_add` is
> > called with and without that patch?
>
> Well, me dumping those args I guess made the box not freeze before
> catching a #PF over serial. Does that help?
>
> 
> [3.410135] Unpacking initramfs...
> [3.416319] software IO TLB: mapped [mem 
> 0xa877d000-0xac77d000] (64MB)
> [3.418227] Initialise system trusted keyrings
> [3.432273] workingset: timestamp_bits=56 max_order=22 bucket_order=0
> [3.439006] ntfs: driver 2.1.32 [Flags: R/W].
> [3.443368] fuse: init (API version 7.38)
> [3.447601] 9p: Installing v9fs 9p2000 file system support
> [3.453223] Key type asymmetric registered
> [3.457332] Asymmetric key parser 'x509' registered
> [3.462236] Block layer SCSI generic (bsg) driver version 0.4 loaded 
> (major 250)
> [3.475865] efifb: probing for efifb
> [3.479458] efifb: framebuffer at 0xf900, using 1920k, total 1920k
> [3.485969] efifb: mode is 800x600x32, linelength=3200, pages=1
> [3.491872] efifb: scrolling: redraw
> [3.495438] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
> [3.502349] Console: switching to colour frame buffer device 100x37
> [3.509564] fb0: EFI VGA frame buffer device
> [3.514013] ACPI: \_PR_.CP00: Found 4 idle states
> [3.518850] ACPI: \_PR_.CP01: Found 4 idle states
> [3.523687] ACPI: \_PR_.CP02: Found 4 idle states
> [3.528515] ACPI: \_PR_.CP03: Found 4 idle states
> [3.533346] ACPI: \_PR_.CP04: Found 4 idle states
> [3.538173] ACPI: \_PR_.CP05: Found 4 idle states
> [3.543003] ACPI: \_PR_.CP06: Found 4 idle states
> [3.544219] Freeing initrd memory: 8196K
> [3.547844] ACPI: \_PR_.CP07: Found 4 idle states
> [3.609542] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
> [3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 
> 16550A
> [3.625552] serial :00:16.3: enabling device ( -> 0003)
> [3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, base_baud = 
> 115200) is a 16550A
> [3.642451] Linux agpgart interface v0.103
> [3.647141] ACPI: bus type drm_connector registered
> [3.653261] Console: switching to colour dummy device 80x25
> [3.659092] nouveau :03:00.0: vgaarb: deactivate vga console
> [3.665174] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> [3.784585] nouveau :03:00.0: bios: version 70.18.83.00.08
> [3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
> [3.948786] nouveau :03:00.0: DRM: VRAM: 512 MiB
> [3.953755] nouveau :03:00.0: DRM: GART: 1048576 MiB
> [3.959073] nouveau :03:00.0: DRM: TMDS table version 2.0
> [3.964808] nouveau :03:00.0: DRM: DCB version 4.0
> [3.969938] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
> [3.976367] nouveau :03:00.0: DRM: DCB outp 01: 02000362 00020010
> [3.982792] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 0f220010
> [3.989223] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
> [3.995647] nouveau :03:00.0: DRM: DCB outp 04: 08011382 00020010
> [4.002076] nouveau :03:00.0: DRM: DCB outp 05: 088113c6 0f220010
> [4.008511] nouveau :03:00.0: DRM: DCB conn 00: 00101064
> [4.014151] nouveau :03:00.0: DRM: DCB conn 01: 00202165
> [4.021710] nvkm_uevent_add: uevent: 0x888100242100, event: 
> 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> [4.033680] nvkm_uevent_add: uevent: 0x888100242300, event: 
> 0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
> [4.045429] nouveau :03:00.0: DRM: MM: using COPY for buffer copies
> [4.052059] stackdepot: allocating hash table of 1048576 entries via 
> kvcalloc
> [4.067191] nvkm_uevent_add: uevent: 0x888100242800, event: 
> 0x888104b3e260, id: 0x0, bits: 0x1, func: 0x
> [4.078936] nvkm_uevent_add: uevent: 0x888100242900, event: 
> 0x888104b3e260, id: 0x1, bits: 0x1, func: 0x
> [4.090514] nvkm_uevent_add: uevent: 0x888100242a00, event: 
> 0x888102091f28, id: 0x1, bits: 0x3, func: 0x8177b700
> [4.102118] tsc: Refined TSC clocksource calibration: 3591.345 MHz
> [4.108342] clocksource: tsc: mask: 0x max_cycles: 
> 0x33c4635c383, max_idle_ns: 440795314831 ns
> [4.108401] nvkm_uevent_add: uevent: 0x8881020b6000, event: 
> 0x888102091f28, id: 0xf, bits: 0x3, func: 0x8177b700
> [4.129864] clocksource: Switched to clocksource tsc
> [4.131478] [drm] Initialized nouveau 1.3.1 20120801 for :03:00.0 on 
> minor 0
> [4.143806] BUG: kernel NULL pointer dereference, address: 0020

ahh, that would have been good to know :) Mind figuring out 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-07 Thread Borislav Petkov
On Mon, Aug 07, 2023 at 01:49:42PM +0200, Karol Herbst wrote:
> in what way does it stop? Just not progressing? That would be kinda
> concerning. Mind tracing with what arguments `nvkm_uevent_add` is
> called with and without that patch?

Well, me dumping those args I guess made the box not freeze before
catching a #PF over serial. Does that help?


[3.410135] Unpacking initramfs...
[3.416319] software IO TLB: mapped [mem 
0xa877d000-0xac77d000] (64MB)
[3.418227] Initialise system trusted keyrings
[3.432273] workingset: timestamp_bits=56 max_order=22 bucket_order=0
[3.439006] ntfs: driver 2.1.32 [Flags: R/W].
[3.443368] fuse: init (API version 7.38)
[3.447601] 9p: Installing v9fs 9p2000 file system support
[3.453223] Key type asymmetric registered
[3.457332] Asymmetric key parser 'x509' registered
[3.462236] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 
250)
[3.475865] efifb: probing for efifb
[3.479458] efifb: framebuffer at 0xf900, using 1920k, total 1920k
[3.485969] efifb: mode is 800x600x32, linelength=3200, pages=1
[3.491872] efifb: scrolling: redraw
[3.495438] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0
[3.502349] Console: switching to colour frame buffer device 100x37
[3.509564] fb0: EFI VGA frame buffer device
[3.514013] ACPI: \_PR_.CP00: Found 4 idle states
[3.518850] ACPI: \_PR_.CP01: Found 4 idle states
[3.523687] ACPI: \_PR_.CP02: Found 4 idle states
[3.528515] ACPI: \_PR_.CP03: Found 4 idle states
[3.533346] ACPI: \_PR_.CP04: Found 4 idle states
[3.538173] ACPI: \_PR_.CP05: Found 4 idle states
[3.543003] ACPI: \_PR_.CP06: Found 4 idle states
[3.544219] Freeing initrd memory: 8196K
[3.547844] ACPI: \_PR_.CP07: Found 4 idle states
[3.609542] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
[3.616224] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 
16550A
[3.625552] serial :00:16.3: enabling device ( -> 0003)
[3.633034] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, base_baud = 115200) 
is a 16550A
[3.642451] Linux agpgart interface v0.103
[3.647141] ACPI: bus type drm_connector registered
[3.653261] Console: switching to colour dummy device 80x25
[3.659092] nouveau :03:00.0: vgaarb: deactivate vga console
[3.665174] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
[3.784585] nouveau :03:00.0: bios: version 70.18.83.00.08
[3.792244] nouveau :03:00.0: fb: 512 MiB DDR3
[3.948786] nouveau :03:00.0: DRM: VRAM: 512 MiB
[3.953755] nouveau :03:00.0: DRM: GART: 1048576 MiB
[3.959073] nouveau :03:00.0: DRM: TMDS table version 2.0
[3.964808] nouveau :03:00.0: DRM: DCB version 4.0
[3.969938] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
[3.976367] nouveau :03:00.0: DRM: DCB outp 01: 02000362 00020010
[3.982792] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 0f220010
[3.989223] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
[3.995647] nouveau :03:00.0: DRM: DCB outp 04: 08011382 00020010
[4.002076] nouveau :03:00.0: DRM: DCB outp 05: 088113c6 0f220010
[4.008511] nouveau :03:00.0: DRM: DCB conn 00: 00101064
[4.014151] nouveau :03:00.0: DRM: DCB conn 01: 00202165
[4.021710] nvkm_uevent_add: uevent: 0x888100242100, event: 
0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
[4.033680] nvkm_uevent_add: uevent: 0x888100242300, event: 
0x8881022de1a0, id: 0x0, bits: 0x1, func: 0x
[4.045429] nouveau :03:00.0: DRM: MM: using COPY for buffer copies
[4.052059] stackdepot: allocating hash table of 1048576 entries via kvcalloc
[4.067191] nvkm_uevent_add: uevent: 0x888100242800, event: 
0x888104b3e260, id: 0x0, bits: 0x1, func: 0x
[4.078936] nvkm_uevent_add: uevent: 0x888100242900, event: 
0x888104b3e260, id: 0x1, bits: 0x1, func: 0x
[4.090514] nvkm_uevent_add: uevent: 0x888100242a00, event: 
0x888102091f28, id: 0x1, bits: 0x3, func: 0x8177b700
[4.102118] tsc: Refined TSC clocksource calibration: 3591.345 MHz
[4.108342] clocksource: tsc: mask: 0x max_cycles: 
0x33c4635c383, max_idle_ns: 440795314831 ns
[4.108401] nvkm_uevent_add: uevent: 0x8881020b6000, event: 
0x888102091f28, id: 0xf, bits: 0x3, func: 0x8177b700
[4.129864] clocksource: Switched to clocksource tsc
[4.131478] [drm] Initialized nouveau 1.3.1 20120801 for :03:00.0 on 
minor 0
[4.143806] BUG: kernel NULL pointer dereference, address: 0020
[4.144676] #PF: supervisor read access in kernel mode
[4.144676] #PF: error_code(0x) - not-present page
[4.144676] PGD 0 P4D 0 
[4.144676] Oops:  [#1] PREEMPT SMP PTI
[4.144676] CPU: 2 PID: 1 Comm: swapper/0 Not tainted 6.5.0-rc5-dirty #1
[4.144676] 

Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-07 Thread Karol Herbst
On Sun, Aug 6, 2023 at 11:40 PM Borislav Petkov  wrote:
>
> Hi folks,
>
> the patch in $Subject breaks booting here on one of my test boxes, see
> below.
>
> Reverting it ontop of -rc4 fixes the issue.
>
> Thx.
>
> [3.580535] ACPI: \_PR_.CP04: Found 4 idle states
> [3.585694] ACPI: \_PR_.CP05: Found 4 idle states
> [3.590852] ACPI: \_PR_.CP06: Found 4 idle states
> [3.596037] ACPI: \_PR_.CP07: Found 4 idle states
> [3.644065] Freeing initrd memory: 6740K
> [3.742932] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
> [3.750409] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 
> 16550A
> [3.762111] serial :00:16.3: enabling device ( -> 0003)
> [3.771589] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, base_baud = 
> 115200) is a 16550A
> [3.782503] Linux agpgart interface v0.103
> [3.787805] ACPI: bus type drm_connector registered
>
> <--- boot stops here.
>

in what way does it stop? Just not progressing? That would be kinda
concerning. Mind tracing with what arguments `nvkm_uevent_add` is
called with and without that patch?

Also a boot log with `nouveau.debug=trace` might be helpful here.

> It should continue with this:
>
> [3.795491] Console: switching to colour dummy device 80x25
> [3.801933] nouveau :03:00.0: vgaarb: deactivate vga console
> [3.808303] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> [3.931002] nouveau :03:00.0: bios: version 70.18.83.00.08
> [3.941731] nouveau :03:00.0: fb: 512 MiB DDR3
> [4.110348] tsc: Refined TSC clocksource calibration: 3591.349 MHz
> [4.116627] clocksource: tsc: mask: 0x max_cycles: 
> 0x33c466a1ab5, max_idle_ns: 440795209767 ns
> [4.126871] clocksource: Switched to clocksource tsc
> [4.252013] nouveau :03:00.0: DRM: VRAM: 512 MiB
> [4.257088] nouveau :03:00.0: DRM: GART: 1048576 MiB
> [4.262501] nouveau :03:00.0: DRM: TMDS table version 2.0
> [4.268333] nouveau :03:00.0: DRM: DCB version 4.0
> [4.273561] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
> [4.280104] nouveau :03:00.0: DRM: DCB outp 01: 02000362 00020010
> [4.286630] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 0f220010
> [4.293176] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
> [4.299711] nouveau :03:00.0: DRM: DCB outp 04: 08011382 00020010
> [4.306243] nouveau :03:00.0: DRM: DCB outp 05: 088113c6 0f220010
> [4.312772] nouveau :03:00.0: DRM: DCB conn 00: 00101064
> [4.318520] nouveau :03:00.0: DRM: DCB conn 01: 00202165
> [4.329488] nouveau :03:00.0: DRM: MM: using COPY for buffer copies
> [4.336261] stackdepot: allocating hash table of 1048576 entries via 
> kvcalloc
> ...
>
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
>



Re: 2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-07 Thread Thorsten Leemhuis
[CCing the regression list, as it should be in the loop for regressions:
https://docs.kernel.org/admin-guide/reporting-regressions.html]

[TLDR: I'm adding this report to the list of tracked Linux kernel
regressions; the text you find below is based on a few templates
paragraphs you might have encountered already in similar form.
See link in footer if these mails annoy you.]

On 06.08.23 23:31, Borislav Petkov wrote:
> 
> the patch in $Subject

Side note, in case anyone cares: it was also included in 6.4.7.

> breaks booting here on one of my test boxes, see
> below.
> 
> Reverting it ontop of -rc4 fixes the issue.
> 
> Thx.

Thanks for the report. To be sure the issue doesn't fall through the
cracks unnoticed, I'm adding it to regzbot, the Linux kernel regression
tracking bot:

#regzbot ^introduced 2b5d1c29f6c4
#regzbot title drm/nouveau: stopped booting
#regzbot ignore-activity

This isn't a regression? This issue or a fix for it are already
discussed somewhere else? It was fixed already? You want to clarify when
the regression started to happen? Or point out I got the title or
something else totally wrong? Then just reply and tell me -- ideally
while also telling regzbot about it, as explained by the page listed in
the footer of this mail.

Developers: When fixing the issue, remember to add 'Link:' tags pointing
to the report (the parent of this mail). See page linked in footer for
details.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.

> [3.580535] ACPI: \_PR_.CP04: Found 4 idle states
> [3.585694] ACPI: \_PR_.CP05: Found 4 idle states
> [3.590852] ACPI: \_PR_.CP06: Found 4 idle states
> [3.596037] ACPI: \_PR_.CP07: Found 4 idle states
> [3.644065] Freeing initrd memory: 6740K
> [3.742932] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
> [3.750409] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 
> 16550A
> [3.762111] serial :00:16.3: enabling device ( -> 0003)
> [3.771589] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, base_baud = 
> 115200) is a 16550A
> [3.782503] Linux agpgart interface v0.103
> [3.787805] ACPI: bus type drm_connector registered
> 
> <--- boot stops here.
> 
> It should continue with this:
> 
> [3.795491] Console: switching to colour dummy device 80x25
> [3.801933] nouveau :03:00.0: vgaarb: deactivate vga console
> [3.808303] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
> [3.931002] nouveau :03:00.0: bios: version 70.18.83.00.08
> [3.941731] nouveau :03:00.0: fb: 512 MiB DDR3
> [4.110348] tsc: Refined TSC clocksource calibration: 3591.349 MHz
> [4.116627] clocksource: tsc: mask: 0x max_cycles: 
> 0x33c466a1ab5, max_idle_ns: 440795209767 ns
> [4.126871] clocksource: Switched to clocksource tsc
> [4.252013] nouveau :03:00.0: DRM: VRAM: 512 MiB
> [4.257088] nouveau :03:00.0: DRM: GART: 1048576 MiB
> [4.262501] nouveau :03:00.0: DRM: TMDS table version 2.0
> [4.268333] nouveau :03:00.0: DRM: DCB version 4.0
> [4.273561] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
> [4.280104] nouveau :03:00.0: DRM: DCB outp 01: 02000362 00020010
> [4.286630] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 0f220010
> [4.293176] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
> [4.299711] nouveau :03:00.0: DRM: DCB outp 04: 08011382 00020010
> [4.306243] nouveau :03:00.0: DRM: DCB outp 05: 088113c6 0f220010
> [4.312772] nouveau :03:00.0: DRM: DCB conn 00: 00101064
> [4.318520] nouveau :03:00.0: DRM: DCB conn 01: 00202165
> [4.329488] nouveau :03:00.0: DRM: MM: using COPY for buffer copies
> [4.336261] stackdepot: allocating hash table of 1048576 entries via 
> kvcalloc
> ...
> 
> 


2b5d1c29f6c4 ("drm/nouveau/disp: PIOR DP uses GPIO for HPD, not PMGR AUX interrupts")

2023-08-06 Thread Borislav Petkov
Hi folks,

the patch in $Subject breaks booting here on one of my test boxes, see
below.

Reverting it ontop of -rc4 fixes the issue.

Thx.

[3.580535] ACPI: \_PR_.CP04: Found 4 idle states
[3.585694] ACPI: \_PR_.CP05: Found 4 idle states
[3.590852] ACPI: \_PR_.CP06: Found 4 idle states
[3.596037] ACPI: \_PR_.CP07: Found 4 idle states
[3.644065] Freeing initrd memory: 6740K
[3.742932] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
[3.750409] 00:05: ttyS0 at I/O 0x3f8 (irq = 4, base_baud = 115200) is a 
16550A
[3.762111] serial :00:16.3: enabling device ( -> 0003)
[3.771589] :00:16.3: ttyS1 at I/O 0xf0a0 (irq = 17, base_baud = 115200) 
is a 16550A
[3.782503] Linux agpgart interface v0.103
[3.787805] ACPI: bus type drm_connector registered

<--- boot stops here.

It should continue with this:

[3.795491] Console: switching to colour dummy device 80x25
[3.801933] nouveau :03:00.0: vgaarb: deactivate vga console
[3.808303] nouveau :03:00.0: NVIDIA GT218 (0a8c00b1)
[3.931002] nouveau :03:00.0: bios: version 70.18.83.00.08
[3.941731] nouveau :03:00.0: fb: 512 MiB DDR3
[4.110348] tsc: Refined TSC clocksource calibration: 3591.349 MHz
[4.116627] clocksource: tsc: mask: 0x max_cycles: 
0x33c466a1ab5, max_idle_ns: 440795209767 ns
[4.126871] clocksource: Switched to clocksource tsc
[4.252013] nouveau :03:00.0: DRM: VRAM: 512 MiB
[4.257088] nouveau :03:00.0: DRM: GART: 1048576 MiB
[4.262501] nouveau :03:00.0: DRM: TMDS table version 2.0
[4.268333] nouveau :03:00.0: DRM: DCB version 4.0
[4.273561] nouveau :03:00.0: DRM: DCB outp 00: 02000360 
[4.280104] nouveau :03:00.0: DRM: DCB outp 01: 02000362 00020010
[4.286630] nouveau :03:00.0: DRM: DCB outp 02: 028003a6 0f220010
[4.293176] nouveau :03:00.0: DRM: DCB outp 03: 01011380 
[4.299711] nouveau :03:00.0: DRM: DCB outp 04: 08011382 00020010
[4.306243] nouveau :03:00.0: DRM: DCB outp 05: 088113c6 0f220010
[4.312772] nouveau :03:00.0: DRM: DCB conn 00: 00101064
[4.318520] nouveau :03:00.0: DRM: DCB conn 01: 00202165
[4.329488] nouveau :03:00.0: DRM: MM: using COPY for buffer copies
[4.336261] stackdepot: allocating hash table of 1048576 entries via kvcalloc
...


-- 
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette