Broken build due to 6aed8ec "drm: review locking for drm_fb_helper_restore_fbdev_mode"
On Tue, Feb 19, 2013 at 6:48 PM, Stephen Warren wrote: > Daniel, > > Commit 6aed8ec "drm: review locking for > drm_fb_helper_restore_fbdev_mode" (now in next-20130218 and later) > causes build failures for tegra_defconfig. The issue is this part of the > patch: You need to yell at Dave Airlie: https://patchwork.kernel.org/patch/2162391/ Cheers, Daniel >> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c >> b/drivers/gpu/drm/drm_fb_cma_helper.c >> index 3742bc9..1b6ba2d 100644 >> --- a/drivers/gpu/drm/drm_fb_cma_helper.c >> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c >> @@ -389,8 +389,10 @@ EXPORT_SYMBOL_GPL(drm_fbdev_cma_fini); >> */ >> void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma) >> { >> + drm_modeset_lock_all(dev); >> if (fbdev_cma) >> drm_fb_helper_restore_fbdev_mode(_cma->fb_helper); >> + drm_modeset_unlock_all(dev); >> } >> EXPORT_SYMBOL_GPL(drm_fbdev_cma_restore_mode); > > There, there is no "dev" variable, so compile fails. > > If I revert this one patch, the build succeeds, although I didn't check > whether DRM still works after that (e.g. due to any dependencies from > the rest of the series). -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Broken build due to 6aed8ec "drm: review locking for drm_fb_helper_restore_fbdev_mode"
On 02/19/2013 11:56 AM, Daniel Vetter wrote: > On Tue, Feb 19, 2013 at 6:48 PM, Stephen Warren > wrote: >> Daniel, >> >> Commit 6aed8ec "drm: review locking for >> drm_fb_helper_restore_fbdev_mode" (now in next-20130218 and later) >> causes build failures for tegra_defconfig. The issue is this part of the >> patch: > > You need to yell at Dave Airlie: > > https://patchwork.kernel.org/patch/2162391/ Ah, thanks, that solves it. I guess that was too new for Google to find, and I'm not on dri-devel so it wasn't in my mailbox.
Broken build due to 6aed8ec "drm: review locking for drm_fb_helper_restore_fbdev_mode"
Daniel, Commit 6aed8ec "drm: review locking for drm_fb_helper_restore_fbdev_mode" (now in next-20130218 and later) causes build failures for tegra_defconfig. The issue is this part of the patch: > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c > b/drivers/gpu/drm/drm_fb_cma_helper.c > index 3742bc9..1b6ba2d 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -389,8 +389,10 @@ EXPORT_SYMBOL_GPL(drm_fbdev_cma_fini); > */ > void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma) > { > + drm_modeset_lock_all(dev); > if (fbdev_cma) > drm_fb_helper_restore_fbdev_mode(_cma->fb_helper); > + drm_modeset_unlock_all(dev); > } > EXPORT_SYMBOL_GPL(drm_fbdev_cma_restore_mode); There, there is no "dev" variable, so compile fails. If I revert this one patch, the build succeeds, although I didn't check whether DRM still works after that (e.g. due to any dependencies from the rest of the series).
Broken build due to 6aed8ec drm: review locking for drm_fb_helper_restore_fbdev_mode
Daniel, Commit 6aed8ec drm: review locking for drm_fb_helper_restore_fbdev_mode (now in next-20130218 and later) causes build failures for tegra_defconfig. The issue is this part of the patch: diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c index 3742bc9..1b6ba2d 100644 --- a/drivers/gpu/drm/drm_fb_cma_helper.c +++ b/drivers/gpu/drm/drm_fb_cma_helper.c @@ -389,8 +389,10 @@ EXPORT_SYMBOL_GPL(drm_fbdev_cma_fini); */ void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma) { + drm_modeset_lock_all(dev); if (fbdev_cma) drm_fb_helper_restore_fbdev_mode(fbdev_cma-fb_helper); + drm_modeset_unlock_all(dev); } EXPORT_SYMBOL_GPL(drm_fbdev_cma_restore_mode); There, there is no dev variable, so compile fails. If I revert this one patch, the build succeeds, although I didn't check whether DRM still works after that (e.g. due to any dependencies from the rest of the series). ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel