Re: Kunit drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123
On Tue, Dec 05, 2023 at 09:33:28AM -0800, Abhinav Kumar wrote:
>
>
> On 12/5/2023 3:46 AM, Maxime Ripard wrote:
> > On Tue, Dec 05, 2023 at 12:05:02PM +0300, Dan Carpenter wrote:
> > > On Tue, Dec 05, 2023 at 09:37:05AM +0100, Maxime Ripard wrote:
> > > > Hi Naresh,
> > > >
> > > > Thanks for the report
> > > >
> > > > On Mon, Dec 04, 2023 at 11:05:36PM +0530, Naresh Kamboju wrote:
> > > > > The Kunit drm_plane_helper failed on all devices running Linux
> > > > > next-20231204
> > > > >
> > > > > ## Test Regressions (compared to next-20231201)
> > > > > * qemu-armv7, kunit and
> > > > > * x86, kunit
> > > > >- drm_test_check_invalid_plane_state_downscaling_invalid
> > > > >- drm_test_check_invalid_plane_state_drm_plane_helper
> > > > >-
> > > > > drm_test_check_invalid_plane_state_drm_test_check_invalid_plane_state
> > > > >- drm_test_check_invalid_plane_state_positioning_invalid
> > > > >- drm_test_check_invalid_plane_state_upscaling_invalid
> > > > >- drm_test_check_plane_state_clipping_rotate_reflect
> > > > >- drm_test_check_plane_state_clipping_simple
> > > > >- drm_test_check_plane_state_downscaling
> > > > >- drm_test_check_plane_state_drm_test_check_plane_state
> > > > >- drm_test_check_plane_state_positioning_simple
> > > > >- drm_test_check_plane_state_rounding1
> > > > >- drm_test_check_plane_state_rounding2
> > > > >- drm_test_check_plane_state_rounding3
> > > > >- drm_test_check_plane_state_rounding4
> > > > >- drm_test_check_plane_state_upscaling
> > > >
> > > > I found the source of failure to be f1e75da5364e ("drm/atomic: Loosen FB
> > > > atomic checks").
> > > >
> > > > Fortunately for us, it's already been reverted yesterday for some
> > > > unrelated reason, so it should be fixed in next-20231205 onward.
> > >
> > > Sorry, that's a bummer that these patches were reverted. :( The whole
> > > episode was a bit unfortunate...
> > >
> > > Qualcom has been working on those patches for a year. They must not be
> > > using kunit testing as part of their QC... It's some kind of
> > > communication failure on our part.
> >
> > That's definitely a communication failure, but that's mostly on us :)
> >
> > The reason these patches were reverted was completely unrelated to the
> > kunit failures here: it failed the basic requirement we have on
> > intel-gpu-tools tests and open-source userspace examples for new uAPIs.
> >
> > So whether or not kunit tests would have passed, these patches were
> > applied due to inattention and would have been reverted anyway
>
> The patches were reverted because the corresponding IGT/compositor changes
> were not posted yet. We will re-try applying once those are accepted.
>
> Regarding KUnit tests, no we did not run this test and yes you are right, we
> were not running KUnit testing as the DRM CI mainly validates IGT.
>
> We will certainly help to fix this failure. Most likely the KUnit tests need
> to be fixed to allow for a NULL FB.
>
> If this is documented somewhere as a requirement, please share it and we
> should add KUnit testing to our DRM CI as well so that atleast this kind of
> failure will not repeat.
Yeah, the expectation is that all tests pass all the time. If some
change affects how tests should be written, then it should update the
tests as well.
Maxime
signature.asc
Description: PGP signature
Re: Kunit drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123
On 12/5/2023 3:46 AM, Maxime Ripard wrote:
On Tue, Dec 05, 2023 at 12:05:02PM +0300, Dan Carpenter wrote:
On Tue, Dec 05, 2023 at 09:37:05AM +0100, Maxime Ripard wrote:
Hi Naresh,
Thanks for the report
On Mon, Dec 04, 2023 at 11:05:36PM +0530, Naresh Kamboju wrote:
The Kunit drm_plane_helper failed on all devices running Linux next-20231204
## Test Regressions (compared to next-20231201)
* qemu-armv7, kunit and
* x86, kunit
- drm_test_check_invalid_plane_state_downscaling_invalid
- drm_test_check_invalid_plane_state_drm_plane_helper
- drm_test_check_invalid_plane_state_drm_test_check_invalid_plane_state
- drm_test_check_invalid_plane_state_positioning_invalid
- drm_test_check_invalid_plane_state_upscaling_invalid
- drm_test_check_plane_state_clipping_rotate_reflect
- drm_test_check_plane_state_clipping_simple
- drm_test_check_plane_state_downscaling
- drm_test_check_plane_state_drm_test_check_plane_state
- drm_test_check_plane_state_positioning_simple
- drm_test_check_plane_state_rounding1
- drm_test_check_plane_state_rounding2
- drm_test_check_plane_state_rounding3
- drm_test_check_plane_state_rounding4
- drm_test_check_plane_state_upscaling
I found the source of failure to be f1e75da5364e ("drm/atomic: Loosen FB
atomic checks").
Fortunately for us, it's already been reverted yesterday for some
unrelated reason, so it should be fixed in next-20231205 onward.
Sorry, that's a bummer that these patches were reverted. :( The whole
episode was a bit unfortunate...
Qualcom has been working on those patches for a year. They must not be
using kunit testing as part of their QC... It's some kind of
communication failure on our part.
That's definitely a communication failure, but that's mostly on us :)
The reason these patches were reverted was completely unrelated to the
kunit failures here: it failed the basic requirement we have on
intel-gpu-tools tests and open-source userspace examples for new uAPIs.
So whether or not kunit tests would have passed, these patches were
applied due to inattention and would have been reverted anyway
Maxime
The patches were reverted because the corresponding IGT/compositor
changes were not posted yet. We will re-try applying once those are
accepted.
Regarding KUnit tests, no we did not run this test and yes you are
right, we were not running KUnit testing as the DRM CI mainly validates IGT.
We will certainly help to fix this failure. Most likely the KUnit tests
need to be fixed to allow for a NULL FB.
If this is documented somewhere as a requirement, please share it and we
should add KUnit testing to our DRM CI as well so that atleast this kind
of failure will not repeat.
Re: Kunit drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123
On Tue, Dec 05, 2023 at 12:05:02PM +0300, Dan Carpenter wrote:
> On Tue, Dec 05, 2023 at 09:37:05AM +0100, Maxime Ripard wrote:
> > Hi Naresh,
> >
> > Thanks for the report
> >
> > On Mon, Dec 04, 2023 at 11:05:36PM +0530, Naresh Kamboju wrote:
> > > The Kunit drm_plane_helper failed on all devices running Linux
> > > next-20231204
> > >
> > > ## Test Regressions (compared to next-20231201)
> > > * qemu-armv7, kunit and
> > > * x86, kunit
> > > - drm_test_check_invalid_plane_state_downscaling_invalid
> > > - drm_test_check_invalid_plane_state_drm_plane_helper
> > > - drm_test_check_invalid_plane_state_drm_test_check_invalid_plane_state
> > > - drm_test_check_invalid_plane_state_positioning_invalid
> > > - drm_test_check_invalid_plane_state_upscaling_invalid
> > > - drm_test_check_plane_state_clipping_rotate_reflect
> > > - drm_test_check_plane_state_clipping_simple
> > > - drm_test_check_plane_state_downscaling
> > > - drm_test_check_plane_state_drm_test_check_plane_state
> > > - drm_test_check_plane_state_positioning_simple
> > > - drm_test_check_plane_state_rounding1
> > > - drm_test_check_plane_state_rounding2
> > > - drm_test_check_plane_state_rounding3
> > > - drm_test_check_plane_state_rounding4
> > > - drm_test_check_plane_state_upscaling
> >
> > I found the source of failure to be f1e75da5364e ("drm/atomic: Loosen FB
> > atomic checks").
> >
> > Fortunately for us, it's already been reverted yesterday for some
> > unrelated reason, so it should be fixed in next-20231205 onward.
>
> Sorry, that's a bummer that these patches were reverted. :( The whole
> episode was a bit unfortunate...
>
> Qualcom has been working on those patches for a year. They must not be
> using kunit testing as part of their QC... It's some kind of
> communication failure on our part.
That's definitely a communication failure, but that's mostly on us :)
The reason these patches were reverted was completely unrelated to the
kunit failures here: it failed the basic requirement we have on
intel-gpu-tools tests and open-source userspace examples for new uAPIs.
So whether or not kunit tests would have passed, these patches were
applied due to inattention and would have been reverted anyway
Maxime
signature.asc
Description: PGP signature
Re: Kunit drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123
On Tue, Dec 05, 2023 at 09:37:05AM +0100, Maxime Ripard wrote:
> Hi Naresh,
>
> Thanks for the report
>
> On Mon, Dec 04, 2023 at 11:05:36PM +0530, Naresh Kamboju wrote:
> > The Kunit drm_plane_helper failed on all devices running Linux next-20231204
> >
> > ## Test Regressions (compared to next-20231201)
> > * qemu-armv7, kunit and
> > * x86, kunit
> > - drm_test_check_invalid_plane_state_downscaling_invalid
> > - drm_test_check_invalid_plane_state_drm_plane_helper
> > - drm_test_check_invalid_plane_state_drm_test_check_invalid_plane_state
> > - drm_test_check_invalid_plane_state_positioning_invalid
> > - drm_test_check_invalid_plane_state_upscaling_invalid
> > - drm_test_check_plane_state_clipping_rotate_reflect
> > - drm_test_check_plane_state_clipping_simple
> > - drm_test_check_plane_state_downscaling
> > - drm_test_check_plane_state_drm_test_check_plane_state
> > - drm_test_check_plane_state_positioning_simple
> > - drm_test_check_plane_state_rounding1
> > - drm_test_check_plane_state_rounding2
> > - drm_test_check_plane_state_rounding3
> > - drm_test_check_plane_state_rounding4
> > - drm_test_check_plane_state_upscaling
>
> I found the source of failure to be f1e75da5364e ("drm/atomic: Loosen FB
> atomic checks").
>
> Fortunately for us, it's already been reverted yesterday for some
> unrelated reason, so it should be fixed in next-20231205 onward.
Sorry, that's a bummer that these patches were reverted. :( The whole
episode was a bit unfortunate...
Qualcom has been working on those patches for a year. They must not be
using kunit testing as part of their QC... It's some kind of
communication failure on our part.
Hopefully we can get this all sorted out and re-apply the patches soon.
regards,
dan carpenter
Re: Kunit drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123
Hi Naresh,
Thanks for the report
On Mon, Dec 04, 2023 at 11:05:36PM +0530, Naresh Kamboju wrote:
> The Kunit drm_plane_helper failed on all devices running Linux next-20231204
>
> ## Test Regressions (compared to next-20231201)
> * qemu-armv7, kunit and
> * x86, kunit
> - drm_test_check_invalid_plane_state_downscaling_invalid
> - drm_test_check_invalid_plane_state_drm_plane_helper
> - drm_test_check_invalid_plane_state_drm_test_check_invalid_plane_state
> - drm_test_check_invalid_plane_state_positioning_invalid
> - drm_test_check_invalid_plane_state_upscaling_invalid
> - drm_test_check_plane_state_clipping_rotate_reflect
> - drm_test_check_plane_state_clipping_simple
> - drm_test_check_plane_state_downscaling
> - drm_test_check_plane_state_drm_test_check_plane_state
> - drm_test_check_plane_state_positioning_simple
> - drm_test_check_plane_state_rounding1
> - drm_test_check_plane_state_rounding2
> - drm_test_check_plane_state_rounding3
> - drm_test_check_plane_state_rounding4
> - drm_test_check_plane_state_upscaling
I found the source of failure to be f1e75da5364e ("drm/atomic: Loosen FB
atomic checks").
Fortunately for us, it's already been reverted yesterday for some
unrelated reason, so it should be fixed in next-20231205 onward.
Maxime
signature.asc
Description: PGP signature
Kunit drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123
The Kunit drm_plane_helper failed on all devices running Linux next-20231204 ## Test Regressions (compared to next-20231201) * qemu-armv7, kunit and * x86, kunit - drm_test_check_invalid_plane_state_downscaling_invalid - drm_test_check_invalid_plane_state_drm_plane_helper - drm_test_check_invalid_plane_state_drm_test_check_invalid_plane_state - drm_test_check_invalid_plane_state_positioning_invalid - drm_test_check_invalid_plane_state_upscaling_invalid - drm_test_check_plane_state_clipping_rotate_reflect - drm_test_check_plane_state_clipping_simple - drm_test_check_plane_state_downscaling - drm_test_check_plane_state_drm_test_check_plane_state - drm_test_check_plane_state_positioning_simple - drm_test_check_plane_state_rounding1 - drm_test_check_plane_state_rounding2 - drm_test_check_plane_state_rounding3 - drm_test_check_plane_state_rounding4 - drm_test_check_plane_state_upscaling Reported-by: Linux Kernel Functional Testing Test log: --- [ 91.955019] # Subtest: drm_plane_helper [ 91.959248] # module: drm_plane_helper_test [ 91.959271] 1..2 [ 91.966042] KTAP version 1 [ 91.969494] # Subtest: drm_test_check_plane_state [ 91.969707] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123 [ 91.969707] Expected plane_state->visible to be true, but is false [ 91.992346] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:96 [ 91.992346] Expected drm_rect_equals(_state->src, ) to be true, but is false [ 91.992346] [ 91.992346] dst: 2048.00x2048.00+0.00+0.00, expected: 1024.00x768.00+0.00+0.00 [ 91.992392] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:107 [ 91.992392] Expected drm_rect_equals(_state->dst, ) to be true, but is false [ 91.992392] [ 91.992392] dst: 2048x2048+0+0, expected: 1024x768+0+0 [ 92.023394] not ok 1 clipping_simple [ 92.049526] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123 [ 92.049526] Expected plane_state->visible to be true, but is false [ 92.071041] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:96 [ 92.071041] Expected drm_rect_equals(_state->src, ) to be true, but is false [ 92.071041] [ 92.071041] dst: 2048.00x2048.00+0.00+0.00, expected: 768.00x1024.00+0.00+0.00 [ 92.071084] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:107 [ 92.071084] Expected drm_rect_equals(_state->dst, ) to be true, but is false [ 92.071084] [ 92.071084] dst: 2048x2048+0+0, expected: 1024x768+0+0 [ 92.102010] not ok 2 clipping_rotate_reflect [ 92.128099] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123 [ 92.128099] Expected plane_state->visible to be true, but is false [ 92.150558] not ok 3 positioning_simple [ 92.150768] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123 [ 92.150768] Expected plane_state->visible to be true, but is false [ 92.173083] not ok 4 upscaling [ 92.173209] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123 [ 92.173209] Expected plane_state->visible to be true, but is false [ 92.194443] not ok 5 downscaling [ 92.194656] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123 [ 92.194656] Expected plane_state->visible to be true, but is false [ 92.215819] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:96 [ 92.215819] Expected drm_rect_equals(_state->src, ) to be true, but is false [ 92.215819] [ 92.215819] dst: 4.15x4.15+0.00+0.00, expected: 2.00x2.00+0.00+0.00 [ 92.215863] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:107 [ 92.215863] Expected drm_rect_equals(_state->dst, ) to be true, but is false [ 92.215863] [ 92.215863] dst: 4x4+1022+766, expected: 2x2+1022+766 [ 92.245779] not ok 6 rounding1 [ 92.271735] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:123 [ 92.271735] Expected plane_state->visible to be true, but is false [ 92.292739] # drm_test_check_plane_state: EXPECTATION FAILED at drivers/gpu/drm/tests/drm_plane_helper_test.c:96 [ 92.292739] Expected drm_rect_equals(_state->src, ) to be true, but is false [ 92.292739] [ 92.292739] dst:
