Re: [PATCH] BACKPORT: drm/amdgpu/disply: set num_crtc earlier

2022-06-03 Thread Greg KH 
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Jun 01, 2022 at 04:04:45AM +, Lin, Tsung-hua (Ryan) wrote:
> [AMD Official Use Only - General]
> 
> Hi Greg,
> 
> Thanks for your advice. I have modified the commit and submitted it to Gerrit 
> and it's under code review now.

This makes no sense to me, we do not use gerrit for kernel development.

confused,

greg k-h

RE: [PATCH] BACKPORT: drm/amdgpu/disply: set num_crtc earlier

2022-05-31 Thread Lin, Tsung-hua (Ryan) 
[AMD Official Use Only - General]

Hi Greg,

Thanks for your advice. I have modified the commit and submitted it to Gerrit 
and it's under code review now.

Many thanks,
Ryan Lin.

-Original Message-
From: Greg KH  
Sent: Monday, May 30, 2022 9:05 PM
To: Lin, Tsung-hua (Ryan) 
Cc: Li, Leon ; Swarnakar, Praful ; 
S, Shirish ; Li, Ching-shih (Louis) ; 
Deucher, Alexander ; Daniel Vetter 
; Kazlauskas, Nicholas ; 
sta...@vger.kernel.org; Wentland, Harry ; Li, Sun peng 
(Leo) ; Koenig, Christian ; David 
(ChunMing) Zhou ; David Airlie ; Bas 
Nieuwenhuizen ; Sean Paul ; 
Sasha Levin ; Mark Yacoub ; Li, Roman 
; Ikshwaku Chauhan 
; Simon Ser 
; amd-...@lists.freedesktop.org; 
dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org
Subject: Re: [PATCH] BACKPORT: drm/amdgpu/disply: set num_crtc earlier

On Mon, May 30, 2022 at 05:29:02PM +0800, Ryan Lin wrote:
> From: Alex Deucher 
> 
> To avoid a recently added warning:
>  Bogus possible_crtcs: [ENCODER:65:TMDS-65] possible_crtcs=0xf (full 
> crtc mask=0x7)
>  WARNING: CPU: 3 PID: 439 at drivers/gpu/drm/drm_mode_config.c:617 
> drm_mode_config_validate+0x178/0x200 [drm] In this case the warning is 
> harmless, but confusing to users.
> 
> Fixes: 0df108237433 ("drm: Validate encoder->possible_crtcs")
> Bug: 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> illa.kernel.org%2Fshow_bug.cgi%3Fid%3D209123data=05%7C01%7Ctsung-
> hua.lin%40amd.com%7Cad089e5485984cd0cc1f08da423d097f%7C3dd8961fe4884e6
> 08e11a82d994e183d%7C0%7C0%7C637895127184900879%7CUnknown%7CTWFpbGZsb3d
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000%7C%7C%7Csdata=0UcR%2BZszfxXaFz6LUqGq5eYgeqxDdrhySBL7mDmFPKc%
> 3Dreserved=0
> Reviewed-by: Daniel Vetter 
> Reviewed-by: Nicholas Kazlauskas 
> Signed-off-by: Alex Deucher 
> Cc: sta...@vger.kernel.org


Why did you not sign off on this?

And what is the git id of this in Linus's tree?

> Conflicts:
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>   [Ryan Lin: Fixed the conflict, remove the non-main changed part
>   of this patch]

No need for this here, right?

thanks,

greg k-h

Re: [PATCH] BACKPORT: drm/amdgpu/disply: set num_crtc earlier

2022-05-30 Thread Greg KH 
On Mon, May 30, 2022 at 05:29:02PM +0800, Ryan Lin wrote:
> From: Alex Deucher 
> 
> To avoid a recently added warning:
>  Bogus possible_crtcs: [ENCODER:65:TMDS-65] possible_crtcs=0xf (full crtc 
> mask=0x7)
>  WARNING: CPU: 3 PID: 439 at drivers/gpu/drm/drm_mode_config.c:617 
> drm_mode_config_validate+0x178/0x200 [drm]
> In this case the warning is harmless, but confusing to users.
> 
> Fixes: 0df108237433 ("drm: Validate encoder->possible_crtcs")
> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=209123
> Reviewed-by: Daniel Vetter 
> Reviewed-by: Nicholas Kazlauskas 
> Signed-off-by: Alex Deucher 
> Cc: sta...@vger.kernel.org


Why did you not sign off on this?

And what is the git id of this in Linus's tree?

> Conflicts:
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>   [Ryan Lin: Fixed the conflict, remove the non-main changed part
>   of this patch]

No need for this here, right?

thanks,

greg k-h