Re: [PATCH] drm/kmb: Remove an unnecessary NULL check
Hi Anitha, On Fri, Nov 20, 2020 at 05:28:59PM +, Chrisanthus, Anitha wrote: > > > > -Original Message- > > From: Thomas Zimmermann > > Sent: Friday, November 20, 2020 12:34 AM > > To: Sam Ravnborg ; Chrisanthus, Anitha > > > > Cc: David Airlie ; Dea, Edmund J ; > > kernel-janit...@vger.kernel.org; dri-devel@lists.freedesktop.org; Dan > > Carpenter > > Subject: Re: [PATCH] drm/kmb: Remove an unnecessary NULL check > > > > Hi > > > > Am 20.11.20 um 09:21 schrieb Sam Ravnborg: > > > Hi Anitha. > > > > > > On Fri, Nov 20, 2020 at 01:19:06AM +, Chrisanthus, Anitha wrote: > > >> Looks good to me. > > > > > > Can we get either an "Acked-by:" or "Reviewed-by:"? > > > Then we can use this while applying. > Sorry, forgot that. > Reviewed-by: Anitha Chrisanthus Thanks, patch is now pushed to drm-misc-next. Sam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
RE: [PATCH] drm/kmb: Remove an unnecessary NULL check
> -Original Message- > From: Thomas Zimmermann > Sent: Friday, November 20, 2020 12:34 AM > To: Sam Ravnborg ; Chrisanthus, Anitha > > Cc: David Airlie ; Dea, Edmund J ; > kernel-janit...@vger.kernel.org; dri-devel@lists.freedesktop.org; Dan > Carpenter > Subject: Re: [PATCH] drm/kmb: Remove an unnecessary NULL check > > Hi > > Am 20.11.20 um 09:21 schrieb Sam Ravnborg: > > Hi Anitha. > > > > On Fri, Nov 20, 2020 at 01:19:06AM +, Chrisanthus, Anitha wrote: > >> Looks good to me. > > > > Can we get either an "Acked-by:" or "Reviewed-by:"? > > Then we can use this while applying. Sorry, forgot that. Reviewed-by: Anitha Chrisanthus > > > > Any news on gettting commit access yourself? > > If not, then try to ping on the open ticket. > > It's been acked a while ago. I sent out a reminder to Daniel Stone. I did get access today, thank you! I will have to get familiar with dim and the whole process before I start pushing patches. > > Best regards > Thomas > > > > > > > Sam > > ___ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Felix Imendörffer ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/kmb: Remove an unnecessary NULL check
Hi Am 20.11.20 um 09:21 schrieb Sam Ravnborg: Hi Anitha. On Fri, Nov 20, 2020 at 01:19:06AM +, Chrisanthus, Anitha wrote: Looks good to me. Can we get either an "Acked-by:" or "Reviewed-by:"? Then we can use this while applying. Any news on gettting commit access yourself? If not, then try to ping on the open ticket. It's been acked a while ago. I sent out a reminder to Daniel Stone. Best regards Thomas Sam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer OpenPGP_0x680DC11D530B7A23.asc Description: application/pgp-keys OpenPGP_signature Description: OpenPGP digital signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/kmb: Remove an unnecessary NULL check
Hi Anitha. On Fri, Nov 20, 2020 at 01:19:06AM +, Chrisanthus, Anitha wrote: > Looks good to me. Can we get either an "Acked-by:" or "Reviewed-by:"? Then we can use this while applying. Any news on gettting commit access yourself? If not, then try to ping on the open ticket. Sam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
RE: [PATCH] drm/kmb: Remove an unnecessary NULL check
Looks good to me.
Anitha
> -Original Message-
> From: Dan Carpenter
> Sent: Monday, November 16, 2020 11:22 PM
> To: Chrisanthus, Anitha
> Cc: Dea, Edmund J ; David Airlie ;
> Daniel Vetter ; dri-devel@lists.freedesktop.org; kernel-
> janit...@vger.kernel.org
> Subject: [PATCH] drm/kmb: Remove an unnecessary NULL check
>
> The NULL checking isn't done consistently in this function and it leads
> to a static checker warning:
>
> drivers/gpu/drm/kmb/kmb_drv.c:561 kmb_pm_suspend()
> error: we previously assumed 'drm' could be null (see line 559)
>
> Fortunately "drm" cannot be NULL at this point so the check can just be
> removed.
>
> Signed-off-by: Dan Carpenter
> ---
> drivers/gpu/drm/kmb/kmb_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/kmb/kmb_drv.c
> b/drivers/gpu/drm/kmb/kmb_drv.c
> index 8c43b136765c..5ff392644603 100644
> --- a/drivers/gpu/drm/kmb/kmb_drv.c
> +++ b/drivers/gpu/drm/kmb/kmb_drv.c
> @@ -557,7 +557,7 @@ MODULE_DEVICE_TABLE(of, kmb_of_match);
> static int __maybe_unused kmb_pm_suspend(struct device *dev)
> {
> struct drm_device *drm = dev_get_drvdata(dev);
> - struct kmb_drm_private *kmb = drm ? to_kmb(drm) : NULL;
> + struct kmb_drm_private *kmb = to_kmb(drm);
>
> drm_kms_helper_poll_disable(drm);
>
> --
> 2.28.0
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
