Re: [PATCH] staging: vboxvideo adapt to new TTM interface

[Christian König]

Hi Roger,

you already pinged the right persons, just be a bit more patience about it.

They are probably just on vacation.

Regards,
Christian.

PS: Happy new year!

Am 02.01.2018 um 03:15 schrieb He, Roger:

+Alex

Do you know who can help about it?


Thanks
Roger(Hongbo.He)

-Original Message-
From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of 
He, Roger
Sent: Thursday, December 28, 2017 6:21 PM
To: dri-devel@lists.freedesktop.org; Bridgman, John <john.bridg...@amd.com>; Gregory, Robert 
<robert.greg...@amd.com>; Khan, Tahir <tahir.k...@amd.com>; Shamim, Zafar 
<zafar.sha...@amd.com>
Cc: hdego...@redhat.com; Koenig, Christian <christian.koe...@amd.com>; 
gre...@linuxfoundation.org
Subject: RE: [PATCH] staging: vboxvideo adapt to new TTM interface

Seems I have no permission to push the patch into amd-staging-drm-next.
Needs Whitelisted.

http://git.amd.com:8080/#/c/124051/1
anyone can help?

Thanks
Roger(Hongbo.He)
-Original Message-
From: Zhou, David(ChunMing)
Sent: Thursday, December 28, 2017 12:24 PM
To: He, Roger <hongbo...@amd.com>; dri-devel@lists.freedesktop.org
Cc: hdego...@redhat.com; gre...@linuxfoundation.org; Koenig, Christian 
<christian.koe...@amd.com>; Zhou, David(ChunMing) <david1.z...@amd.com>
Subject: Re: [PATCH] staging: vboxvideo adapt to new TTM interface

Reviewed-by: Chunming Zhou <david1.z...@amd.com>


On 2017年12月28日 11:35, Roger He wrote:

Fixes interface change done in the following commit:
eb86c98 drm/ttm: use an operation ctx for ttm_tt_populate in ttm_bo_driver

i missed this driver because it is in staging dir.

Signed-off-by: Roger He <hongbo...@amd.com>
---
   drivers/staging/vboxvideo/vbox_ttm.c | 5 +++--
   1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vboxvideo/vbox_ttm.c 
b/drivers/staging/vboxvideo/vbox_ttm.c
index 231c89e..55f14c9 100644
--- a/drivers/staging/vboxvideo/vbox_ttm.c
+++ b/drivers/staging/vboxvideo/vbox_ttm.c
@@ -213,9 +213,10 @@ static struct ttm_tt *vbox_ttm_tt_create(struct 
ttm_bo_device *bdev,
return tt;
   }
   
-static int vbox_ttm_tt_populate(struct ttm_tt *ttm)

+static int vbox_ttm_tt_populate(struct ttm_tt *ttm,
+   struct ttm_operation_ctx *ctx)
   {
-   return ttm_pool_populate(ttm);
+   return ttm_pool_populate(ttm, ctx);
   }
   
   static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [PATCH] staging: vboxvideo adapt to new TTM interface

[He, Roger]

+Alex

Do you know who can help about it?


Thanks
Roger(Hongbo.He)

-Original Message-
From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of 
He, Roger
Sent: Thursday, December 28, 2017 6:21 PM
To: dri-devel@lists.freedesktop.org; Bridgman, John <john.bridg...@amd.com>; 
Gregory, Robert <robert.greg...@amd.com>; Khan, Tahir <tahir.k...@amd.com>; 
Shamim, Zafar <zafar.sha...@amd.com>
Cc: hdego...@redhat.com; Koenig, Christian <christian.koe...@amd.com>; 
gre...@linuxfoundation.org
Subject: RE: [PATCH] staging: vboxvideo adapt to new TTM interface

Seems I have no permission to push the patch into amd-staging-drm-next.
Needs Whitelisted.

http://git.amd.com:8080/#/c/124051/1
anyone can help?

Thanks
Roger(Hongbo.He)
-Original Message-
From: Zhou, David(ChunMing) 
Sent: Thursday, December 28, 2017 12:24 PM
To: He, Roger <hongbo...@amd.com>; dri-devel@lists.freedesktop.org
Cc: hdego...@redhat.com; gre...@linuxfoundation.org; Koenig, Christian 
<christian.koe...@amd.com>; Zhou, David(ChunMing) <david1.z...@amd.com>
Subject: Re: [PATCH] staging: vboxvideo adapt to new TTM interface

Reviewed-by: Chunming Zhou <david1.z...@amd.com>


On 2017年12月28日 11:35, Roger He wrote:
> Fixes interface change done in the following commit:
> eb86c98 drm/ttm: use an operation ctx for ttm_tt_populate in ttm_bo_driver
>
> i missed this driver because it is in staging dir.
>
> Signed-off-by: Roger He <hongbo...@amd.com>
> ---
>   drivers/staging/vboxvideo/vbox_ttm.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_ttm.c 
> b/drivers/staging/vboxvideo/vbox_ttm.c
> index 231c89e..55f14c9 100644
> --- a/drivers/staging/vboxvideo/vbox_ttm.c
> +++ b/drivers/staging/vboxvideo/vbox_ttm.c
> @@ -213,9 +213,10 @@ static struct ttm_tt *vbox_ttm_tt_create(struct 
> ttm_bo_device *bdev,
>   return tt;
>   }
>   
> -static int vbox_ttm_tt_populate(struct ttm_tt *ttm)
> +static int vbox_ttm_tt_populate(struct ttm_tt *ttm,
> + struct ttm_operation_ctx *ctx)
>   {
> - return ttm_pool_populate(ttm);
> + return ttm_pool_populate(ttm, ctx);
>   }
>   
>   static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [PATCH] staging: vboxvideo adapt to new TTM interface

[He, Roger]

Seems I have no permission to push the patch into amd-staging-drm-next.
Needs Whitelisted.

http://git.amd.com:8080/#/c/124051/1
anyone can help?

Thanks
Roger(Hongbo.He)
-Original Message-
From: Zhou, David(ChunMing) 
Sent: Thursday, December 28, 2017 12:24 PM
To: He, Roger <hongbo...@amd.com>; dri-devel@lists.freedesktop.org
Cc: hdego...@redhat.com; gre...@linuxfoundation.org; Koenig, Christian 
<christian.koe...@amd.com>; Zhou, David(ChunMing) <david1.z...@amd.com>
Subject: Re: [PATCH] staging: vboxvideo adapt to new TTM interface

Reviewed-by: Chunming Zhou <david1.z...@amd.com>


On 2017年12月28日 11:35, Roger He wrote:
> Fixes interface change done in the following commit:
> eb86c98 drm/ttm: use an operation ctx for ttm_tt_populate in ttm_bo_driver
>
> i missed this driver because it is in staging dir.
>
> Signed-off-by: Roger He <hongbo...@amd.com>
> ---
>   drivers/staging/vboxvideo/vbox_ttm.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_ttm.c 
> b/drivers/staging/vboxvideo/vbox_ttm.c
> index 231c89e..55f14c9 100644
> --- a/drivers/staging/vboxvideo/vbox_ttm.c
> +++ b/drivers/staging/vboxvideo/vbox_ttm.c
> @@ -213,9 +213,10 @@ static struct ttm_tt *vbox_ttm_tt_create(struct 
> ttm_bo_device *bdev,
>   return tt;
>   }
>   
> -static int vbox_ttm_tt_populate(struct ttm_tt *ttm)
> +static int vbox_ttm_tt_populate(struct ttm_tt *ttm,
> + struct ttm_operation_ctx *ctx)
>   {
> - return ttm_pool_populate(ttm);
> + return ttm_pool_populate(ttm, ctx);
>   }
>   
>   static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] staging: vboxvideo adapt to new TTM interface

[Chunming Zhou]

Reviewed-by: Chunming Zhou 


On 2017年12月28日 11:35, Roger He wrote:

Fixes interface change done in the following commit:
eb86c98 drm/ttm: use an operation ctx for ttm_tt_populate in ttm_bo_driver

i missed this driver because it is in staging dir.

Signed-off-by: Roger He 
---
  drivers/staging/vboxvideo/vbox_ttm.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vboxvideo/vbox_ttm.c 
b/drivers/staging/vboxvideo/vbox_ttm.c
index 231c89e..55f14c9 100644
--- a/drivers/staging/vboxvideo/vbox_ttm.c
+++ b/drivers/staging/vboxvideo/vbox_ttm.c
@@ -213,9 +213,10 @@ static struct ttm_tt *vbox_ttm_tt_create(struct 
ttm_bo_device *bdev,
return tt;
  }
  
-static int vbox_ttm_tt_populate(struct ttm_tt *ttm)

+static int vbox_ttm_tt_populate(struct ttm_tt *ttm,
+   struct ttm_operation_ctx *ctx)
  {
-   return ttm_pool_populate(ttm);
+   return ttm_pool_populate(ttm, ctx);
  }
  
  static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] staging: vboxvideo: adapt to new TTM interface

[Alex Deucher]

On Fri, Nov 24, 2017 at 5:32 AM, Christian König
 wrote:
> Fixes interface changes done in the following commits:
> drm/ttm: add operation ctx to ttm_bo_validate v2
> drm/ttm: add context to driver move callback as well
>
> I missed this driver because it is in the staging area.
>
> Signed-off-by: Christian König 
> Reviewed-by: Hans de Goede 

Acked-by: Alex Deucher 

Alex

> ---
>  drivers/staging/vboxvideo/vbox_ttm.c | 17 ++---
>  1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_ttm.c 
> b/drivers/staging/vboxvideo/vbox_ttm.c
> index 4eb410a2a1a8..231c89e0699c 100644
> --- a/drivers/staging/vboxvideo/vbox_ttm.c
> +++ b/drivers/staging/vboxvideo/vbox_ttm.c
> @@ -183,13 +183,6 @@ static void vbox_ttm_io_mem_free(struct ttm_bo_device 
> *bdev,
>  {
>  }
>
> -static int vbox_bo_move(struct ttm_buffer_object *bo,
> -   bool evict, bool interruptible,
> -   bool no_wait_gpu, struct ttm_mem_reg *new_mem)
> -{
> -   return ttm_bo_move_memcpy(bo, interruptible, no_wait_gpu, new_mem);
> -}
> -
>  static void vbox_ttm_backend_destroy(struct ttm_tt *tt)
>  {
> ttm_tt_fini(tt);
> @@ -237,7 +230,6 @@ static struct ttm_bo_driver vbox_bo_driver = {
> .init_mem_type = vbox_bo_init_mem_type,
> .eviction_valuable = ttm_bo_eviction_valuable,
> .evict_flags = vbox_bo_evict_flags,
> -   .move = vbox_bo_move,
> .verify_access = vbox_bo_verify_access,
> .io_mem_reserve = _ttm_io_mem_reserve,
> .io_mem_free = _ttm_io_mem_free,
> @@ -374,6 +366,7 @@ static inline u64 vbox_bo_gpu_offset(struct vbox_bo *bo)
>
>  int vbox_bo_pin(struct vbox_bo *bo, u32 pl_flag, u64 *gpu_addr)
>  {
> +   struct ttm_operation_ctx ctx = { false, false };
> int i, ret;
>
> if (bo->pin_count) {
> @@ -389,7 +382,7 @@ int vbox_bo_pin(struct vbox_bo *bo, u32 pl_flag, u64 
> *gpu_addr)
> for (i = 0; i < bo->placement.num_placement; i++)
> bo->placements[i].flags |= TTM_PL_FLAG_NO_EVICT;
>
> -   ret = ttm_bo_validate(>bo, >placement, false, false);
> +   ret = ttm_bo_validate(>bo, >placement, );
> if (ret)
> return ret;
>
> @@ -403,6 +396,7 @@ int vbox_bo_pin(struct vbox_bo *bo, u32 pl_flag, u64 
> *gpu_addr)
>
>  int vbox_bo_unpin(struct vbox_bo *bo)
>  {
> +   struct ttm_operation_ctx ctx = { false, false };
> int i, ret;
>
> if (!bo->pin_count) {
> @@ -416,7 +410,7 @@ int vbox_bo_unpin(struct vbox_bo *bo)
> for (i = 0; i < bo->placement.num_placement; i++)
> bo->placements[i].flags &= ~TTM_PL_FLAG_NO_EVICT;
>
> -   ret = ttm_bo_validate(>bo, >placement, false, false);
> +   ret = ttm_bo_validate(>bo, >placement, );
> if (ret)
> return ret;
>
> @@ -430,6 +424,7 @@ int vbox_bo_unpin(struct vbox_bo *bo)
>   */
>  int vbox_bo_push_sysram(struct vbox_bo *bo)
>  {
> +   struct ttm_operation_ctx ctx = { false, false };
> int i, ret;
>
> if (!bo->pin_count) {
> @@ -448,7 +443,7 @@ int vbox_bo_push_sysram(struct vbox_bo *bo)
> for (i = 0; i < bo->placement.num_placement; i++)
> bo->placements[i].flags |= TTM_PL_FLAG_NO_EVICT;
>
> -   ret = ttm_bo_validate(>bo, >placement, false, false);
> +   ret = ttm_bo_validate(>bo, >placement, );
> if (ret) {
> DRM_ERROR("pushing to VRAM failed\n");
> return ret;
> --
> 2.11.0
>
> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] staging: vboxvideo: adapt to new TTM interface

[Greg KH]

On Fri, Nov 24, 2017 at 01:53:16PM +0100, Christian König wrote:
> Am 24.11.2017 um 11:37 schrieb Greg KH:
> > On Fri, Nov 24, 2017 at 11:32:59AM +0100, Christian König wrote:
> > > Fixes interface changes done in the following commits:
> > > drm/ttm: add operation ctx to ttm_bo_validate v2
> > > drm/ttm: add context to driver move callback as well
> > Any hints on the git commit ids in Linus's tree?
> 
> Those haven't arrived in Linus tree yet.
> 
> > And does this mean the driver's build is now broken?
> 
> Yes, it broke the build. Sorry that was my fault, didn't had this staging
> driver activated in the config nor noticed that there is an user of ttm
> outside the drm directory.
> 
> > Should this go through the staging tree, or is it to go through the drm 
> > tree?
> 
> The DRM tree I think. We should probably squash this patch into the original
> change which broke the driver in the DRM tree.

That's fine with me, thanks for the patch:

Acked-by: Greg Kroah-Hartman 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] staging: vboxvideo: adapt to new TTM interface

[Christian König]

Am 24.11.2017 um 11:37 schrieb Greg KH:

On Fri, Nov 24, 2017 at 11:32:59AM +0100, Christian König wrote:

Fixes interface changes done in the following commits:
drm/ttm: add operation ctx to ttm_bo_validate v2
drm/ttm: add context to driver move callback as well

Any hints on the git commit ids in Linus's tree?


Those haven't arrived in Linus tree yet.


And does this mean the driver's build is now broken?


Yes, it broke the build. Sorry that was my fault, didn't had this 
staging driver activated in the config nor noticed that there is an user 
of ttm outside the drm directory.



Should this go through the staging tree, or is it to go through the drm tree?


The DRM tree I think. We should probably squash this patch into the 
original change which broke the driver in the DRM tree.


Regards,
Christian.



thanks,

greg k-h



___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] staging: vboxvideo: adapt to new TTM interface

[Greg KH]

On Fri, Nov 24, 2017 at 11:32:59AM +0100, Christian König wrote:
> Fixes interface changes done in the following commits:
> drm/ttm: add operation ctx to ttm_bo_validate v2
> drm/ttm: add context to driver move callback as well

Any hints on the git commit ids in Linus's tree?

And does this mean the driver's build is now broken?  Should this go
through the staging tree, or is it to go through the drm tree?

thanks,

greg k-h
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] staging: vboxvideo: adapt to new TTM interface

[Christian König]

Am 24.11.2017 um 11:31 schrieb Greg KH:

On Fri, Nov 24, 2017 at 11:29:27AM +0100, Christian König wrote:

I missed this driver because it is in the staging area.

What does this changelog text mean???


Sorry for the confusion, the patch was originally part of a larger series.

Just send it out again with an updated commit message.




Signed-off-by: Christian König 
Reviewed-by: Hans de Goede 
---
  drivers/staging/vboxvideo/vbox_ttm.c | 17 ++---
  1 file changed, 6 insertions(+), 11 deletions(-)

Please provide something that makes sense when reading the changelog
text on its own.


Done, but please note that I'm not sure if the interface this breaks has 
already reached any of the relevant upstream repositories.


I just added you to the list of recipients because Hans suggested to do so.

Regards,
Christian.



thanks,

greg k-h



___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] staging: vboxvideo: adapt to new TTM interface

[Greg KH]

On Fri, Nov 24, 2017 at 11:29:27AM +0100, Christian König wrote:
> I missed this driver because it is in the staging area.

What does this changelog text mean???

> Signed-off-by: Christian König 
> Reviewed-by: Hans de Goede 
> ---
>  drivers/staging/vboxvideo/vbox_ttm.c | 17 ++---
>  1 file changed, 6 insertions(+), 11 deletions(-)

Please provide something that makes sense when reading the changelog
text on its own.

thanks,

greg k-h
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] staging: vboxvideo: adapt to new TTM interface

[Hans de Goede]

Hi,

On 23-11-17 17:14, Christian König wrote:

I missed this driver because it is in the staging area.

Signed-off-by: Christian König 


Thank you, looks good to me.

Can you please re-send this with Greh KH (the staging maintainer)
added in the To: list and my:

Reviewed-by: Hans de Goede 

Added?

Regards,

Hans



---
  drivers/staging/vboxvideo/vbox_ttm.c | 17 ++---
  1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/vboxvideo/vbox_ttm.c 
b/drivers/staging/vboxvideo/vbox_ttm.c
index 4eb410a2a1a8..231c89e0699c 100644
--- a/drivers/staging/vboxvideo/vbox_ttm.c
+++ b/drivers/staging/vboxvideo/vbox_ttm.c
@@ -183,13 +183,6 @@ static void vbox_ttm_io_mem_free(struct ttm_bo_device 
*bdev,
  {
  }
  
-static int vbox_bo_move(struct ttm_buffer_object *bo,

-   bool evict, bool interruptible,
-   bool no_wait_gpu, struct ttm_mem_reg *new_mem)
-{
-   return ttm_bo_move_memcpy(bo, interruptible, no_wait_gpu, new_mem);
-}
-
  static void vbox_ttm_backend_destroy(struct ttm_tt *tt)
  {
ttm_tt_fini(tt);
@@ -237,7 +230,6 @@ static struct ttm_bo_driver vbox_bo_driver = {
.init_mem_type = vbox_bo_init_mem_type,
.eviction_valuable = ttm_bo_eviction_valuable,
.evict_flags = vbox_bo_evict_flags,
-   .move = vbox_bo_move,
.verify_access = vbox_bo_verify_access,
.io_mem_reserve = _ttm_io_mem_reserve,
.io_mem_free = _ttm_io_mem_free,
@@ -374,6 +366,7 @@ static inline u64 vbox_bo_gpu_offset(struct vbox_bo *bo)
  
  int vbox_bo_pin(struct vbox_bo *bo, u32 pl_flag, u64 *gpu_addr)

  {
+   struct ttm_operation_ctx ctx = { false, false };
int i, ret;
  
  	if (bo->pin_count) {

@@ -389,7 +382,7 @@ int vbox_bo_pin(struct vbox_bo *bo, u32 pl_flag, u64 
*gpu_addr)
for (i = 0; i < bo->placement.num_placement; i++)
bo->placements[i].flags |= TTM_PL_FLAG_NO_EVICT;
  
-	ret = ttm_bo_validate(>bo, >placement, false, false);

+   ret = ttm_bo_validate(>bo, >placement, );
if (ret)
return ret;
  
@@ -403,6 +396,7 @@ int vbox_bo_pin(struct vbox_bo *bo, u32 pl_flag, u64 *gpu_addr)
  
  int vbox_bo_unpin(struct vbox_bo *bo)

  {
+   struct ttm_operation_ctx ctx = { false, false };
int i, ret;
  
  	if (!bo->pin_count) {

@@ -416,7 +410,7 @@ int vbox_bo_unpin(struct vbox_bo *bo)
for (i = 0; i < bo->placement.num_placement; i++)
bo->placements[i].flags &= ~TTM_PL_FLAG_NO_EVICT;
  
-	ret = ttm_bo_validate(>bo, >placement, false, false);

+   ret = ttm_bo_validate(>bo, >placement, );
if (ret)
return ret;
  
@@ -430,6 +424,7 @@ int vbox_bo_unpin(struct vbox_bo *bo)

   */
  int vbox_bo_push_sysram(struct vbox_bo *bo)
  {
+   struct ttm_operation_ctx ctx = { false, false };
int i, ret;
  
  	if (!bo->pin_count) {

@@ -448,7 +443,7 @@ int vbox_bo_push_sysram(struct vbox_bo *bo)
for (i = 0; i < bo->placement.num_placement; i++)
bo->placements[i].flags |= TTM_PL_FLAG_NO_EVICT;
  
-	ret = ttm_bo_validate(>bo, >placement, false, false);

+   ret = ttm_bo_validate(>bo, >placement, );
if (ret) {
DRM_ERROR("pushing to VRAM failed\n");
return ret;


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel