Re: next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings (next-20180110)

[Viresh Kumar]

On 10-01-18, 16:45, Arnd Bergmann wrote:
> > 7 arch/arm/boot/dts/spear1340-evb.dtb: Warning (dmas_property): Property 
> > 'dmas', cell 4 is not a phandle reference in /ahb/apb/serial@b410
> > 7 arch/arm/boot/dts/spear1340-evb.dtb: Warning (dmas_property): Missing 
> > property '#dma-cells' in node /interrupt-controller@ec801000 or bad phandle 
> > (referred from /ahb/apb/serial@b410:dmas[4])
> > 7 arch/arm/boot/dts/spear1310-evb.dtb: Warning (gpios_property): Property 
> > 'cs-gpios', cell 6 is not a phandle reference in /ahb/apb/spi@e010
> > 7 arch/arm/boot/dts/spear1310-evb.dtb: Warning (gpios_property): Missing 
> > property '#gpio-cells' in node /interrupt-controller@ec801000 or bad 
> > phandle (referred from /ahb/apb/spi@e010:cs-gpios[6])
> > 2 arch/arm/boot/dts/spear600-evb.dtb: Warning (interrupts_property): 
> > Missing interrupt-parent for /ahb/apb/rtc@fc90
> 
> Viresh, could you have a look here?

Sent fixes for all of them to you.

-- 
viresh
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings (next-20180110)

[He, Roger]

Calling kobject_put() after a failed kobject_init_and_add() seemed 
wrong, and it also appears to be missing a kfree(), so I didn't want 
to mess it up any further.

ttm_pool_kobj_release will do that, so no need kfree() here.
I will fix this warning today. Thanks.


Thanks
Roger(Hongbo.He)

-Original Message-
From: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] On Behalf Of Arnd 
Bergmann
Sent: Thursday, January 11, 2018 12:18 AM
To: Koenig, Christian <christian.koe...@amd.com>
Cc: kernelci.org bot <b...@kernelci.org>; Kernel Build Reports Mailman List 
<kernel-build-repo...@lists.linaro.org>; Linux Kernel Mailing List 
<linux-ker...@vger.kernel.org>; Thomas Hellstrom <thellst...@vmware.com>; Dave 
Airlie <airl...@redhat.com>; He, Roger <hongbo...@amd.com>; Maarten Lankhorst 
<maarten.lankho...@canonical.com>; Francisco Jerez <curroje...@riseup.net>; 
Viresh Kumar <vire...@kernel.org>; Shiraz Hashim 
<shiraz.linux.ker...@gmail.com>; Linus Walleij <linus.wall...@linaro.org>; 
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 
warnings (next-20180110)

On Wed, Jan 10, 2018 at 4:54 PM, Christian König <christian.koe...@amd.com> 
wrote:
> Hi Arnd,
>
> Am 10.01.2018 um 16:45 schrieb Arnd Bergmann:
>>>
>>> 14 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:1186:2: warning: 
>>> ignoring return value of 'register_shrinker', declared with 
>>> attribute warn_unused_result [-Wunused-result]
>>> 14 drivers/gpu/drm/ttm/ttm_page_alloc.c:485:2: warning: ignoring 
>>> return value of 'register_shrinker', declared with attribute 
>>> warn_unused_result [-Wunused-result]
>>
>> ttm and kvm are now the last user of register_shrinker that doesn't 
>> propagate the return code to its caller, all other callers got fixed 
>> in one way or another.
>>
>> I tried to fix this one too, but couldn't come up with a proper way 
>> of unwinding both
>> kobject_init_and_add() and ttm_pool_mm_shrink_init():
>>
>>  ret = kobject_init_and_add(&_manager->kobj, _pool_kobj_type,
>> >kobj, "pool");
>>  if (unlikely(ret != 0)) {
>>  kobject_put(&_manager->kobj);
>>  _manager = NULL;
>>  return ret;
>>  }
>>
>>  ttm_pool_mm_shrink_init(_manager);
>>
>> Calling kobject_put() after a failed kobject_init_and_add() seemed 
>> wrong, and it also appears to be missing a kfree(), so I didn't want 
>> to mess it up any further. Added a few people to Cc that touched this 
>> file most, maybe one of them can have a look, or they already have a 
>> patch waiting to get merged.
>
>
> That isn't urgent, isn't it? So I would say I put it on my TODO list 
> and I'm going to take care of it no later than 4.17.
>
> Otherwise Roger or me could take a look tomorrow.

My understanding is that the warning will be in 4.16, so the fix should be as 
well, if only to get a clean build again. There were around a dozen such 
warnings when the warn_unused_result got added, but the others are all fixed in 
linux-next.

This is how the flag got added:

commit 64067c5cbfa24a2202b92e8fda7323610cad3043
Author: Tetsuo Handa <penguin-ker...@i-love.sakura.ne.jp>
Date:   Fri Jan 5 13:25:45 2018 +1100

mm,vmscan: mark register_shrinker() as __must_check

There are users not checking for register_shrinker() failure.  Continuing
with ignoring failure can lead to later oops at unregister_shrinker().

Link: 
http://lkml.kernel.org/r/1511265757-15563-1-git-send-email-penguin-ker...@i-love.sakura.ne.jp
Signed-off-by: Tetsuo Handa <penguin-ker...@i-love.sakura.ne.jp>


Arnd
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings (next-20180110)

[Arnd Bergmann]

On Wed, Jan 10, 2018 at 4:54 PM, Christian König
 wrote:
> Hi Arnd,
>
> Am 10.01.2018 um 16:45 schrieb Arnd Bergmann:
>>>
>>> 14 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:1186:2: warning: ignoring
>>> return value of 'register_shrinker', declared with attribute
>>> warn_unused_result [-Wunused-result]
>>> 14 drivers/gpu/drm/ttm/ttm_page_alloc.c:485:2: warning: ignoring return
>>> value of 'register_shrinker', declared with attribute warn_unused_result
>>> [-Wunused-result]
>>
>> ttm and kvm are now the last user of register_shrinker that doesn't
>> propagate the return code to its
>> caller, all other callers got fixed in one way or another.
>>
>> I tried to fix this one too, but couldn't come up with a proper way of
>> unwinding both
>> kobject_init_and_add() and ttm_pool_mm_shrink_init():
>>
>>  ret = kobject_init_and_add(&_manager->kobj, _pool_kobj_type,
>> >kobj, "pool");
>>  if (unlikely(ret != 0)) {
>>  kobject_put(&_manager->kobj);
>>  _manager = NULL;
>>  return ret;
>>  }
>>
>>  ttm_pool_mm_shrink_init(_manager);
>>
>> Calling kobject_put() after a failed kobject_init_and_add() seemed wrong,
>> and it also appears to be missing a kfree(), so I didn't want to mess it
>> up any further. Added a few people to Cc that touched this file most,
>> maybe one of them can have a look, or they already have a patch waiting
>> to get merged.
>
>
> That isn't urgent, isn't it? So I would say I put it on my TODO list and I'm
> going to take care of it no later than 4.17.
>
> Otherwise Roger or me could take a look tomorrow.

My understanding is that the warning will be in 4.16, so the fix should be
as well, if only to get a clean build again. There were around a dozen such
warnings when the warn_unused_result got added, but the others are all
fixed in linux-next.

This is how the flag got added:

commit 64067c5cbfa24a2202b92e8fda7323610cad3043
Author: Tetsuo Handa 
Date:   Fri Jan 5 13:25:45 2018 +1100

mm,vmscan: mark register_shrinker() as __must_check

There are users not checking for register_shrinker() failure.  Continuing
with ignoring failure can lead to later oops at unregister_shrinker().

Link: 
http://lkml.kernel.org/r/1511265757-15563-1-git-send-email-penguin-ker...@i-love.sakura.ne.jp
Signed-off-by: Tetsuo Handa 


Arnd
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings (next-20180110)

[Christian König]

Hi Arnd,

Am 10.01.2018 um 16:45 schrieb Arnd Bergmann:

14 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:1186:2: warning: ignoring return 
value of 'register_shrinker', declared with attribute warn_unused_result 
[-Wunused-result]
14 drivers/gpu/drm/ttm/ttm_page_alloc.c:485:2: warning: ignoring return value 
of 'register_shrinker', declared with attribute warn_unused_result 
[-Wunused-result]

ttm and kvm are now the last user of register_shrinker that doesn't
propagate the return code to its
caller, all other callers got fixed in one way or another.

I tried to fix this one too, but couldn't come up with a proper way of
unwinding both
kobject_init_and_add() and ttm_pool_mm_shrink_init():

 ret = kobject_init_and_add(&_manager->kobj, _pool_kobj_type,
>kobj, "pool");
 if (unlikely(ret != 0)) {
 kobject_put(&_manager->kobj);
 _manager = NULL;
 return ret;
 }

 ttm_pool_mm_shrink_init(_manager);

Calling kobject_put() after a failed kobject_init_and_add() seemed wrong,
and it also appears to be missing a kfree(), so I didn't want to mess it
up any further. Added a few people to Cc that touched this file most,
maybe one of them can have a look, or they already have a patch waiting
to get merged.


That isn't urgent, isn't it? So I would say I put it on my TODO list and 
I'm going to take care of it no later than 4.17.


Otherwise Roger or me could take a look tomorrow.

Regards,
Christian.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings (next-20180110)

[Arnd Bergmann]

On Wed, Jan 10, 2018 at 7:59 AM, kernelci.org bot  wrote:
>
> next/master build: 198 builds: 1 failed, 197 passed, 1 error, 148 warnings 
> (next-20180110)
>
> Errors summary:
> 1 drivers/perf/arm_dsu_pmu.c:661:2: error: implicit declaration of function 
> 'bitmap_from_u32array' [-Werror=implicit-function-declaration]

I sent a patch, waiting for it to get merged

> Warnings summary:

> 1 arch/x86/kvm/mmu.c:5485:2: warning: ignoring return value of 
> 'register_shrinker', declared with attribute warn_unused_result 
> [-Wunused-result]

I have a patch for this, will send after some more testing.

> 14 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:1186:2: warning: ignoring return 
> value of 'register_shrinker', declared with attribute warn_unused_result 
> [-Wunused-result]
> 14 drivers/gpu/drm/ttm/ttm_page_alloc.c:485:2: warning: ignoring return value 
> of 'register_shrinker', declared with attribute warn_unused_result 
> [-Wunused-result]

ttm and kvm are now the last user of register_shrinker that doesn't
propagate the return code to its
caller, all other callers got fixed in one way or another.

I tried to fix this one too, but couldn't come up with a proper way of
unwinding both
kobject_init_and_add() and ttm_pool_mm_shrink_init():

ret = kobject_init_and_add(&_manager->kobj, _pool_kobj_type,
   >kobj, "pool");
if (unlikely(ret != 0)) {
kobject_put(&_manager->kobj);
_manager = NULL;
return ret;
}

ttm_pool_mm_shrink_init(_manager);

Calling kobject_put() after a failed kobject_init_and_add() seemed wrong,
and it also appears to be missing a kfree(), so I didn't want to mess it
up any further. Added a few people to Cc that touched this file most,
maybe one of them can have a look, or they already have a patch waiting
to get merged.

> 4 WARNING: modpost: missing MODULE_LICENSE() in net/9p/9pnet_xen.o
> 4 WARNING: modpost: missing MODULE_LICENSE() in 
> drivers/auxdisplay/img-ascii-lcd.o

Patches for these two got posted a while ago but never picked up. I've
merged those
into my tree, and plan to forward them to Andrew Morton.

> 3 WARNING: modpost: missing MODULE_LICENSE() in 
> sound/soc/ux500/snd-soc-ux500-plat-dma.o
> 3 WARNING: modpost: missing MODULE_LICENSE() in 
> sound/soc/ux500/snd-soc-ux500-mach-mop500.o
> 3 WARNING: modpost: missing MODULE_LICENSE() in 
> drivers/video/fbdev/mmp/mmp_disp.o
> 2 WARNING: modpost: missing MODULE_LICENSE() in 
> drivers/phy/qualcomm/phy-qcom-ufs.o
> 2 WARNING: modpost: missing MODULE_LICENSE() in 
> drivers/net/ethernet/cirrus/cs89x0.o
> 2 WARNING: modpost: missing MODULE_LICENSE() in arch/arm/mach-pxa/tosa-bt.o
> 2 WARNING: modpost: missing MODULE_LICENSE() in 
> arch/arm/common/bL_switcher_dummy_if.o

I made patches for these now, will send them in a bit.

> 7 arch/arm/boot/dts/spear1340-evb.dtb: Warning (dmas_property): Property 
> 'dmas', cell 4 is not a phandle reference in /ahb/apb/serial@b410
> 7 arch/arm/boot/dts/spear1340-evb.dtb: Warning (dmas_property): Missing 
> property '#dma-cells' in node /interrupt-controller@ec801000 or bad phandle 
> (referred from /ahb/apb/serial@b410:dmas[4])
> 7 arch/arm/boot/dts/spear1310-evb.dtb: Warning (gpios_property): Property 
> 'cs-gpios', cell 6 is not a phandle reference in /ahb/apb/spi@e010
> 7 arch/arm/boot/dts/spear1310-evb.dtb: Warning (gpios_property): Missing 
> property '#gpio-cells' in node /interrupt-controller@ec801000 or bad phandle 
> (referred from /ahb/apb/spi@e010:cs-gpios[6])
> 2 arch/arm/boot/dts/spear600-evb.dtb: Warning (interrupts_property): Missing 
> interrupt-parent for /ahb/apb/rtc@fc90

Viresh, could you have a look here?

> 2 arch/arm/boot/dts/ste-nomadik-s8815.dtb: Warning (interrupts_property): 
> Missing interrupt-parent for /amba/clcd@1012
> 2 arch/arm/boot/dts/ste-nomadik-nhk15.dtb: Warning (interrupts_property): 
> Missing interrupt-parent for /amba/clcd@1012

Linus, can you look at this? I don't know which interrupt-parent is
the right one here, maybe
you can find out from the hardware or some documentation you have.

> 2 arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): reset-gpio 
> property size (12) too small for cell size 3 in 
> /ahb/apb/i2c@400A/uda1380@18
> 2 arch/arm/boot/dts/lpc3250-phy3250.dtb: Warning (gpios_property): power-gpio 
> property size (12) too small for cell size 3 in 
> /ahb/apb/i2c@400A/uda1380@18
> 2 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): reset-gpio 
> property size (12) too small for cell size 3 in 
> /ahb/apb/i2c@400A/uda1380@18
> 2 arch/arm/boot/dts/lpc3250-ea3250.dtb: Warning (gpios_property): power-gpio 
> property size (12) too small for cell size 3 in 
> /ahb/apb/i2c@400A/uda1380@18

I finally found the answer here and got a patch now.

> 6 arch/arm/boot/dts/stih410-b2260.dtb: Warning (gpios_property): 
> hdmi,hpd-gpio property size (8) too