Re: [1/4] fbdev: imsttfb: Fix error handling in init_imstt()

[Markus Elfring]

> I think the return value isn't checked at all, so you could
> simply return below "-ENODEV" for all cases (instead of "return ret").
> Then you don't need the e_nodev label and can simplify the flow.

I noticed that the software evolution was continued with an other change 
variant.

fbdev: imsttfb: Release framebuffer and dealloc cmap on error path
https://lore.kernel.org/linux-fbdev/20230527093016.486521-1-del...@gmx.de/
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/video/fbdev/imsttfb.c?h=v6.4-rc5=5cf9a090a39c97f4506b7b53739d469b1c05a7e9

Regards,
Markus

Re: [1/4] fbdev: imsttfb: Fix error handling in init_imstt()

[Markus Elfring]

>> Can it be helpful to distinguish involved error codes better?
>
> No.

I find such a feedback surprising.

May the error code be preserved from a failed call of the function 
“fb_alloc_cmap”?

Regards,
Markus