Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags
On 19/11/2023 20:50, Marek Vasut wrote:
On 11/17/23 09:40, Maxime Ripard wrote:
On Thu, Nov 16, 2023 at 10:15:31PM +0100, Marek Vasut wrote:
On 10/9/23 10:58, Neil Armstrong wrote:
On 09/10/2023 00:33, Marek Vasut wrote:
Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description,
ones which match both the datasheet and the panel display_timing flags .
Fixes: 1e29b840af9f ("drm/panel: simple: Add Innolux G101ICE-L01 panel")
Signed-off-by: Marek Vasut
---
Cc: Daniel Vetter
Cc: David Airlie
Cc: Jessica Zhang
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Neil Armstrong
Cc: Sam Ravnborg
Cc: Thomas Zimmermann
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/panel/panel-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm/panel/panel-simple.c
index 44c11c418cd56..8e4ea15f0e1e5 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2318,6 +2318,7 @@ static const struct panel_desc
innolux_g101ice_l01 = {
.disable = 200,
},
.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH,
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};
Reviewed-by: Neil Armstrong
Maybe it is time to apply ?
The expectation is that you would kind of apply it yourself. Do you have
a drm-misc committer account? If not, you should apply for one, you
definitely qualify.
Applied to drm-misc/fixes
Sorry for the delay, thx for applying it finally.
Neil
Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags
On 11/17/23 09:40, Maxime Ripard wrote:
On Thu, Nov 16, 2023 at 10:15:31PM +0100, Marek Vasut wrote:
On 10/9/23 10:58, Neil Armstrong wrote:
On 09/10/2023 00:33, Marek Vasut wrote:
Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description,
ones which match both the datasheet and the panel display_timing flags .
Fixes: 1e29b840af9f ("drm/panel: simple: Add Innolux G101ICE-L01 panel")
Signed-off-by: Marek Vasut
---
Cc: Daniel Vetter
Cc: David Airlie
Cc: Jessica Zhang
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Neil Armstrong
Cc: Sam Ravnborg
Cc: Thomas Zimmermann
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/panel/panel-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm/panel/panel-simple.c
index 44c11c418cd56..8e4ea15f0e1e5 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2318,6 +2318,7 @@ static const struct panel_desc
innolux_g101ice_l01 = {
.disable = 200,
},
.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH,
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};
Reviewed-by: Neil Armstrong
Maybe it is time to apply ?
The expectation is that you would kind of apply it yourself. Do you have
a drm-misc committer account? If not, you should apply for one, you
definitely qualify.
Applied to drm-misc/fixes
Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags
On 11/17/23 09:40, Maxime Ripard wrote:
On Thu, Nov 16, 2023 at 10:15:31PM +0100, Marek Vasut wrote:
On 10/9/23 10:58, Neil Armstrong wrote:
On 09/10/2023 00:33, Marek Vasut wrote:
Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description,
ones which match both the datasheet and the panel display_timing flags .
Fixes: 1e29b840af9f ("drm/panel: simple: Add Innolux G101ICE-L01 panel")
Signed-off-by: Marek Vasut
---
Cc: Daniel Vetter
Cc: David Airlie
Cc: Jessica Zhang
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Neil Armstrong
Cc: Sam Ravnborg
Cc: Thomas Zimmermann
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/panel/panel-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm/panel/panel-simple.c
index 44c11c418cd56..8e4ea15f0e1e5 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2318,6 +2318,7 @@ static const struct panel_desc
innolux_g101ice_l01 = {
.disable = 200,
},
.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH,
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};
Reviewed-by: Neil Armstrong
Maybe it is time to apply ?
The expectation is that you would kind of apply it yourself. Do you have
a drm-misc committer account? If not, you should apply for one, you
definitely qualify.
I do, I'm just not a big fan of applying my own patches, but since there
is a RB, I will do that in a bit.
Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags
On Thu, Nov 16, 2023 at 10:15:31PM +0100, Marek Vasut wrote:
> On 10/9/23 10:58, Neil Armstrong wrote:
> > On 09/10/2023 00:33, Marek Vasut wrote:
> > > Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description,
> > > ones which match both the datasheet and the panel display_timing flags .
> > >
> > > Fixes: 1e29b840af9f ("drm/panel: simple: Add Innolux G101ICE-L01 panel")
> > > Signed-off-by: Marek Vasut
> > > ---
> > > Cc: Daniel Vetter
> > > Cc: David Airlie
> > > Cc: Jessica Zhang
> > > Cc: Maarten Lankhorst
> > > Cc: Maxime Ripard
> > > Cc: Neil Armstrong
> > > Cc: Sam Ravnborg
> > > Cc: Thomas Zimmermann
> > > Cc: dri-devel@lists.freedesktop.org
> > > ---
> > > drivers/gpu/drm/panel/panel-simple.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > > b/drivers/gpu/drm/panel/panel-simple.c
> > > index 44c11c418cd56..8e4ea15f0e1e5 100644
> > > --- a/drivers/gpu/drm/panel/panel-simple.c
> > > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > > @@ -2318,6 +2318,7 @@ static const struct panel_desc
> > > innolux_g101ice_l01 = {
> > > .disable = 200,
> > > },
> > > .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> > > + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> > > .connector_type = DRM_MODE_CONNECTOR_LVDS,
> > > };
> >
> > Reviewed-by: Neil Armstrong
>
> Maybe it is time to apply ?
The expectation is that you would kind of apply it yourself. Do you have
a drm-misc committer account? If not, you should apply for one, you
definitely qualify.
Maxime
signature.asc
Description: PGP signature
Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags
On 10/9/23 10:58, Neil Armstrong wrote:
On 09/10/2023 00:33, Marek Vasut wrote:
Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description,
ones which match both the datasheet and the panel display_timing flags .
Fixes: 1e29b840af9f ("drm/panel: simple: Add Innolux G101ICE-L01 panel")
Signed-off-by: Marek Vasut
---
Cc: Daniel Vetter
Cc: David Airlie
Cc: Jessica Zhang
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Neil Armstrong
Cc: Sam Ravnborg
Cc: Thomas Zimmermann
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/panel/panel-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm/panel/panel-simple.c
index 44c11c418cd56..8e4ea15f0e1e5 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2318,6 +2318,7 @@ static const struct panel_desc
innolux_g101ice_l01 = {
.disable = 200,
},
.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH,
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};
Reviewed-by: Neil Armstrong
Maybe it is time to apply ?
Re: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 bus flags
On 09/10/2023 00:33, Marek Vasut wrote:
Add missing .bus_flags = DRM_BUS_FLAG_DE_HIGH to this panel description,
ones which match both the datasheet and the panel display_timing flags .
Fixes: 1e29b840af9f ("drm/panel: simple: Add Innolux G101ICE-L01 panel")
Signed-off-by: Marek Vasut
---
Cc: Daniel Vetter
Cc: David Airlie
Cc: Jessica Zhang
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Neil Armstrong
Cc: Sam Ravnborg
Cc: Thomas Zimmermann
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/panel/panel-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm/panel/panel-simple.c
index 44c11c418cd56..8e4ea15f0e1e5 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2318,6 +2318,7 @@ static const struct panel_desc innolux_g101ice_l01 = {
.disable = 200,
},
.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH,
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};
Reviewed-by: Neil Armstrong
