Re: [PATCH] drm/radeon: don't mess with hot plug detect for eDP or LVDS connector v2
On Fri, May 4, 2012 at 11:06 AM, j.gli...@gmail.com wrote:
From: Jerome Glisse jgli...@redhat.com
It seems imac pannel doesn't like whe we change the hot plug setup
and then refuse to work. This help but doesn't fully fix:
https://bugzilla.redhat.com/show_bug.cgi?id=726143
How does it help? Does it fix the the aux problems, but the monitor
still doesn't train? What's the working value of the relevant
DC_HPD*_CONTROL register?
Alex
v2: fix typo and improve commit message
Signed-off-by: Matthew Garrett m...@redhat.com
Signed-off-by: Jerome Glisse jgli...@redhat.com
---
drivers/gpu/drm/radeon/r600.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
index 694b6b2..a304c9d 100644
--- a/drivers/gpu/drm/radeon/r600.c
+++ b/drivers/gpu/drm/radeon/r600.c
@@ -713,6 +713,14 @@ void r600_hpd_init(struct radeon_device *rdev)
list_for_each_entry(connector, dev-mode_config.connector_list, head)
{
struct radeon_connector *radeon_connector =
to_radeon_connector(connector);
+ if (connector-connector_type == DRM_MODE_CONNECTOR_eDP ||
+ connector-connector_type == DRM_MODE_CONNECTOR_LVDS) {
+ /* don't try to enable hpd on eDP or LVDS avoid
breaking the
+ * aux dp channel on imac and help (but not
completely fix)
+ * https://bugzilla.redhat.com/show_bug.cgi?id=726143
+ */
+ continue;
+ }
if (ASIC_IS_DCE3(rdev)) {
u32 tmp = DC_HPDx_CONNECTION_TIMER(0x9c4) |
DC_HPDx_RX_INT_TIMER(0xfa);
if (ASIC_IS_DCE32(rdev))
--
1.7.9.3
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/radeon: don't mess with hot plug detect for eDP or LVDS connector v2
On Wed, May 9, 2012 at 9:40 AM, Alex Deucher alexdeuc...@gmail.com wrote: On Fri, May 4, 2012 at 11:06 AM, j.gli...@gmail.com wrote: From: Jerome Glisse jgli...@redhat.com It seems imac pannel doesn't like whe we change the hot plug setup and then refuse to work. This help but doesn't fully fix: https://bugzilla.redhat.com/show_bug.cgi?id=726143 How does it help? Does it fix the the aux problems, but the monitor still doesn't train? What's the working value of the relevant DC_HPD*_CONTROL register? Alex Don't have the hw but somehow the way we program this reg completely disable the panel, after that the panel doesn't answer to anything (nor i2c nor any aux transaction). Without programming that link training is successfull but panel stays black. I can ask to get the value before and after. Cheers, Jerome ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/radeon: don't mess with hot plug detect for eDP or LVDS connector v2
On Wed, May 9, 2012 at 10:23 AM, Jerome Glisse j.gli...@gmail.com wrote: On Wed, May 9, 2012 at 9:40 AM, Alex Deucher alexdeuc...@gmail.com wrote: On Fri, May 4, 2012 at 11:06 AM, j.gli...@gmail.com wrote: From: Jerome Glisse jgli...@redhat.com It seems imac pannel doesn't like whe we change the hot plug setup and then refuse to work. This help but doesn't fully fix: https://bugzilla.redhat.com/show_bug.cgi?id=726143 How does it help? Does it fix the the aux problems, but the monitor still doesn't train? What's the working value of the relevant DC_HPD*_CONTROL register? Alex Don't have the hw but somehow the way we program this reg completely disable the panel, after that the panel doesn't answer to anything (nor i2c nor any aux transaction). Without programming that link training is successfull but panel stays black. I can ask to get the value before and after. Patch seems reasonable in general (we don't really need hpd to be explicitly enabled for lvds or edp) so: Reviewed-by: Alex Deucher alexander.deuc...@amd.com Cheers, Jerome ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
