Re: [PATCH] drm: display: Remove duplicated argument in dcn31

2021-06-09 Thread Alex Deucher
Applied.  Thanks!

On Wed, Jun 9, 2021 at 2:48 PM Rodrigo Siqueira
 wrote:
>
> On 06/09, Wan Jiabing wrote:
> > Fix the following coccicheck warning:
> > ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c:
> > 3539:12-42: duplicated argument to && or ||
> > ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c:
> > 5677:87-123: duplicated argument to && or ||
> >
> > Signed-off-by: Wan Jiabing 
> > ---
> >  .../gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c| 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c 
> > b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c
> > index d655655baaba..06fac59a3d40 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c
> > @@ -3536,7 +3536,7 @@ static bool CalculateBytePerPixelAnd256BBlockSizes(
> >   *BytePerPixelDETC = 0;
> >   *BytePerPixelY = 4;
> >   *BytePerPixelC = 0;
> > - } else if (SourcePixelFormat == dm_444_16 || SourcePixelFormat == 
> > dm_444_16) {
> > + } else if (SourcePixelFormat == dm_444_16) {
> >   *BytePerPixelDETY = 2;
> >   *BytePerPixelDETC = 0;
> >   *BytePerPixelY = 2;
> > @@ -5674,7 +5674,7 @@ void 
> > dml31_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
> >   for (k = 0; k < v->NumberOfActivePlanes; k++) {
> >   if (v->ViewportWidth[k] > v->SurfaceWidthY[k] || 
> > v->ViewportHeight[k] > v->SurfaceHeightY[k]) {
> >   ViewportExceedsSurface = true;
> > - if (v->SourcePixelFormat[k] != dm_444_64 && 
> > v->SourcePixelFormat[k] != dm_444_32 && v->SourcePixelFormat[k] != dm_444_16
> > + if (v->SourcePixelFormat[k] != dm_444_64 && 
> > v->SourcePixelFormat[k] != dm_444_32
> >   && v->SourcePixelFormat[k] != 
> > dm_444_16 && v->SourcePixelFormat[k] != dm_444_8
> >   && v->SourcePixelFormat[k] != 
> > dm_rgbe) {
> >   if (v->ViewportWidthChroma[k] > 
> > v->SurfaceWidthC[k]
> > --
> > 2.20.1
> >
>
> + Anson
>
> Reviewed-by: Rodrigo Siqueira 
>
> --
> Rodrigo Siqueira
> https://siqueira.tech
> ___
> amd-gfx mailing list
> amd-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


Re: [PATCH] drm: display: Remove duplicated argument in dcn31

2021-06-09 Thread Rodrigo Siqueira
On 06/09, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c:
> 3539:12-42: duplicated argument to && or ||
> ./drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c:
> 5677:87-123: duplicated argument to && or ||
> 
> Signed-off-by: Wan Jiabing 
> ---
>  .../gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c| 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c 
> b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c
> index d655655baaba..06fac59a3d40 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c
> @@ -3536,7 +3536,7 @@ static bool CalculateBytePerPixelAnd256BBlockSizes(
>   *BytePerPixelDETC = 0;
>   *BytePerPixelY = 4;
>   *BytePerPixelC = 0;
> - } else if (SourcePixelFormat == dm_444_16 || SourcePixelFormat == 
> dm_444_16) {
> + } else if (SourcePixelFormat == dm_444_16) {
>   *BytePerPixelDETY = 2;
>   *BytePerPixelDETC = 0;
>   *BytePerPixelY = 2;
> @@ -5674,7 +5674,7 @@ void dml31_ModeSupportAndSystemConfigurationFull(struct 
> display_mode_lib *mode_l
>   for (k = 0; k < v->NumberOfActivePlanes; k++) {
>   if (v->ViewportWidth[k] > v->SurfaceWidthY[k] || 
> v->ViewportHeight[k] > v->SurfaceHeightY[k]) {
>   ViewportExceedsSurface = true;
> - if (v->SourcePixelFormat[k] != dm_444_64 && 
> v->SourcePixelFormat[k] != dm_444_32 && v->SourcePixelFormat[k] != dm_444_16
> + if (v->SourcePixelFormat[k] != dm_444_64 && 
> v->SourcePixelFormat[k] != dm_444_32
>   && v->SourcePixelFormat[k] != dm_444_16 
> && v->SourcePixelFormat[k] != dm_444_8
>   && v->SourcePixelFormat[k] != dm_rgbe) {
>   if (v->ViewportWidthChroma[k] > 
> v->SurfaceWidthC[k]
> -- 
> 2.20.1
>

+ Anson

Reviewed-by: Rodrigo Siqueira  

-- 
Rodrigo Siqueira
https://siqueira.tech


signature.asc
Description: PGP signature